aMule Forum
English => Feature requests => Topic started by: Mowto on February 17, 2004, 08:05:49 PM
-
It will be possible in future compile amule with intel c compiler instead of gcc?
PartFile.cpp(461): warning #186: pointless comparison of unsigned integer with zero
if (gap->start >= 0 && gap->end >=0 && gap->start <= gap->end) { ^
PartFile.cpp(461): warning #186: pointless comparison of unsigned integer with zero
if (gap->start >= 0 && gap->end >=0 && gap->start <= gap->end) { ^
iccbin: error: Fatal error in /opt/intel/compiler80/bin/mcpcom, terminated by segmentation violation
compilation aborted for PartFile.cpp (code 1)
make[2]: *** [amule-PartFile.o] Error 1
make[2]: Leaving directory `/var/tmp/portage/amule-1.2.5/work/aMule-1.2.5/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/amule-1.2.5/work/aMule-1.2.5'
make: *** [all] Error 2
-
"pointless comparison of unsigned integer with zero"
pointless?
-
Maybe it's a compiler fault, i have compiled without any problem gkrellm 1.2.5, gtk+ 2.2.4, file-roller 2.4.4, gnome-panel 2.4.2, gnome-applets 2.4.2, for this reason i was curious to try with amule with that result :( i'm using icc cause optimize better for intel's cpu
-
ccbin: error: Fatal error in /opt/intel/compiler80/bin/mcpcom, terminated by segmentation violation
compilation aborted for PartFile.cpp (code 1)
Is for sure compiler error on that point ;)
-
Originally posted by Kry
"pointless comparison of unsigned integer with zero"
pointless?
gap->start >= 0
Since gap->start is an unsigned integer, it can only take values of 0 and above, so there is absolutly no point at checking that... 8)
-
That's true. But it should say:
"pointless comparison of unsigned integer with equal or above zero"
comparing a unsigned integer with 0 is not pointless at all.
-
BTW Avi: as you see, you can post here when you find my mistakes. That's something I cannot do on the other forum, as you perfectly know ;)
-
Originally posted by Kry
BTW Avi: as you see, you can post here when you find my mistakes. That's something I cannot do on the other forum, as you perfectly know ;)
I never had any problem with you being able to post in the other forums, as long as it's was a constructive message with a nice tone.
You and HopeSeekr will have to sort things out before I'll/he'll be able to unban the account...
About the topic, heh, the only reason I commented is because I'm reading about C++ right now and have learnt about signed/unsigned ints yesterday... I hoped I was right... :) (reading "teach yourself c++ in 21 days" lol)
Kind regards,
Avi :)
-
BTW, Mowto, what version of ICC do you use?
-
[OFF-TOPIC]
Well, keep banning me from your forums. Keep playing with toy-mules.
aMule has got Securehash, is finishing proxy, Mac and Win32 version are ready 99%, and I'm sure oyu know that because you're probably copying all code from our CVS.
We don't care anyway. I'm only waiting to see if you give aMule the credit.
[/OFF-TOPIC]
-
Originally posted by Kry
[OFF-TOPIC]
Well, keep banning me from your forums. Keep playing with toy-mules.
aMule has got Securehash, is finishing proxy, Mac and Win32 version are ready 99%, and I'm sure oyu know that because you're probably copying all code from our CVS.
We don't care anyway. I'm only waiting to see if you give aMule the credit.
[/OFF-TOPIC]
It is not I who banned you... it is HopeSeekr. I think it is fair to say that if he found a reason to ban you, I shouldn't unban without his permission... Meanwhile, no registration is needed in order to read posts...
About the features you posted here... yes... I saw the CVS commit messages... congratulations (really). I should probably say that xMule is also working on cross platform too.
Now, about credits of source code, the next version of xMule (I think it's even included in v1.7.4 which was released yesterday as a small bugfix) does contain credits to any code taken from aMule (it's in the header + a link to your website I believe).
Now, you shouldn't say that we copy all your code, because we simply don't. The current developmental version is so much refactored, it would be hell to try and copy code straight from aMule... I personally did not even look at aMule's sourcecode itself even once (I do look at CVS commit messages)... I find the source code of eMule v0.41b.29 (Kademlia) to be most helpful and porting is pretty easy.
On another note, I wanted to ask you... is Madcat in the aMule team? Does he develop ShareDaemon's wxInterface anymore?
Please, no need to be harsh, we are all adults.
Peace. :)
Avi.
-
Originally posted by Kry
[OFF-TOPIC]
Well, keep banning me from your forums. Keep playing with toy-mules.
aMule has got Securehash, is finishing proxy, Mac and Win32 version are ready 99%, and I'm sure oyu know that because you're probably copying all code from our CVS.
We don't care anyway. I'm only waiting to see if you give aMule the credit.
[/OFF-TOPIC]
I'm lost, what is this all about?
Tó
-
BTW, You should know that you can optimize your code to specfic arquitecture using GCC, I use -march=athlon-xp -O3 -pipe but there are lots or more complex optimizations.
Check them at: http://gcc.gnu.org/onlinedocs/gcc-3.1/gcc/Optimize-Options.html#Optimize%20Options (http://gcc.gnu.org/onlinedocs/gcc-3.1/gcc/Optimize-Options.html#Optimize%20Options)
Tó
-
Hahahahhaha that's funny. Some xMule files doesn't even have headers , and the files that have them are the old ones. HEH
ROFL
-
On another note, I wanted to ask you... is Madcat in the aMule team? Does he develop ShareDaemon's wxInterface anymore?
I'm still mainly developing ShareDaemon wxInterface, however, since the code is mostly compatible with aMule, I'm backporting my features to aMule so I can actually use my GUI features with aMule while SD Core is not finished.
Madcat.
-
Originally posted by Kry
That's true. But it should say:
"pointless comparison of unsigned integer with equal or above zero"
comparing a unsigned integer with 0 is not pointless at all.
Actually, if you look closer at it, it IS pointless, because the comparison will always return true. unsigned int can store integer type values from 0 to 65535, thus comparison >=0 will always return true, no matter the value of the variable.
Madcat.
-
Yes. I said, comparison WITH 0 it's pointless. And that's what the error say.
an unsigned it can be > 0 iirc :P