aMule Forum

English => en_Bugs => Topic started by: gav616 on May 07, 2009, 03:10:26 PM

Title: losing file data when renamed
Post by: gav616 on May 07, 2009, 03:10:26 PM
downloaded file 'X', completed the file, renamed 'X' to 'Y' (in my nix file-manager), aMule rehashes 'Y' and loses all the data from when named 'X',

shouldn't it know that I've just renamed it and keep the data? that's what MD4  is for, right?

using SVN
Title: Re: losing file data when renamed
Post by: Stu Redman on May 07, 2009, 09:49:06 PM
Yes, it should do that.
Title: Re: losing file data when renamed
Post by: Kry on May 07, 2009, 09:59:22 PM
Should it? Why do you assume it's the same file?
Title: Re: losing file data when renamed
Post by: Stu Redman on May 07, 2009, 10:07:33 PM
Same size and MD4 after hashing, same file.
Title: Re: losing file data when renamed
Post by: myth on May 07, 2009, 10:34:37 PM
I can confirm!

Maybe the statistics for the file are saved with the name of the file, and not with the hash?
Title: Re: losing file data when renamed
Post by: gav616 on May 07, 2009, 11:15:55 PM
yeap, names of files don't matter its the ID's....same with clients, nicks don't matter its there IP or ident i think.
Title: Re: losing file data when renamed
Post by: Kry on May 08, 2009, 02:19:15 AM
so what happens when you have the same file in two different places?

Title: Re: losing file data when renamed
Post by: gav616 on May 08, 2009, 01:47:09 PM
amule handles the same as emule and shares the first one,  ignoring the second 'same' file, regardless of name or location. But it couples the stats for the first one only.

why you would what to share same file twice?
Title: Re: losing file data when renamed
Post by: Stu Redman on May 08, 2009, 07:25:57 PM
so what happens when you have the same file in two different places?
Warning in the log view, and publish only the name of the first. The second one must be stored in known files too of course, or it will be rehashed every time.
Stats will stick to the hash, not to the file. This might mean both known files will be stored with identical stats (haven't investigated the data model).
You can't say for which one an upload request should be counted anyway.
Title: Re: losing file data when renamed
Post by: gav616 on May 14, 2009, 02:56:38 PM
so is this fixed yet? (or getting...)
Title: Re: losing file data when renamed
Post by: Stu Redman on May 14, 2009, 09:15:01 PM
Eventually, unless Kry decides to veto it.
Title: Re: losing file data when renamed
Post by: gav616 on November 26, 2009, 01:02:17 PM
This is still here and really annoying when co-releasing, any news on fixing?

(also renaming in shared files tab would help too)
Title: Re: losing file data when renamed
Post by: GonoszTopi on November 26, 2009, 07:00:30 PM
(also renaming in shared files tab would help too)

The patch is ready but one of the files it touches is still locked.
Title: Re: losing file data when renamed
Post by: gav616 on November 27, 2009, 07:29:58 PM
ahh i see.

*waits patiently *
Title: Re: losing file data when renamed
Post by: gav616 on May 17, 2010, 03:19:45 PM
I see '10174' enables renaming of completed file, this also seems to fix 'this' problem, It seems to keep all stats data from the file you rename.

p.s.

You have to restart 'rGUI' for the renamed file to update

EDIT*

I thought this problem was fixed, but it's not, if I rename the file in my file manager it resets all the data when I reload 'shared files' it's not recognising that its the same hash just a different name.
Title: Re: losing file data when renamed
Post by: Stu Redman on May 17, 2010, 07:29:17 PM
That's two different things actually.
Title: Re: losing file data when renamed
Post by: Stu Redman on March 09, 2011, 10:42:15 PM
*waits patiently *
Patience is rewarded in 10490.  :)

The patch is ready but one of the files it touches is still locked.
Whoops, only found that after it was done. But you had probably forgotten about it anyway.  ;)
Title: Re: losing file data when renamed
Post by: GonoszTopi on March 09, 2011, 10:53:52 PM
The patch is ready but one of the files it touches is still locked.
Whoops, only found that after it was done. But you had probably forgotten about it anyway.  ;)
True, and I also don't seem to have that anymore...