aMule Forum

English => en_Bugs => Topic started by: gtoso on May 31, 2009, 06:25:19 PM

Title: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on May 31, 2009, 06:25:19 PM
Hi,
on Mac OSX Leopard/Intel I see some visualization defect in SVN r9623 and r9641 (r9602 ok):
kad graph appears for some seconds in Transfers, Networks and Searches.

See here (http://screencast.com/t/cyzyRNkug).

EDIT: Tested with my packages (http://www.amule.org/amule/index.php?topic=13920.0#post_svn).
EDIT2: The same on aMuleGUI.

Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: Stu Redman on May 31, 2009, 07:05:51 PM
Cool recording!

Please try 9642, I've already changed something regarding startup of the OScopeCtrls there. Maybe this takes care of your problem too.
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on May 31, 2009, 09:22:27 PM
Cool recording!

Please try 9642, I've already changed something regarding startup of the OScopeCtrls there. Maybe this takes care of your problem too.

Tried: it fix it only in part:
at the beginning and until I show a graph (kad or statistics) it's ok,
then as before or even worse: statistics tab, then switch to searches tab and statistics graphs appears for few seconds leaving Name field dirty.

EDIT: After show a graph it's exactely as before, I had not tried this before.

Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: Stu Redman on May 31, 2009, 09:46:45 PM
EDIT: After show a graph it's exactely as before, I had not tried this before.
What do you mean with "before" - like in 9623(bad) or like in 9602(ok) ?
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on May 31, 2009, 10:11:05 PM
In summary, no more problems at startup or in Transfers tab.
Problems only in Networks and Searches tabs.
In Networks tab begin only after show Kad graph.

For the detail see this video (http://screencast.com/t/am9UDpip).
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on May 31, 2009, 10:11:49 PM
EDIT: After show a graph it's exactely as before, I had not tried this before.
What do you mean with "before" - like in 9623(bad) or like in 9602(ok) ?

Like in 9623(bad)  :(
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: Stu Redman on May 31, 2009, 10:51:06 PM
Just remove this line (OScopeCtrl.cpp : 292)
Code: [Select]
void COScopeCtrl::OnPaint(wxPaintEvent& WXUNUSED(evt))
{
// m_onPaint = true;
and tell me if it helps. (It should redisable the whole timer logic.)
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on May 31, 2009, 11:34:48 PM
Good, it works fine!!!

What does involve this modify?

Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: Stu Redman on June 01, 2009, 12:12:23 PM
There is a logic in the OScopeCtrl using a timer to prevent permanent rescale and redraw when the window is resized. This logic was broken, and I fixed it. Looks like it has undesirable effects on Mac.

Let's try something else. Does this work too (with the line from above present again) ?
Code: [Select]
Index: OScopeCtrl.cpp
===================================================================
--- OScopeCtrl.cpp (revision 9642)
+++ OScopeCtrl.cpp (working copy)
@@ -527,7 +527,7 @@
  bRecreateGrid |= bInvalidateGrid;
  // To prevent startup problems don't start timer logic until
  // a native OnPaint event has been generated.
- if (m_onPaint) {
+ if (m_onPaint && IsShown()) {
  bRecreateAll  |= bInvalidateGraph && bInvalidateGrid;
  timerRedraw.Start(100, true); // One-shot timer
  }
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on June 01, 2009, 12:17:09 PM
There is a logic in the OScopeCtrl using a timer to prevent permanent rescale and redraw when the window is resized. This logic was broken, and I fixed it. Looks like it has undesirable effects on Mac.

Let's try something else. Does this work too (with the line from above present again) ?

I'm going to try.

Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on June 01, 2009, 01:09:00 PM
Let's try something else. Does this work too (with the line from above present again) ?

No, doesn't work  :(
Same behavior  of 9642 without patch.
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: Stu Redman on June 01, 2009, 01:58:57 PM
OK, fixed in 9645 (disabling timer logic for Mac).
Title: Re: SVN r9623 to last r9641: visualization defect (kad graph)
Post by: gtoso on June 01, 2009, 04:34:19 PM
OK, fixed in 9645 (disabling timer logic for Mac).

Thanks, I hope that soon or later we find a better solution.

I just noticed other problems, that I quite sure there aren't in 9602.
Quickly (I have no time now):
"amuled -f" seems to hang after fork, amulecmd blocks trying to connect to it
"amuled" works
amulecmd doesn't show connection status:
Code: [Select]
aMulecmd$ status
 > Download: 0 bytes/sec
 > Upload: 13 bytes/sec
 > Client in coda: 0
 > Fonti totali: 0
aMulecmd$