aMule Forum

English => en_Bugs => Topic started by: szsuj on January 29, 2010, 03:03:05 AM

Title: A Bug in sourcecode ServerSocket.cpp
Post by: szsuj on January 29, 2010, 03:03:05 AM

In Line 555 , I think it should be " if (size >= 6) { "


551         case OP_CALLBACKREQUESTED: {
            AddDebugLogLineM(false,logServer,wxT("Server: OP_CALLBACKREQUESTED"));
            
            theStats::AddDownOverheadServer(size);
555            if (size == 6) {
               CMemFile data(packet,size);
               uint32 dwIP = data.ReadUInt32();
               uint16 nPort = data.ReadUInt16();

Title: Re: A Bug in sourcecode ServerSocket.cpp
Post by: Kry on January 29, 2010, 07:36:00 AM

You're right, that's a bug in aMule code not present in eMule.  (and it is my fault)

It's been there for a long while, good catch and thanks! (It's been commited to SVN now).

Title: Re: A Bug in sourcecode ServerSocket.cpp
Post by: skolnick on January 30, 2010, 11:16:08 PM

What are the effects of this bug? I guess it's present in aMule 2.2.6, but it works fine for me, so I'm asking...

Thanks!

Title: Re: A Bug in sourcecode ServerSocket.cpp
Post by: Kry on January 31, 2010, 12:41:07 AM

Problems uploading to lowid people.

Title: Re: A Bug in sourcecode ServerSocket.cpp
Post by: Stu Redman on February 05, 2010, 09:37:39 PM

Looks like that fix uncovered another problem (http://forum.amule.org/index.php?topic=17627.0).