aMule Forum

English => aMule crashes => Topic started by: Schuttwegraeumer on September 29, 2010, 06:44:24 AM

Title: crash since R10301
Post by: Schuttwegraeumer on September 29, 2010, 06:44:24 AM

And crash again with 10301

Title: crash since R10301
Post by: Stu Redman on September 29, 2010, 07:27:50 PM

Now that one is totally unrelated to what we had before. And really bad.  :o

Code: [Select]

*** glibc detected *** /home/schutti/Desktop/X/aMule/amule-2.2.6+svn-r10301/src/amuled: malloc(): smallbin double linked list corrupted: 0x00007fffe41c4590 ***
Corrupted list in malloc() - corrupted heap.

Code: [Select]

#15 0x00000000004407ed in CFormat::operator% (this=0x7fffffffc460,
    value=0x73b498 L"Deleted") at ./libs/common/Format.h:126
#16 0x000000000044a3b3 in CUpDownClient::Disconnected (this=0x7fffef605560,
    strReason=..., bFromSocket=false) at BaseClient.cpp:1369
#17 0x00000000005cf9e9 in CUploadQueue::SortGetBestClient (this=0x1616ba0,
    sortonly=true) at UploadQueue.cpp:91
#18 0x00000000005d1996 in CUploadQueue::AddClientToQueue (this=0x1616ba0,
    client=0x7fffe43c16b0) at UploadQueue.cpp:483
Called right from the new UploadQueue code of 10301 . But the CFormat is fine and from 5/2009 (9623):

Code: [Select]

    AddDebugLogLineN(logClient, CFormat(wxT("--- %s client D:%d U:%d \"%s\"; Reason was %s"))
        % (bDelete ? wxT("Deleted") : wxT("Disconnected"))
        % m_nDownloadState % m_nUploadState % GetClientFullInfo() % strReason );
Rather odd chance that a crash with new code in the bt might have an unrelated reason. But I have no idea what could be causing this.  ???

You have built it from a fresh directory?

Title: Re: crash since R10301
Post by: Schuttwegraeumer on September 29, 2010, 10:01:32 PM

Yes, I downloadet the tar, decompressed it, running the configure command as written and than "make".
I startet the programm direkt from the dir i used with gdb.

I will do this again if you need more backtraces.

Title: Re: crash since R10301
Post by: Stu Redman on September 29, 2010, 10:29:26 PM

Please try again to see if you can reproduce it.

Title: Re: crash since R10301
Post by: Schuttwegraeumer on September 30, 2010, 12:08:49 AM

Here the next backtrace(s)

Title: Re: crash since R10301
Post by: Stu Redman on September 30, 2010, 08:31:14 PM

Ok, I think I got the sucker. Sorry for the hassle and thanks for the help.
10302

Code: [Select]

Index: UploadQueue.cpp
===================================================================
--- UploadQueue.cpp    (revision 10301)
+++ UploadQueue.cpp    (working copy)
@@ -112,6 +112,7 @@
                 // swap them
                 *it2 = *it1;
                 *it1 = cur_client;
+                it2--;
             } else {
                 // no need to check further since list is already sorted
                 break;


Title: Re: crash since R10301
Post by: RRM on October 01, 2010, 08:34:54 PM

Stu, you are amazing. (http://www.clicksmilies.com/s1106/aktion/action-smiley-033.gif)

Title: Re: crash since R10301
Post by: Stu Redman on October 01, 2010, 09:49:08 PM

Hey, thanks.  :D
But this here isn't amazing really. Getting it right in the first place would have been better, and fixing it took just some careful thinking through the change of 10301.

Title: Re: crash since R10301
Post by: RRM on October 02, 2010, 06:42:38 PM

Not just this, but all the fixing you do.
Thank you.