Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[gtoso]

Hi,
in today aMule SVN (20080829) on Mac OSX Tiger PPC
if I change the skin from the aMule/aMuleGUI preferences in amule.conf/remote.conf
I found:
Skin=Sistema:gnome.zip
instead of:
Skin=System:gnome.zip

My language is Italian...

EDIT:
My previous version was the 20080803 (used for a short time) so I don't know when the problem began :-(

[skolnick]

I do not understand the issue (I use standard english aMule). Does it work now and not before? or it worked before and not now?

Regards.

[GonoszTopi]

I'll have a look at it.

[kornell]

I found:
Skin=Sistema:gnome.zip
instead of:
Skin=System:gnome.zip

My language is Italian...

I can confirm this issue in aMule SVN 20080825 (amulegui/remote.conf) on Linux.

Regards

[Stu Redman]

GonoszTopi, please review 8717 from 21.6.2008.

[gtoso]

GonoszTopi, please review 8717 from 21.6.2008.

I don't understand: do you intend 21.8?
I confirm that the bug is present in 20080829 and not in 20080803.

EDIT: For info this bug is NOT present in 2.2.2

I can confirm this issue in aMule SVN 20080825 (amulegui/remote.conf) on Linux.

So the introduction of the bug is from 04 to 25 of August.

I do not understand the issue (I use standard english aMule). Does it work now and not before? or it worked before and not now?

My English is not so good 
Try to change language...

super:~ gtoso$ grep Skin Library/Application\ Support/aMule/amule.conf
[SkinGUIOptions]
Skin=System:kde4.zip

Image 1 and 2, then in log:

2008-09-03 18:30:24: La cartella delle skin 'Sistema:kde4.zip' non esiste
2008-09-03 18:30:24: Error: can't open file 'Sistema:kde4.zip' (error 2: No such file or directory)

super:~ gtoso$ grep Skin Library/Application\ Support/aMule/amule.conf
[SkinGUIOptions]
Skin=Sistema:kde4.zip

Image 3 and 4, then:

2008-09-03 18:34:50: Le répertoire de skins 'Système :kde4.zip' n'existe pas
2008-09-03 18:34:50: Error: can't open file 'Système :kde4.zip' (error 2: No such file or directory)

super:~ gtoso$ grep Skin Library/Application\ Support/aMule/amule.conf
[SkinGUIOptions]
Skin=Système :kde4.zip
super:~ gtoso$

[Stu Redman]

GonoszTopi, please review 8717 from 21.6.2008.

I don't understand: do you intend 21.8?

gtoso, are you sure ? My guess is it was introduced at 21.6. :

Code: [Select]

Index: E:/aMule/dev/mytrunk/src/Preferences.cpp
===================================================================
--- E:/aMule/dev/mytrunk/src/Preferences.cpp (revision 8716)
+++ E:/aMule/dev/mytrunk/src/Preferences.cpp (revision 8717)
@@ -811,7 +811,7 @@
  do
  {
  if (skins == true) {
- Filename = wxT("User:") + Filename;
+ Filename = _("User:") + Filename;
  }
  skinSelector->Append(Filename);
  }
@@ -836,7 +836,7 @@
  do
  {
  if (skins == true) {
- Filename = wxT("System:") +  Filename;
+ Filename = _("System:") +  Filename;
  }
  // avoid duplicates for webserver templates
  if (skinSelector->FindString(Filename) == wxNOT_FOUND) {
@@ -847,7 +847,7 @@
  }
 
  if ( skinSelector->GetCount() == 0 ) {
- skinSelector->Append(wxT("no options available"));
+ skinSelector->Append(_("no options available"));
  }
 
  int id = skinSelector->FindString(m_value);
Try reverting the first two changes (turn the _( back to wxT( ) and see if this fixes the problem.

[gtoso]

GonoszTopi, please review 8717 from 21.6.2008.

I don't understand: do you intend 21.8?

gtoso, are you sure ? My guess is it was introduced at 21.6. :

-               Filename = wxT("System:") +  Filename;
+               Filename = _("System:") +  Filename;

Mmm it's seems that you are right!
But I'm sure that 20080803 works fine...
Maybe that the Italian translation was incomplete and so it works...

I'll try to compile next SVN reverting this patch, with the exception of this that seems sensible:
skinSelector->Append(_("no options available"));

[gtoso]

Thanks Sturedman, bug fixed 

SVN 20080904 works fine with this patch:

Code: [Select]

diff -Naur amule-cvs.orig/src/Preferences.cpp amule-cvs/src/Preferences.cpp
--- amule-cvs.orig/src/Preferences.cpp  2008-08-09 22:38:01.000000000 +0200
+++ amule-cvs/src/Preferences.cpp       2008-09-04 03:04:42.000000000 +0200
@@ -836,7 +836,7 @@
                        do
                        {
                                if (m_is_skin) {
-                                       Filename = _("User:") + Filename;
+                                       Filename = wxT("User:") + Filename;
                                }
                                skinSelector->Append(Filename);
                        }
@@ -862,7 +862,7 @@
                        do
                        {
                                if (m_is_skin) {
-                                       Filename = _("System:") +  Filename;
+                                       Filename = wxT("System:") +  Filename;
                                }
                                // avoid duplicates for webserver templates
                                if (skinSelector->FindString(Filename) == wxNOT_FOUND) {


[wuischke]

I'll apply your patch, thanks a lot for the fix to you and Stu!