Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[x_x_kamikaze_x_x]

Hello aMule guys! 

I think I have discovered a little bug in order to manual "ban" people
that are connected to us that have the view of shared files list open.

If you find a guy that had the files view open and you are sending him/her
some files, add it for a friend, and after that try to view him/her list
repeatedly. That person stop asking you files and after a few minutes
disappeared from your uploading queue.

That's is because you can send a lot of requesting messages at he same time
without waiting for the answer (I think), so him/her consider you a dangerous
guy, and leave. 

I think it can be fixed waiting for a answer from the peer, or waiting a prudential time,
that will close the option to make a "manual ban".

aMule SVN compiled with wxGTK2 v2.8.12 (Debugging) (Snapshot: rev. 10620)
Linux maria2 2.6.38-11-server #50-Ubuntu SMP Mon Sep 12 21:34:27 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux

[Kry]

He's banning you, you're not banning him - which is slightly different to a manual ban.

It's true that there should probably be a request limit for shared file requests, and while I believe in the Darwinian approach, maybe someone thinks differently in the Team.

[Stu Redman]

That's is because you can send a lot of requesting messages at he same time
without waiting for the answer (I think), so him/her consider you a dangerous
guy, and leave. 

No. You can't send a file list request before the last request is fulfilled.

I've been digging a bit through the "share shared files" code and noticed that the protocol is (for modern clients like this:
A: request dir list
B: send dir list
A: foreach(dir) request files of dir
B: send files-of-dir lists one after another

I think there is some counter banning clients who send too many requests.
It may very well be that for large dir lists the algorithm triggers the banning code. Or, if not, asking repeatedly might.
How many dirs does that client share? You can see them in the log even before the file lists are requested.

[x_x_kamikaze_x_x]

That's is because you can send a lot of requesting messages at he same time
without waiting for the answer (I think), so him/her consider you a dangerous
guy, and leave. 

No. You can't send a file list request before the last request is fulfilled.

I've been digging a bit through the "share shared files" code and noticed that the protocol is (for modern clients like this:
A: request dir list
B: send dir list
A: foreach(dir) request files of dir
B: send files-of-dir lists one after another

I think there is some counter banning clients who send too many requests.
It may very well be that for large dir lists the algorithm triggers the banning code. Or, if not, asking repeatedly might.
How many dirs does that client share? You can see them in the log even before the file lists are requested.

Not too many, just 4 directories and him didn't have a lot of shared files, around 200.
And please, include the directory column when you ask for a file list request!