aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Some build process bugs  (Read 2202 times)

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Some build process bugs
« on: November 26, 2007, 05:40:33 AM »

Hi!

I've found some bugs in the build process of aMule while building in non-linux platforms (specifically, solaris):

1. autogen.sh uses /bin/sh as interpreter, but in fact it requires bash to work. Since linux symlinks sh to bash, there is no problem there, but almost no UNIX does that so it fails.

2. the script to create the flags (src/pixmaps/flags_xpm/makeflags.sh) assumes the sed used in the machine is GNU sed, but then again, only linux uses it by default. Other platforms install it as gsed, and sed is usually a propietary sed. The solution could be trying to use gsed first, and if it's not in the path, then use sed., or maybe checking some environment variable that the user can set and avoid all these issues ($SED, or something).

3. the test in configure for autpoint makes some strange comparison, which fails (at least on solaris) because the test command is not the GNU one. It's easily fixed by changing the comparison (it tests if a value is different than other. Simply changing it to test for equal values, and inverting the yes/no values in the if/else branches solves the problem).

4. for some reason, the --with-libiconv-prefix=/usr/local and --with-libintl-prefix=/usr/local do not work with aMule, however they work perfectly fine with any other program I've used them (yes, GNU libiconv and GNU gettext are correctly installed under /usr/local)

5. The denoiser scripts also assume that one is using GNU sed. Solution can be the same as the 2nd point.


These tests were made with aMule-CVS-20071112

Thanks for any help on these issues.
« Last Edit: November 26, 2007, 05:51:45 AM by skolnick »
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Some build process bugs
« Reply #1 on: November 26, 2007, 01:08:00 PM »

skolnick,

Could you post some patches?

Cheers!
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: Some build process bugs
« Reply #2 on: November 27, 2007, 05:34:24 AM »

I'll try phoenix, however since I am not completely familiar with the way autotools work, I thought one of the devs could do it :P, because I might end patching an autogenerated file or something. However, I'll do my best to solve these issues and post the patches.

Regards.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Some build process bugs
« Reply #3 on: November 27, 2007, 01:42:42 PM »

Hey be more confident! :D

Post the patch here, we will look at it first, and only apply the ok parts.

Seriously, even a problematic patch is better than nothing and we can discuss it with the real thing at hand.

Cheers!
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Some build process bugs
« Reply #4 on: December 21, 2007, 05:37:03 PM »

Hi skolnick!

I tried to make the denoiser scripts as portable as possible with all the information I had at hand. If you could point out what is non-portable, or point me to a documentation to the (non-GNU) sed you're using, I'd do my best to improve it.

Thx
Logged
concordia cum veritate