aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Fake & Search  (Read 3886 times)

ShakaZ

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Fake & Search
« on: August 12, 2005, 02:40:51 AM »

Hello all,

several months ago i switched to aMule on Kanotix.
Although some things were less shiny than on advanced eMule mods, i sticked to it for a couple of reasons; aMule requires less cpu, is very solid &, with the help of linux,  handles the connections more efficiently resulting in higher throughput & lower impact on other network activities  8)

Still there's one feature that is desperately missing : reporting known fakes in the search results. I know  it's already possible to check files individually, but eliminating the fakes  from the start has many advantages : less bandwidth spilled, less time wasted to check each file,    blocks propagation of known fakes much more efficiently.

I don't recall exactly wich mod(s) had integrated that feature but it should be in this list:

MorpXT,  Neomule, LSD
Logged

gdhsk

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
Yea, yeeppy, for less fakes
« Reply #1 on: August 12, 2005, 02:45:42 AM »

That is a great feature.  Someone Please get on it and save the world of bandwidth.

Thanks.  :baby:  :]  :D
Logged

schtroumpf

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 7
RE: Yea, yeeppy, for less fakes
« Reply #2 on: August 20, 2005, 09:13:28 PM »

Edonkey servers store now the rating in their databases. you can send your rating and retrieve a rating when you are searching files. I am trying to develop this feature but don't exept anything I am a newB and this is my first hack in a open source software... We'll see.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Fake & Search
« Reply #3 on: August 20, 2005, 09:26:23 PM »

I can do it farily easily (I -have lugdunum's specs on it), but if you want to do it, go ahead.
Logged

schtroumpf

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 7
Re: Fake & Search
« Reply #4 on: August 21, 2005, 01:42:13 PM »

Yeah you are right I have implemented the protocol part and it is was not so difficult. I have now to think how to display it. By the way Why amule display only to state bad or good in the download list (instead of the 5 states) ? Is there an important reason or I can change it like in emule ?
Logged

ShakaZ

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Re: Fake & Search
« Reply #5 on: August 23, 2005, 07:33:41 PM »

Great to see you guys are interested & progressing fast  :baby:.
Looking forward to using it & hope it'll be integrated to aMule soon  :D
Logged

schtroumpf

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 7
Re: Fake & Search
« Reply #6 on: September 01, 2005, 08:42:18 PM »

I've done it !
- I have replaced the ugly numbers used in clientImage by the skin constants.
-  I have replaced the current filerating good/bad by a rating average like in emule
- I have created ugly file file rating icons.
- amule submit rating file to the server
- the icon of file rating appear like in the download dialog. I think it's better than a simple column because the user can identify very quickly fake and good file.

I hope I have done it in the right way.
Logged

stefanero

  • Some Support
  • Developer
  • Hero Member
  • *****
  • Karma: 8
  • Offline Offline
  • Posts: 4235
Re: Fake & Search
« Reply #7 on: September 01, 2005, 09:24:28 PM »

nice patch I try it right now,

can you repost that in the development forum so it does not get lost, and maybe reviewed by Kry or Xaignar

thnx
stefanero
Logged
In its default setup, Windows XP on the Internet amounts to a car
parked in a bad part of town, with the doors unlocked, the key in
the ignition and a Post-It note on the dashboard saying, "Please
don't steal this."

ShakaZ

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Re: Fake & Search
« Reply #8 on: October 13, 2005, 01:49:14 PM »

Great job Schtroumf  :P

Any news if it is /when it will be integrated in Amule??
If not please give some info on how to use the diff file...
« Last Edit: October 13, 2005, 01:49:35 PM by ShakaZ »
Logged