aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Is share ratio correct?  (Read 2387 times)

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Is share ratio correct?
« on: February 25, 2007, 01:14:48 AM »
Hi everybody!

I just noticed that share ratio for files (in shared files tab) seems to be calculated as "uploaded file bytes/total file bytes". Shouldn't be a "more correct" way to calculate it as "uploaded file bytes/downloaded file bytes"? I mean, if I have downloaded only one piece of a file with 100 pieces, and I have uploaded that piece 20 times, my share ratio would be only 0.2, which seems pretty low. However, I've uploaded 20 times the only part I got, so...just consider it and tell me what you think :)

Edit: Sorry, i think this thread should be more in "feature requests" than in "english bugs". I would move it, but I cannot do that. Kry, could you please give me mod permissions again? :)
Edit2: Thanks Kry! (or whomever changed me back to mod) :)

Thanks!
« Last Edit: February 25, 2007, 01:50:22 AM by skolnick »
Logged

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Is share ratio correct?
« Reply #1 on: March 12, 2007, 11:49:10 PM »
Since I am the one who implemented the Share Ratio display, let me offer you my perspective on this issue.

As I see it, there are two main purposes of this feature:
(a) to quickly identify all files that you've uploaded for instance 4 times, so you can unshare them (to do this you can simply sort by share ratio)
(b) to easily keep track of how much you have uploaded your own releases

For both of these functions, the "upload / file size" formular is much better suited than the "upload / download" one is. For (a) you really don't want those "downloaded one chunk and uploaded that chunk 5 times" files to be listed among the completed files that have been uploaded sufficiently, when you sort by share ratio. For (b) it's even more obvious, because your own releases will all have a download of 0 and therefore an infinite share ratio. Yes, for those files you could actually use the file size then instead of the amount downloaded, but I think using two different formulas would be a bad idea.

So in short:
It's a not a bug, it's a feature! ;)
Logged
Current aMule CVS builds for OS X can be found here.

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: Is share ratio correct?
« Reply #2 on: March 15, 2007, 07:10:35 AM »
Hi!

Thanks for taking the time to reply. What I see in regard to your points is:
a) I've had files uploaded more than 4 times according to current share ratio, yet they are not complete (it does not help identify which files to remove or not)
b) My releases can be tracked by using my formula (maybe I just explained it wrongly, it should not be uploaded/downloaded, maybe uploaded/completed is better). That way, the ratio would be the same for complete files with any formula.

However, seeing your points, I see your formula is useful too. I think I'll have to learn C++ and maybe add my column to aMule :P

Regards.
Logged