aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Poll

What language should aMule use?

American English
- 1 (12.5%)
British English
- 7 (87.5%)
I don't care
- 0 (0%)

Total Members Voted: 7


Author Topic: [consistency] Canceled OR Cancelled  (Read 2754 times)

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
[consistency] Canceled OR Cancelled
« on: January 06, 2010, 07:57:37 PM »

Dear developers,

I have noticed that both of the words "canceled" (American English) and "cancelled" (British English) are used in the original message strings.
Code: [Select]
#: src/HTTPDownload.cpp:108
msgid "HTTP download cancelled"
msgstr ""

#: src/utils/aLinkCreator/src/alcframe.cpp:574
#: src/utils/aLinkCreator/src/alcframe.cpp:575
#: src/utils/aLinkCreator/src/md4.cpp:359
msgid "Cancelled !"
msgstr ""
versus
Code: [Select]
#: src/CanceledFileList.cpp:61
msgid "WARNING: Canceled file list corrupted, contains invalid header."
msgstr ""

#: src/SearchListCtrl.cpp:945
msgid "Canceled"
msgstr ""
My opinion is that it should be consistent and therefore should be changed to only use one of the two. My suggestion is to use "cancelled".
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
Re: [consistency] Canceled OR Cancelled
« Reply #1 on: January 06, 2010, 10:51:06 PM »

Let's not turn this into a mud-bath of English vs American, bloke. (If you kinda feel "huh?" at that phrase and like me find "guy" more natural you should also favor "canceled".)
Anyway, I've just committed a largish change that is crawling with "canceled" (file names, classes, methods, variables...) and I would therefore very much prefer this version. We can always make a second English translation for American English, now that we found an example of difference in our actual texts.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4319
Re: [consistency] Canceled OR Cancelled
« Reply #2 on: January 06, 2010, 11:15:23 PM »

I believe we used to have an en_GB translation, which indicates that aMule was originally written in American English. If there was a vote, I'm in favour of British English.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2675
Re: [consistency] Canceled OR Cancelled
« Reply #3 on: January 07, 2010, 01:15:31 PM »

I believe we used to have an en_GB translation, which indicates that aMule was originally written in American English.
You might be right, but lately we only used that file to last-minute fix Engrish texts. Consisteny would indeed be a Good Thing(TM), and we can always have the other variant as a .po translation.

If there was a vote, I'm in favour of British English.
Now you can vote ;)
Logged
concordia cum veritate