aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 2 3 [4] 5

Author Topic: Traditional Chinese translation for 2.2.0  (Read 42785 times)

mstar

  • Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 21
Re: Traditional Chinese translation for 2.2.0
« Reply #45 on: May 10, 2010, 05:54:50 PM »

Updated.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2674
Re: Traditional Chinese translation for 2.2.0
« Reply #46 on: May 14, 2010, 03:00:53 PM »

Committed, thank you.

(Where's wuischke?)
Logged
concordia cum veritate

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
Re: Traditional Chinese translation for 2.2.0
« Reply #47 on: May 31, 2010, 04:09:21 PM »

There's a problem in handling of the Chinese language. Look at the source of wxWidgets:
Code: [Select]
   LNG(wxLANGUAGE_CHINESE,                    "zh_TW", LANG_CHINESE   , SUBLANG_DEFAULT                   , wxLayout_LeftToRight, "Chinese")
   LNG(wxLANGUAGE_CHINESE_SIMPLIFIED,         "zh_CN", LANG_CHINESE   , SUBLANG_CHINESE_SIMPLIFIED        , wxLayout_LeftToRight, "Chinese (Simplified)")
   LNG(wxLANGUAGE_CHINESE_TRADITIONAL,        "zh_TW", LANG_CHINESE   , SUBLANG_CHINESE_TRADITIONAL       , wxLayout_LeftToRight, "Chinese (Traditional)")
   LNG(wxLANGUAGE_CHINESE_HONGKONG,           "zh_HK", LANG_CHINESE   , SUBLANG_CHINESE_HONGKONG          , wxLayout_LeftToRight, "Chinese (Hongkong)")
   LNG(wxLANGUAGE_CHINESE_MACAU,              "zh_MO", LANG_CHINESE   , SUBLANG_CHINESE_MACAU             , wxLayout_LeftToRight, "Chinese (Macau)")
   LNG(wxLANGUAGE_CHINESE_SINGAPORE,          "zh_SG", LANG_CHINESE   , SUBLANG_CHINESE_SINGAPORE         , wxLayout_LeftToRight, "Chinese (Singapore)")
   LNG(wxLANGUAGE_CHINESE_TAIWAN,             "zh_TW", LANG_CHINESE   , SUBLANG_CHINESE_TRADITIONAL       , wxLayout_LeftToRight, "Chinese (Taiwan)")
and of aMule:
Code: [Select]
{ wxLANGUAGE_CHINESE_SIMPLIFIED, false, wxEmptyString, wxTRANSLATE("Chinese (Simplified)") },
{ wxLANGUAGE_CHINESE_TRADITIONAL, false, wxEmptyString, wxTRANSLATE("Chinese (Traditional)") },
What we call "Chinese (Traditional)" is stored in the prefs as "zh_TW", and "zh_TW" gets transformed to wxLANGUAGE_CHINESE instead of wxLANGUAGE_CHINESE_TRADITIONAL by wxLocale::FindLanguageInfo. So if you select "Chinese (Traditional)" it is not selected in the control later.

Is it a problem if I just change "Chinese (Traditional)" / wxLANGUAGE_CHINESE_TRADITIONAL to "Chinese" / wxLANGUAGE_CHINESE ?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2674
Re: Traditional Chinese translation for 2.2.0
« Reply #48 on: June 01, 2010, 11:27:08 AM »

I'd change StrLang2wx() to return wxLANGUAGE_CHINESE_TRADITIONAL instead of wxLANGUAGE_CHINESE.
Logged
concordia cum veritate

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
Re: Traditional Chinese translation for 2.2.0
« Reply #49 on: June 01, 2010, 12:28:14 PM »

I'd change StrLang2wx() to return wxLANGUAGE_CHINESE_TRADITIONAL instead of wxLANGUAGE_CHINESE.
You mean
Code: [Select]
if (ret == wxLANGUAGE_CHINESE) ret = wxLANGUAGE_CHINESE_TRADITIONAL;?
I don't like that much.  :-\
I've pmed mstar, maybe he can give us some background info. That business about "traditional" and "Taiwan" and such might be sensitive to some of the Chinese guys.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

mstar

  • Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 21
Re: Traditional Chinese translation for 2.2.0
« Reply #50 on: June 06, 2010, 09:54:38 AM »

I'd change StrLang2wx() to return wxLANGUAGE_CHINESE_TRADITIONAL instead of wxLANGUAGE_CHINESE.
You mean
Code: [Select]
if (ret == wxLANGUAGE_CHINESE) ret = wxLANGUAGE_CHINESE_TRADITIONAL;?
I don't like that much.  :-\
I've pmed mstar, maybe he can give us some background info. That business about "traditional" and "Taiwan" and such might be sensitive to some of the Chinese guys.

Traditional Chinese: original Chinese, used in Taiwan, Hong Kong and Macau.
Simplified Chinese: simplified Chinese characters used in Mainland China since 1950s, and in some other places such as Singapore and Malaysia.

so,
Chinese (Traditional) contains zh_TW, zh_HK and zh_MO (but there are differences in some words). Because of most Traditional Chinese user are in Taiwan, zh_TW becomes the representation of Traditional Chinese.
Chinese (Simplified) contains zh_CN, zh_SG and zh_MY. In the same reason, zh_CN becomes the representation of Simplified Chinese.

« Last Edit: June 06, 2010, 10:00:35 AM by mstar »
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
Re: Traditional Chinese translation for 2.2.0
« Reply #51 on: June 06, 2010, 12:26:46 PM »

I'd change StrLang2wx() to return wxLANGUAGE_CHINESE_TRADITIONAL instead of wxLANGUAGE_CHINESE.
I can see now you're right. Fixed in 10213.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2674
Re: Traditional Chinese translation for 2.2.0
« Reply #52 on: June 06, 2010, 08:56:00 PM »

I can see now you're right.
As always  ::)
Logged
concordia cum veritate

mstar

  • Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 21
Re: Traditional Chinese translation for 2.2.0
« Reply #53 on: July 06, 2010, 11:06:51 AM »

Updated.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2674
Re: Traditional Chinese translation for 2.2.0
« Reply #54 on: July 06, 2010, 12:50:19 PM »

I'm sorry to say it doesn't work:

Code: [Select]
zh_TW.po:1761: number of format specifications in 'msgid' and 'msgstr' does not match
/usr/bin/msgfmt: found 1 fatal error

The corresponding strings:
Code: [Select]
#: src/ExternalConn.cpp:519
#, c-format
msgid "Unauthorized access attempt from %s. Connection closed."
msgstr "發現試圖非法登入,已關閉連線。"

Please fix it.
Logged
concordia cum veritate

mstar

  • Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 21
Re: Traditional Chinese translation for 2.2.0
« Reply #55 on: July 06, 2010, 02:33:48 PM »

I'm sorry to say it doesn't work:

The corresponding strings:
Code: [Select]
#: src/ExternalConn.cpp:519
#, c-format
msgid "Unauthorized access attempt from %s. Connection closed."
msgstr "發現試圖非法登入,已關閉連線。"

Please fix it.

Sorry, it's fixed.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2674
Re: Traditional Chinese translation for 2.2.0
« Reply #56 on: July 06, 2010, 05:45:18 PM »

Thank you for reacting so fast, your translation is now committed.
Logged
concordia cum veritate

mstar

  • Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 21
Re: Traditional Chinese translation for 2.2.0
« Reply #57 on: September 04, 2010, 05:39:05 PM »

Updated.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2674
Re: Traditional Chinese translation for 2.2.0
« Reply #58 on: September 04, 2010, 09:52:06 PM »

You're the first to have it 100% ready for September. Thanks, committed.
Logged
concordia cum veritate

mstar

  • Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 21
Re: Traditional Chinese translation for 2.2.x
« Reply #59 on: February 22, 2011, 10:09:07 AM »

Updated.
Logged
Pages: 1 2 3 [4] 5