aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Use "best sources" when they're limited!  (Read 2910 times)

Treviño

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 50
    • http://italy.copybase.ch/blog/
Use "best sources" when they're limited!
« on: October 09, 2007, 04:11:07 PM »

Hello, by default aMule (like emule does), limits the maxmum sources to contact to 300, this is a good thing for the network healt, but not always it implies good performances...

So I was thinking that maybe the mule should use another behavior to select sources to use:

If there are more than <max-contacted-clients-number> are found, start contacting them all (well a limit should be but, but higher I think!)...
After you know its QueueRate and its CompletedState amule should start purging the worst sources (too high QR, few chunks available...), selecting then only the "best <max-contacted-clients-number> clients" from a CompletedChunks/QueuRatio ratio...

In this way, you'll get always only the first 300 sources, instead of the first found ones...

Btw, I'm starting thinking that maybe this behavior could be too much load for the network, or simply for the client that is doing this comparison...

What do you think about?

Archmage

  • Full Member
  • ***
  • Karma: 5
  • Offline Offline
  • Posts: 119
Re: Use "best sources" when they're limited!
« Reply #1 on: October 10, 2007, 12:05:58 PM »

I think that aMule simply should only connect to 300 sources, but drop the "no source" and "high QR" from time to time and fill it with new sources.

I demand this is impementet RIGHT NOW!

*Wait one second*

It should now be in the stable and in the CVS. No need to download a new file. I did also change every stable and CVS version worldwide to implement this.
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4319
Re: Use "best sources" when they're limited!
« Reply #2 on: October 10, 2007, 05:10:05 PM »

Quote
I did also change every stable and CVS version worldwide to implement this.
*beep*

Source dropping is being disabled for a couple of days already and will be removed.

To explain the Why? briefly: Dropped sources are usually found very soon again and results in a higher overhead than for sources which have not been dropped. There are afaik a couple of eMule mods which keep a list of dropped sources and won't reask them if found again, but this might be negative behaviour if the source has indeed changed its status.
Logged