aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 [2]

Author Topic: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly  (Read 15142 times)

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #15 on: November 28, 2007, 08:41:46 AM »

aMule finds the translations only if they are installed. In addition, you have to have the locale for the translation to be generated or you wouldn't have much fun with it.

As wuischke already said, you have to do a make install to get it to work. Beside that the locale you want to use has to be generated, say it is in the list of "locale -a". Beside that you need the amule.mo for the locale (should be installed, I'm just working on a possibillity to choose which to generate and install). If this is done, open the prefs, choose the lang, restart and it should work.
Logged
Homefucking is killing prostitution

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #16 on: November 28, 2007, 11:41:27 AM »

Quote from: wuischke
as far as I know, wx will assume /usr/local as prefix as long as the binary is not installed to /usr, even if it is in my compile path $HOME/devel/amule-dev/src and the Makefiles set a prefix of /usr. I ran into similar problems with skin support and I think this was what happened.
The strange thing is that it works when I "make install" with a crazy prefix, I used "/home/myuser/usr/local/amule".

Quote from: Vollstrecker
As wuischke already said, you have to do a make install to get it to work. Beside that the locale you want to use has to be generated, say it is in the list of "locale -a". Beside that you need the amule.mo for the locale (should be installed, I'm just working on a possibillity to choose which to generate and install). If this is done, open the prefs, choose the lang, restart and it should work.
You are missing my point, I have it working now, what I want to know is _how_ it is done. Why do I need "make install" to make it work, even if I install it in such an odd path as I did.

Cheers!
« Last Edit: November 28, 2007, 11:44:00 AM by phoenix »
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #17 on: November 28, 2007, 11:54:37 AM »

Just a guess, but at compiletime you choose the path where it is installed and with that the path where it should look for his files. If you don't install, the files are not where it expects them. It seems that in this case a fallback to /usr/local happens. It doesn't matter where you install, installed is installed and all files are in place.
Logged
Homefucking is killing prostitution

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #18 on: November 28, 2007, 01:42:23 PM »

Yeah, you are probably right, configure is passing some information to wxWidgets then.

Thanks!
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #19 on: November 28, 2007, 02:22:18 PM »

I don't think the already compiled wxWidgets get's modified by amule's configure. Is is more like "searchpath=<something_from_configure_call>/amule" in the sourcecode.
Logged
Homefucking is killing prostitution

ycjhi

  • Approved Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 13
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #20 on: November 29, 2007, 12:52:39 AM »


Quote from: ycjhi
Do you convert encodings before storing downloaded file to local file system? I'm concerning because Mac OS uses filenames in UTF-8 encoding for local file system. I don't know what other operating systems use though.

This is the problem. If we use a conversion that uses the default system conversion, and this default is not UTF-8, say ISO-8859-1, it will fail on characters that are not from this charset. And all the network filename traffic is in UNICODE, so if the file system is not UNICODE or UTF-8, the conversion will sometimes fail. We currently try to do the best job, first we try to convert UNICODE to ISO-8859-1. If this fails, then we convert it to UTF-8, which should never fail.

The right solution, in my opinion, would be to use UTF-8 always, even though non-UNICODE systems would display the name incorrectly.


What about letting users to set an option such as "Local filesystem name encoding" in aMule configuration dialog box?
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #21 on: November 29, 2007, 02:17:11 AM »

ycjhi,

This solution has the same "short blanket" effect too.

Imagine that the user sets the local file system character set to ISO-8859-1. Then we have exactly the same problem we have today. The user may be downloading files that cannot be saved in its file system encoding.

Cheers!
Logged

ycjhi

  • Approved Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 13
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #22 on: November 29, 2007, 07:18:49 AM »

ycjhi,

This solution has the same "short blanket" effect too.

Imagine that the user sets the local file system character set to ISO-8859-1. Then we have exactly the same problem we have today. The user may be downloading files that cannot be saved in its file system encoding.

Cheers!

That was a stupid question. I should have read your post carefully. Sorry   :-[
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: bug: OSX: aMule-cvs-20071126 doesn't support unicode filenames correctly
« Reply #23 on: November 29, 2007, 12:31:27 PM »

Hey, nevermind! Your doubt is also someone else's doubt (if not my doubt :D ) The debate is good.

Cheers!
Logged
Pages: 1 [2]