aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 [2] 3 4

Author Topic: Erroneous  (Read 23075 times)

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: Erroneous
« Reply #15 on: June 21, 2008, 03:56:31 PM »

Try
Code: [Select]
$ sudo tune2fs -l /dev/YOUR_PARTITION
tune2fs 1.40.8 (13-Mar-2008)
Filesystem volume name:   <none>
Last mounted on:          <not available>
Filesystem UUID:          f500dddc-5c6f-41f8-9eb4-5bd81516df13
Filesystem magic number:  0xEF53
Filesystem revision #:    1 (dynamic)
Filesystem features:      has_journal ext_attr resize_inode dir_index filetype needs_recovery sparse_super large_file
and see if the sparse_super flag is present. If not, turn it on and run a fsck.
Also check if there are reserved blocks - on a data partition there shouldn't be any.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

chemical

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 62
Re: Erroneous
« Reply #16 on: June 21, 2008, 04:00:45 PM »

Code: [Select]
prime:~ # tune2fs -l /dev/hdg1
tune2fs 1.40.5 (27-Jan-2008)
Filesystem volume name:   <none>
Last mounted on:          <not available>
Filesystem UUID:          14a96ea1-f0c0-4f91-aeae-4e87a78bd969
Filesystem magic number:  0xEF53
Filesystem revision #:    1 (dynamic)
Filesystem features:      has_journal filetype needs_recovery sparse_super large_file
Default mount options:    (none)
Filesystem state:         clean
Errors behavior:          Continue
Filesystem OS type:       Linux
Inode count:              4889248
Block count:              9770669
Reserved block count:     0
Free blocks:              2619994
Free inodes:              4888527
First block:              0
Block size:               4096
Fragment size:            4096
Blocks per group:         32768
Fragments per group:      32768
Inodes per group:         16352
Inode blocks per group:   511
Filesystem created:       Thu Feb  5 21:22:46 2004
Last mount time:          Thu May 15 17:36:05 2008
Last write time:          Thu May 15 17:36:05 2008
Mount count:              1
Maximum mount count:      25
Last checked:             Thu May 15 17:33:47 2008
Check interval:           15552000 (6 months)
Next check after:         Tue Nov 11 16:33:47 2008
Reserved blocks uid:      0 (user root)
Reserved blocks gid:      0 (group root)
First inode:              11
Inode size:               128
Journal inode:            8
Default directory hash:   tea
Directory Hash Seed:      e5c2e1b8-ba5d-4041-a532-99357b9fe2b4
Journal backup:           inode blocks

Everything worked fine until SVN 2008-01-01 - wuischke mentioned there were changes in the I/O system.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: Erroneous
« Reply #17 on: June 21, 2008, 04:14:52 PM »

Wuischke, what changes were you referring to ?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4319
Re: Erroneous
« Reply #18 on: June 21, 2008, 04:58:26 PM »

Stu, particularly 7848, but it might have been something which was added with MSVC compatibility.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: Erroneous
« Reply #19 on: June 22, 2008, 03:48:35 PM »

LOL, I think I have found it.
Your free disk space is 10. The UI says that's 10 MB, but I can't find the piece of code where the 10 becomes 10 MB. I'm afraid aMule actually checks if there are 10 bytes left.  :o Or where am I wrong ?
The erroneous state comes definitely from the change Wuischke mentioned, but the real problem is the failure of the free disk space check.

If someone agrees on my finding I can provide a patch.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

chemical

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 62
Re: Erroneous
« Reply #20 on: June 22, 2008, 04:22:32 PM »

Sounds interesting. Do you find that piece of code in a 2007-12-01 SVN?

I have a backup amule.conf dated 2007-11-18, and there its:

Code: [Select]
CheckDiskspace=1
MinFreeDiskSpace=20

.. and it worked ever since.
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4319
Re: Erroneous
« Reply #21 on: June 22, 2008, 04:44:30 PM »

No, this can't happen, because there's a check beforehand which will test for free < PARTSIZE and partsize is 9728000. So it will at least check for full part size.

The check is however actually using bytes as you say and should be fixed, Please have a look at it.
Logged

chemical

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 62
Re: Erroneous
« Reply #22 on: June 22, 2008, 04:50:34 PM »

Ah, I see. This fits perfectly into my thoughts .. now as I read it. There was a time back then I wondered because amuled ignored my setting of "20 MB" and still stopped at ~10MB (which was the setting before I moved to 20).

If the diskspace will never fall below 9,7M - regardless of the setting, then this will explain the behaviour.

I'll check with the SVN revision from tomorrow and report back.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: Erroneous
« Reply #23 on: June 22, 2008, 08:14:40 PM »

OK. Here is the working free disk space. I also bumped it to 64bit, so you can leave 10000 MB free.  :D
Also there is the muuli patch to make it compile under Windows again.

Chemical, the free disk check has been broken for a longer time probably. The January change just made a disk overflow more serious than before. Please set the (now working) free disk space to something larger (50-100MB, if you have the space), and look at what actual free space it stops next time. It seems that the built-in 9MB are not enough.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5822
Re: Erroneous
« Reply #24 on: June 22, 2008, 08:34:34 PM »

Up.
Logged

chemical

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 62
Re: Erroneous
« Reply #25 on: June 28, 2008, 11:35:36 AM »

I took 2008-06-23, verified that the patches are in, compiled and started.

Today my disk ran full again. Half of the files are status "Insufficient diskspace", the other half is "Erroneous".

CheckDiskspace=1
MinFreeDiskSpace=10

I'll change it to 30 and wait again, to be sure the limit is honored. Right now I'm not sure whether this is the emergency brake by the check with PARTSIZE.
Logged

chemical

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 62
Re: Erroneous
« Reply #26 on: June 28, 2008, 05:57:01 PM »

After changing MinFreeDiskSpace to 30, it seem to work nicely now.

Is 10 the default? If so, it should be changed. With 10, there are sometimes files set to Erroneous if the disk space runs full (too close on PARTSIZE).
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: Erroneous
« Reply #27 on: June 29, 2008, 12:28:36 AM »

There is a minimum free space of 9.5 MB (one part) which is obviously too little.

I'd suggest to raise the hard-coded limit to 30MB, and to remove the "check free disc space" selection option alltogether (just leave the space setting, which then doesn't go below 30). Why should anybody turn it off ?

Mind, free disc space checking only works with sparse files. Anybody have an idea how to check if a file system supports sparse ? My best idea would be to check free space before and after writing data near the end of a new download (when non-sparse really eats up space).
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5822
Re: Erroneous
« Reply #28 on: June 29, 2008, 01:04:14 AM »

[...]and to remove the "check free disc space" selection option alltogether (just leave the space setting, which then doesn't go below 30). Why should anybody turn it off ?

That's very much not out policy about giving people options.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: Erroneous
« Reply #29 on: June 29, 2008, 12:49:29 PM »

You mean, everbody should have the option to let his disk run full and get strange side effects ? If so - why reserve 9MB in the first place ?
Mind, I also prefer to have everything configurable - I'm not one of the "clean up the cluttered option dialog so that it fits on my mac screen" guys. Just give me one reason why it could make sense not to check free disc space.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon
Pages: 1 [2] 3 4