Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[xplode_me]

Currently it's not possible to "copy  feedback to clipboard" of shared files, only of active transfers. Is this a bug, or isn't it implemented yet?

thanks

[myth]

Code: [Select]

void CSharedFilesCtrl::OnGetFeedback(wxCommandEvent& WXUNUSED(event))
{
wxString feed;
long index = GetNextItem(-1, wxLIST_NEXT_ALL, wxLIST_STATE_SELECTED);
while (index != -1) {
CKnownFile* file = (CKnownFile*)GetItemData(index);

Here?==> if (file->IsPartFile()) {
Here?==> feed += dynamic_cast<CPartFile*>(file)->GetFeedback();
   }

index = GetNextItem(index, wxLIST_NEXT_ALL, wxLIST_STATE_SELECTED);
}
if (!feed.IsEmpty()) {
theApp->CopyTextToClipboard(feed);
}
}


[GonoszTopi]

I'll take a look.

[myth]

Thank you very much! 

[GonoszTopi]

Feedback from shared files is now possible.

[myth]

Don't misunderstand me, but i love you!

Great work!!!

THX very much!

[myth]

hmm...here is a problem....i want to copy feedback of an complete file, and look what comes out:

Code: [Select]

Feedback from: [DCON] MyTh [X-T HD] (aMule SVN using wxGTK2 v2.8.7 (Snapshot: Wed Apr 30 07:01:48 CEST 2008))

File name: Der.Ausbruch.des.St.Helens.for.maultier-power.com.avi
File size: 347.26 MB
Downloaded: Complete
Complete Sources: 38

For else other file it copy's everything good like this:

Code: [Select]

Feedback from: [DCON] MyTh [X-T HD] (aMule SVN using wxGTK2 v2.8.7 (Snapshot: Wed Apr 30 07:01:48 CEST 2008))

File name: xyz.pdf
File size: 190 kB
Share ratio: 400.00%
Transferred: 0 bytes (760 kB)
Requested: 0 (5)
Accepted: 0 (4)
Complete Sources: 0


Now i tried to rename the file, aMule must rehash it, and Saved data about total uploaded isn't anymore present...
But without points in filename Copy Feedback works....

Code: [Select]

Feedback from: [DCON] MyTh [X-T HD] (aMule SVN using wxGTK2 v2.8.7 (Snapshot: Wed Apr 30 07:01:48 CEST 2008))

File name: Der Ausbruch des St Helens for maultier-power.avi
File size: 347.26 MB
Share ratio: 0.00%
Transferred: 0 bytes (0 bytes)
Requested: 1 (1)
Accepted: 0 (0)
Complete Sources: 39

[GonoszTopi]

Thanks for the report, I'll check it.

[GonoszTopi]

Fixed.

[myth]

Thank you! 

[xplode_me]

Thanks alot

[myth]

Hi....maybe i'm a bit freaky with feedback report...

But i added another nice thing to feedback...

Code: [Select]

Feedback from: [b]MY_NICK_NAME (aMule 2.2.2 using wxGTK2 v2.8.7)[/b]
File name: fudshfsda.xyz
File size: 4.69 GB
Share ratio: 50.39%
Uploaded: 11.33 MB ([b]2.36 GB[/b])
Requested: 41 (561)
Accepted: 2 (258)
On Queue: 41
Complete sources: [b]10[/b]
...to see how many ppl are asking this file...

The [ b ][ /b ] code is just for forums to make it easier to find much relevant informations....

And i deleted the free line after "Feedback from: .... " ...because i don't like it

If you want to change it in sources here's the change:

In KnownFile.cpp:

Code: [Select]

wxString CKnownFile::GetFeedback() const
{
return   wxString(_("File name")) + wxT(": ") + GetFileName().GetPrintable() + wxT("\n")
+ _("File size") + wxT(": ") + CastItoXBytes(GetFileSize()) + wxT("\n")
+ _("Share ratio") + wxString::Format(wxT(": %.2f%%\n"), (((double)statistic.GetAllTimeTransferred() / (double)GetFileSize()) * 100.0))
+ _("Uploaded") + wxT(": ") + CastItoXBytes(statistic.GetTransferred()) + wxT(" ([b]") + CastItoXBytes(statistic.GetAllTimeTransferred()) + wxT("[/b])\n")
+ _("Requested") + CFormat(wxT(": %u (%u)\n")) % statistic.GetRequests() % statistic.GetAllTimeRequests()
+ _("Accepted") + CFormat(wxT(": %u (%u)\n")) % statistic.GetAccepts() % statistic.GetAllTimeAccepts()
+ _("On Queue") + CFormat(wxT(": %u\n")) % GetQueuedCount() //<-- this one!
+ _("Complete sources") + CFormat(wxT(": [b]%u[/b]\n")) % m_nCompleteSourcesCount;
}

[phoenix]

Committed, appart from the [ b ]'s.

Cheers!

[myth]

Thank you!