aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: alc and alcc will not work with files bigger than 4GB  (Read 4037 times)

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1189
  • CentOS 6 User
alc and alcc will not work with files bigger than 4GB
« on: September 27, 2007, 06:40:06 PM »

I am using CVS version from Sept 18 2007, and its alc and alcc utilities will not create the ed2k link for a file bigger than 4GB. It explicitly says that aMule network does not allow files bigger than 4GB.

Thanks!

edit:
I fixed this issue by doing the following:

1. In file ed2khash.cpp I removed these lines:
Code: [Select]
  else if (file.Length() > (size_t)-1)
    {
      wxLogError (_("The file %s is to big for the Donkey: maximum allowed is 4 GB."),
                  unicode2char(filename.GetFullPath()));
      return (false);
    }
which were around line 85 of the file

2. in the file ed2khash.cpp I also changed line 225 from:
Code: [Select]
                      +wxT("|")+ wxString::Format(wxT("%u"),m_fileSize) +wxT("|")to
Code: [Select]
                      +wxT("|")+ wxString::Format(wxT("%llu"),m_fileSize) +wxT("|")
3. in the file ed2khash.h I changed the type of m_fileSize from size_t to long long int

But there is one issue remaining: the progressbar while hashing, will get to some part, when it has hashed about 4GB of the file, and then restarts from 0. The resulting link is OK, however.

Regards.
« Last Edit: September 27, 2007, 07:21:14 PM by skolnick »
Logged

Nil Einne

  • Approved Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 16
Re: alc and alcc will not work with files bigger than 4GB
« Reply #1 on: September 08, 2008, 09:55:16 AM »

Seems that 2.2.2 on Windows at least still hasn't incorporated this change since still doesn't work with 4GB files, any plans to add it? Don't know enough to try it myself

Also what about adding <s>kad</s>AICH support?

Edit: I meant AICH support not kad support. Don't know what I was thinking when I wrote that...

« Last Edit: September 29, 2008, 02:26:04 AM by Nil Einne »
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4319
Re: alc and alcc will not work with files bigger than 4GB
« Reply #2 on: September 08, 2008, 11:46:04 AM »

I've committed Skolnick's fix, thanks a lot. I couldn't solve the progress bar problem and as it strangely refused to give me any output from printf or std::cout/cerr, I decided to continue working and leave it be...
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 166
  • Offline Offline
  • Posts: 2683
Re: alc and alcc will not work with files bigger than 4GB
« Reply #3 on: September 08, 2008, 02:33:44 PM »

Fixed progress bar.
Logged
concordia cum veritate

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1189
  • CentOS 6 User
Re: alc and alcc will not work with files bigger than 4GB
« Reply #4 on: September 12, 2008, 04:15:42 AM »

Hmm..i didn't remember having "fixed" this 4GB issue...I hope lfroen (or whoever wants to do it) fixes all the 4GB issues that are around in the webserver.

Regards.
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4319
Re: alc and alcc will not work with files bigger than 4GB
« Reply #5 on: September 12, 2008, 09:30:11 AM »

Quote
I fixed this issue by doing the following:
...

Could you please make a list with the amuleweb problems?
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1189
  • CentOS 6 User
Re: alc and alcc will not work with files bigger than 4GB
« Reply #6 on: September 18, 2008, 02:37:03 AM »

Hi wuischke:

The main issue I see with amuleweb is this one: http://bugs.amule.org/view.php?id=1317

Regards.
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4319
Re: alc and alcc will not work with files bigger than 4GB
« Reply #7 on: September 21, 2008, 03:37:39 PM »

This problem has been fixed now. Are there more problems?

Edit: Forget it, it's not fixed after all. :( Now it'll display 100% blue after downloading 6MB from 4GB...

Edit 2: Shit, it's supposed to be this way. Black is finished and a varying shade of blue is the availability...it's been too long since I used aMule. :(
« Last Edit: September 21, 2008, 03:55:54 PM by wuischke »
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1189
  • CentOS 6 User
Re: alc and alcc will not work with files bigger than 4GB
« Reply #8 on: September 21, 2008, 09:12:38 PM »

Thanks wuischke. I'll try it soon (real soon, not amule soon ;) ) because currently I'm on 2.2.2

Regards.
Logged