aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: Recursive shares: periodic rescans  (Read 10191 times)

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 318
Recursive shares: periodic rescans
« on: April 26, 2009, 05:14:04 PM »

At the moment if a directory is recursively shared, any new directories added below it are not  added to the sharelist.

The only way to add those directories is to either add them manually or unshare/reshare the parent directory in preferences.

Ditto if files are added to the directories - although in this case it's a matter of hitting the reload button in shared files tab.

It'd be nice to have periodic automated rescans of shared directories/suddirectories.

It'd be even nicer if shared directories and files could be configured using amulegui

Thanks
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Recursive shares: periodic rescans
« Reply #1 on: April 26, 2009, 08:05:02 PM »

The only way to add those directories is to either add them manually or unshare/reshare the parent directory in preferences.
You're right, rescan button doesn't work in this case. AMule restart neither. That's a bug of course.

I'm against periodic rescans - I'd rather fix the manual rescan.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Recursive shares: periodic rescans
« Reply #2 on: April 27, 2009, 07:53:54 AM »

I'd rather fix the manual rescan.

For that you'll have to change the format of shareddir.dat.
Logged
concordia cum veritate

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Recursive shares: periodic rescans
« Reply #3 on: April 27, 2009, 09:03:16 AM »

Which you won't.
Logged

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 318
Re: Recursive shares: periodic rescans
« Reply #4 on: April 28, 2009, 01:17:36 AM »


You're right, rescan button doesn't work in this case. AMule restart neither. That's a bug of course.


In your TOFIX list already?

Quote

I'm against periodic rescans - I'd rather fix the manual rescan.

How about making periodic an option?

Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Recursive shares: periodic rescans
« Reply #5 on: April 28, 2009, 11:40:24 AM »

In your TOFIX list already?

Which you won't.

More in my WONTFIX list it seems.   :-X
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Recursive shares: periodic rescans
« Reply #6 on: April 28, 2009, 03:12:19 PM »

Folders are shared explicitly, not because they pop up in a shared folder.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Recursive shares: periodic rescans
« Reply #7 on: April 28, 2009, 06:39:06 PM »

OK, I can see that's how it is. Question is if that's how it should be.
This might prevent people sharing files, so I think that's an issue.

(Side note: ever tried sharing a folder with 280 subfolders ?)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 318
Re: Recursive shares: periodic rescans
« Reply #8 on: May 09, 2009, 04:34:42 AM »

OK, I can see that's how it is. Question is if that's how it should be.
This might prevent people sharing files, so I think that's an issue.

Ditto.

It's annoying because you can't trigger a rescan _OR_ define shared directories using amule remote interfaces.

Quote
(Side note: ever tried sharing a folder with 280 subfolders ?)

Uuuuuuuugly....

Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Recursive shares: periodic rescans
« Reply #9 on: May 09, 2009, 06:22:30 AM »

Right click on the icon and it shares all the subfolders. What's the issue?
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Recursive shares: periodic rescans
« Reply #10 on: May 09, 2009, 05:16:22 PM »

Logged
concordia cum veritate

woutermense

  • Full Member
  • ***
  • Karma: 18
  • Offline Offline
  • Posts: 154
Re: Recursive shares: periodic rescans
« Reply #11 on: May 09, 2009, 06:27:13 PM »

On linux you could hide a little bit of code in your initscripts.

I experimented with this:
Code: [Select]
tree -dfino /home/aMule/.amule/shareddir.dat <path_to_share_dir> --noreport
This overwrites your shareddir.dat with the directory tree of your share.

On another note: Afaik amuled does not support SIGHUP syscalls? Would be nice to reload your config without having to restart amuled.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Recursive shares: periodic rescans
« Reply #12 on: May 09, 2009, 10:12:00 PM »

What's the issue?
[...] using amule remote interfaces.

Then just fix EC. Still, what's the issue? I was talking to Stu, not the other dude with the weird nickname.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Recursive shares: periodic rescans
« Reply #13 on: May 10, 2009, 12:50:20 PM »

People might add files to their shared dirs using new subdirs and not notice they don't get shared. That's what might be an issue.
We could change the share format prepending '+' ("share this recursively") and '-' ("don't share this"), then a simple "reload shared" would take care of it as expected. Periodic rescan would also become possible.

Quote
(Side note: ever tried sharing a folder with 280 subfolders ?)

Uuuuuuuugly....
Fixed since 9586.  :)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Recursive shares: periodic rescans
« Reply #14 on: May 10, 2009, 09:12:22 PM »

You really can't change the shared dirs dat format.
Logged
Pages: [1] 2