aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: losing file data when renamed  (Read 10255 times)

gav616

  • Guest
losing file data when renamed
« on: May 07, 2009, 03:10:26 PM »
downloaded file 'X', completed the file, renamed 'X' to 'Y' (in my nix file-manager), aMule rehashes 'Y' and loses all the data from when named 'X',

shouldn't it know that I've just renamed it and keep the data? that's what MD4  is for, right?

using SVN
« Last Edit: July 29, 2009, 05:59:46 PM by gav616 »
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: losing file data when renamed
« Reply #1 on: May 07, 2009, 09:49:06 PM »
Yes, it should do that.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: losing file data when renamed
« Reply #2 on: May 07, 2009, 09:59:22 PM »
Should it? Why do you assume it's the same file?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: losing file data when renamed
« Reply #3 on: May 07, 2009, 10:07:33 PM »
Same size and MD4 after hashing, same file.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 570
Re: losing file data when renamed
« Reply #4 on: May 07, 2009, 10:34:37 PM »
I can confirm!

Maybe the statistics for the file are saved with the name of the file, and not with the hash?
Logged

gav616

  • Guest
Re: losing file data when renamed
« Reply #5 on: May 07, 2009, 11:15:55 PM »
yeap, names of files don't matter its the ID's....same with clients, nicks don't matter its there IP or ident i think.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: losing file data when renamed
« Reply #6 on: May 08, 2009, 02:19:15 AM »
so what happens when you have the same file in two different places?

Logged

gav616

  • Guest
Re: losing file data when renamed
« Reply #7 on: May 08, 2009, 01:47:09 PM »
amule handles the same as emule and shares the first one,  ignoring the second 'same' file, regardless of name or location. But it couples the stats for the first one only.

why you would what to share same file twice?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: losing file data when renamed
« Reply #8 on: May 08, 2009, 07:25:57 PM »
Quote from: Kry on May 08, 2009, 02:19:15 AM
so what happens when you have the same file in two different places?
Warning in the log view, and publish only the name of the first. The second one must be stored in known files too of course, or it will be rehashed every time.
Stats will stick to the hash, not to the file. This might mean both known files will be stored with identical stats (haven't investigated the data model).
You can't say for which one an upload request should be counted anyway.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

gav616

  • Guest
Re: losing file data when renamed
« Reply #9 on: May 14, 2009, 02:56:38 PM »
so is this fixed yet? (or getting...)
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: losing file data when renamed
« Reply #10 on: May 14, 2009, 09:15:01 PM »
Eventually, unless Kry decides to veto it.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

gav616

  • Guest
Re: losing file data when renamed
« Reply #11 on: November 26, 2009, 01:02:17 PM »
This is still here and really annoying when co-releasing, any news on fixing?

(also renaming in shared files tab would help too)
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: losing file data when renamed
« Reply #12 on: November 26, 2009, 07:00:30 PM »
Quote from: gav616 on November 26, 2009, 01:02:17 PM
(also renaming in shared files tab would help too)

The patch is ready but one of the files it touches is still locked.
Logged
concordia cum veritate

gav616

  • Guest
Re: losing file data when renamed
« Reply #13 on: November 27, 2009, 07:29:58 PM »
ahh i see.

*waits patiently *
Logged

gav616

  • Guest
Re: losing file data when renamed
« Reply #14 on: May 17, 2010, 03:19:45 PM »
I see '10174' enables renaming of completed file, this also seems to fix 'this' problem, It seems to keep all stats data from the file you rename.

p.s.

You have to restart 'rGUI' for the renamed file to update

EDIT*

I thought this problem was fixed, but it's not, if I rename the file in my file manager it resets all the data when I reload 'shared files' it's not recognising that its the same hash just a different name.
« Last Edit: May 17, 2010, 03:22:42 PM by gav616 »
Logged
Pages: [1] 2
« previous next »