aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Friendlist impossible actions  (Read 3338 times)

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 570
Friendlist impossible actions
« on: June 01, 2009, 05:54:15 PM »

Yeah,

example: i can't give 1 of my friends an FS...it's greyed out like when he's not online, but he is connected to me, and downloading from me! (or sometimes in queue....)

So I must always do remove friends, re-add as friend, then it works for this session :/

Any idea?

I gave a look in the code sections...but i really don't understand  it :P
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Friendlist impossible actions
« Reply #1 on: June 01, 2009, 10:46:38 PM »

There's something broken here. The userhash of the client is not used for identification in the friend list control. So friends who changed their IP address since last time are not linked, and the friend slot can't be established.

I see to that I fix it.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 570
Re: Friendlist impossible actions
« Reply #2 on: June 02, 2009, 01:14:23 AM »

Maybe they are not identified also for the Nick Thief addon ex. [sd2kj] which is sendet by much mods, changing everytime?

Thanks!
Logged

Jiut

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Re: Friendlist impossible actions
« Reply #3 on: June 03, 2009, 01:26:11 PM »

There is also an action possible that better should be impossible: I can add people who are not identified (i. e. their name is "?" and IP is 0.0.0.0) as friends. They appear in the friends' list, too.
Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: Friendlist impossible actions
« Reply #4 on: June 03, 2009, 04:48:36 PM »

There is also an action possible that better should be impossible: I can add people who are not identified (i. e. their name is "?" and IP is 0.0.0.0) as friends. They appear in the friends' list, too.
I tried this from the known Clients list and the context menu entry "Add to Friends" was disabled. How did you accomplish this?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Friendlist impossible actions
« Reply #5 on: June 07, 2009, 03:39:39 PM »

Fixed in 9654.

Maybe they are not identified also for the Nick Thief addon ex. [sd2kj] which is sendet by much mods, changing everytime?
No, the nick is not used for identification.
Actually friends are identified twice: once in the core and once in the GUI. The GUI identification used only IP/port and thus didn't work if the IP changed. Now it uses the userhash too (like the core already did).
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon