Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[ulnpzf]

Many East Asian words(for example, Korean, Japanese, Chinese etc) are composed one or two characters. But Kademlia allows only keywords which are composed more than three characters. So I always have to use ED2K for searching of short keywords.

[^marcell^]

I take it you use the latest stable amule (2.2.6). This should be fixed in the SVN version, see here: http://forum.amule.org/index.php?topic=17027.msg91271#msg91271.
The patch didn't make it into the new release, so if it's a big problem, you have to use the SVN version.

[GonoszTopi]

This should be fixed in the SVN version

Negative, this is quite a different issue which your patch didn't affect.

Many East Asian words(for example, Korean, Japanese, Chinese etc) are composed one or two characters. But Kademlia allows only keywords which are composed more than three characters.

Valid request. I'll take care of it. (If I don't forget, of course. If there's no progress in a couple of days feel free to remind me.)

[^marcell^]

This should be fixed in the SVN version

Negative, this is quite a different issue which your patch didn't affect.

Are you sure about that. I thought we ditched the keyword length assertion too.

[GonoszTopi]

This should be fixed in the SVN version

Negative, this is quite a different issue which your patch didn't affect.

Are you sure about that. I thought we ditched the keyword length assertion too.

Absolutely.

Code: [Select]

if ((len = current_word.Length()) > 2) {
current_word.MakeLower();
if (!allowDuplicates) {
words->remove(current_word);
}
words->push_back(current_word);
}
We've talked about it and rejected (maybe I vetoed, I don't remember and atm I don't feel like digging up old posts).

[Stu Redman]

Are such short keywords published to Kad at all? If not searching them won't work anyway.

[GonoszTopi]

Are such short keywords published to Kad at all? If not searching them won't work anyway.

Yes.

[GonoszTopi]

Now we count the bytes in the UTF-8 representation of the keyword instead of the unicode characters. It is implemented a while ago in eMule, we just forgot to follow them.

[ulnpzf]

I take it you use the latest stable amule (2.2.6). This should be fixed in the SVN version, see here: http://forum.amule.org/index.php?topic=17027.msg91271#msg91271.
The patch didn't make it into the new release, so if it's a big problem, you have to use the SVN version.

I downloaded aMule SVN r9712 deb file and installed. And I typed
sudo apt-key adv --recv-keys --keyserver keyserver.ubuntu.com 55DC8278
to Terminal. Then I added
deb http://ppa.launchpad.net/amule-trunk/ppa/ubuntu jaunty main
deb-src http://ppa.launchpad.net/amule-trunk/ppa/ubuntu jaunty main
to sources.list.
After that I clicked Check button in Update Manager but I couldn't find r9833 update.
How to do I do?

[^marcell^]

Any recent* SVN will do. I am not a packager so I can't help you with this.
You could download the latest tarball and compile aMule by hand.

But as GonoszTopi said: the above said change is not in it.
So you will have to wait until it gets implemented properly.

*EDIT

[GonoszTopi]

But as GonoszTopi said: the above said change is not in it.
So you will have to wait until it gets implemented properly.

Sorry if wasn't clear enough. I meant to say that it's implemented in rev. 9832.