aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: The short keyword restriction for Kademlia searching is a problem for East Asian  (Read 4967 times)

ulnpzf

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5

Many East Asian words(for example, Korean, Japanese, Chinese etc) are composed one or two characters. But Kademlia allows only keywords which are composed more than three characters. So I always have to use ED2K for searching of short keywords.

Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524

I take it you use the latest stable amule (2.2.6). This should be fixed in the SVN version, see here: http://forum.amule.org/index.php?topic=17027.msg91271#msg91271.
The patch didn't make it into the new release, so if it's a big problem, you have to use the SVN version.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685

This should be fixed in the SVN version
Negative, this is quite a different issue which your patch didn't affect.

Many East Asian words(for example, Korean, Japanese, Chinese etc) are composed one or two characters. But Kademlia allows only keywords which are composed more than three characters.
Valid request. I'll take care of it. (If I don't forget, of course. If there's no progress in a couple of days feel free to remind me.)
Logged
concordia cum veritate

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524

This should be fixed in the SVN version
Negative, this is quite a different issue which your patch didn't affect.
Are you sure about that. I thought we ditched the keyword length assertion too. ::)
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685

This should be fixed in the SVN version
Negative, this is quite a different issue which your patch didn't affect.
Are you sure about that. I thought we ditched the keyword length assertion too. ::)
Absolutely.
Code: [Select]
if ((len = current_word.Length()) > 2) {
current_word.MakeLower();
if (!allowDuplicates) {
words->remove(current_word);
}
words->push_back(current_word);
}
We've talked about it and rejected (maybe I vetoed, I don't remember and atm I don't feel like digging up old posts).
Logged
concordia cum veritate

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming

Are such short keywords published to Kad at all? If not searching them won't work anyway.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685

Are such short keywords published to Kad at all? If not searching them won't work anyway.
Yes.
Logged
concordia cum veritate

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685

Now we count the bytes in the UTF-8 representation of the keyword instead of the unicode characters. It is implemented a while ago in eMule, we just forgot to follow them.
Logged
concordia cum veritate

ulnpzf

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5

I take it you use the latest stable amule (2.2.6). This should be fixed in the SVN version, see here: http://forum.amule.org/index.php?topic=17027.msg91271#msg91271.
The patch didn't make it into the new release, so if it's a big problem, you have to use the SVN version.
I downloaded aMule SVN r9712 deb file and installed. And I typed
sudo apt-key adv --recv-keys --keyserver keyserver.ubuntu.com 55DC8278
to Terminal. Then I added
deb http://ppa.launchpad.net/amule-trunk/ppa/ubuntu jaunty main
deb-src http://ppa.launchpad.net/amule-trunk/ppa/ubuntu jaunty main
to sources.list.
After that I clicked Check button in Update Manager but I couldn't find r9833 update.
How to do I do?
« Last Edit: September 30, 2009, 06:44:13 AM by ulnpzf »
Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524

Any recent* SVN will do. I am not a packager so I can't help you with this.
You could download the latest tarball and compile aMule by hand.

But as GonoszTopi said: the above said change is not in it.
So you will have to wait until it gets implemented properly.

*EDIT
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685

But as GonoszTopi said: the above said change is not in it.
So you will have to wait until it gets implemented properly.

Sorry if wasn't clear enough. I meant to say that it's implemented in rev. 9832.
Logged
concordia cum veritate