aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: A Bug in sourcecode ServerSocket.cpp  (Read 2868 times)

szsuj

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
A Bug in sourcecode ServerSocket.cpp
« on: January 29, 2010, 03:03:05 AM »

In Line 555 , I think it should be " if (size >= 6) { "


551         case OP_CALLBACKREQUESTED: {
            AddDebugLogLineM(false,logServer,wxT("Server: OP_CALLBACKREQUESTED"));
            
            theStats::AddDownOverheadServer(size);
555            if (size == 6) {
               CMemFile data(packet,size);
               uint32 dwIP = data.ReadUInt32();
               uint16 nPort = data.ReadUInt16();

Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: A Bug in sourcecode ServerSocket.cpp
« Reply #1 on: January 29, 2010, 07:36:00 AM »

You're right, that's a bug in aMule code not present in eMule.  (and it is my fault)

It's been there for a long while, good catch and thanks! (It's been commited to SVN now).
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: A Bug in sourcecode ServerSocket.cpp
« Reply #2 on: January 30, 2010, 11:16:08 PM »

What are the effects of this bug? I guess it's present in aMule 2.2.6, but it works fine for me, so I'm asking...

Thanks!
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: A Bug in sourcecode ServerSocket.cpp
« Reply #3 on: January 31, 2010, 12:41:07 AM »

Problems uploading to lowid people.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: A Bug in sourcecode ServerSocket.cpp
« Reply #4 on: February 05, 2010, 09:37:39 PM »

Looks like that fix uncovered another problem.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon