aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: crash since R10301  (Read 2091 times)

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 397
crash since R10301
« on: September 29, 2010, 06:44:24 AM »

And crash again with 10301
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
crash since R10301
« Reply #1 on: September 29, 2010, 07:27:50 PM »

Now that one is totally unrelated to what we had before. And really bad.  :o
Code: [Select]
*** glibc detected *** /home/schutti/Desktop/X/aMule/amule-2.2.6+svn-r10301/src/amuled: malloc(): smallbin double linked list corrupted: 0x00007fffe41c4590 ***
Corrupted list in malloc() - corrupted heap.

Code: [Select]
#15 0x00000000004407ed in CFormat::operator% (this=0x7fffffffc460,
    value=0x73b498 L"Deleted") at ./libs/common/Format.h:126
#16 0x000000000044a3b3 in CUpDownClient::Disconnected (this=0x7fffef605560,
    strReason=..., bFromSocket=false) at BaseClient.cpp:1369
#17 0x00000000005cf9e9 in CUploadQueue::SortGetBestClient (this=0x1616ba0,
    sortonly=true) at UploadQueue.cpp:91
#18 0x00000000005d1996 in CUploadQueue::AddClientToQueue (this=0x1616ba0,
    client=0x7fffe43c16b0) at UploadQueue.cpp:483
Called right from the new UploadQueue code of 10301 . But the CFormat is fine and from 5/2009 (9623):
Code: [Select]
    AddDebugLogLineN(logClient, CFormat(wxT("--- %s client D:%d U:%d \"%s\"; Reason was %s"))
        % (bDelete ? wxT("Deleted") : wxT("Disconnected"))
        % m_nDownloadState % m_nUploadState % GetClientFullInfo() % strReason );

Rather odd chance that a crash with new code in the bt might have an unrelated reason. But I have no idea what could be causing this.  ???

You have built it from a fresh directory?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 397
Re: crash since R10301
« Reply #2 on: September 29, 2010, 10:01:32 PM »

Yes, I downloadet the tar, decompressed it, running the configure command as written and than "make".
I startet the programm direkt from the dir i used with gdb.

I will do this again if you need more backtraces.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: crash since R10301
« Reply #3 on: September 29, 2010, 10:29:26 PM »

Please try again to see if you can reproduce it.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 397
Re: crash since R10301
« Reply #4 on: September 30, 2010, 12:08:49 AM »

Here the next backtrace(s)
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: crash since R10301
« Reply #5 on: September 30, 2010, 08:31:14 PM »

Ok, I think I got the sucker. Sorry for the hassle and thanks for the help.
10302

Code: [Select]
Index: UploadQueue.cpp
===================================================================
--- UploadQueue.cpp    (revision 10301)
+++ UploadQueue.cpp    (working copy)
@@ -112,6 +112,7 @@
                 // swap them
                 *it2 = *it1;
                 *it1 = cur_client;
+                it2--;
             } else {
                 // no need to check further since list is already sorted
                 break;
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: crash since R10301
« Reply #6 on: October 01, 2010, 08:34:54 PM »

Stu, you are amazing.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3762
  • Engines screaming
Re: crash since R10301
« Reply #7 on: October 01, 2010, 09:49:08 PM »

Hey, thanks.  :D
But this here isn't amazing really. Getting it right in the first place would have been better, and fixing it took just some careful thinking through the change of 10301.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: crash since R10301
« Reply #8 on: October 02, 2010, 06:42:38 PM »

Not just this, but all the fixing you do.
Thank you.
Logged