aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: autogen.sh in Ubuntu 11.10  (Read 2313 times)

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
autogen.sh in Ubuntu 11.10
« on: October 15, 2011, 09:38:07 PM »

Code: [Select]
...
Copying file mkinstalldirs
Copying file po/Makefile.in.in
autopoint does not honor dataroot variable, patching.
[: 58: xLinux: unexpected operator
Running aclocal -I m4
Running autoheader
Running autoconf
Creating pixmaps Makefile.am
Running automake --foreign -a -c -f
Do we have a problem here?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

btkaos

  • Global Moderator
  • Sr. Member
  • *****
  • Karma: 110
  • Offline Offline
  • Posts: 486
  • Kaos is infinite!
Re: autogen.sh in Ubuntu 11.10
« Reply #1 on: October 15, 2011, 10:42:51 PM »

Code: [Select]
...
Copying file mkinstalldirs
Copying file po/Makefile.in.in
autopoint does not honor dataroot variable, patching.
[: 58: xLinux: unexpected operator
Running aclocal -I m4
Running autoheader
Running autoconf
Creating pixmaps Makefile.am
Running automake --foreign -a -c -f
Do we have a problem here?

Umm right now I'm very busy and I can't test, but it seems like a problem of using dash in place of dash

Look for /bin/sh and replace it for /bin/bash

If the problem persist I'll have a look.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
Re: autogen.sh in Ubuntu 11.10
« Reply #2 on: October 15, 2011, 10:53:11 PM »

With bash it works.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2678
Re: autogen.sh in Ubuntu 11.10
« Reply #3 on: October 16, 2011, 12:17:24 PM »

As far as I know, it's the '==' operator. In sh you need to use '=' for string equality tests. Bash understands both.

I won't revert it to sh, because currently I can't test it (I don't have a real sh), but it'd be better tested and fixed before someone cries that his system doesn't have bash.
Logged
concordia cum veritate

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5823
Re: autogen.sh in Ubuntu 11.10
« Reply #4 on: October 16, 2011, 01:19:41 PM »

I'll bash anyone whose system doesn't have bash (and my rationale for allowing it was that it's only autogen, and releases have it already generated). Also we probably require bash in other places TBH. But, there's no real need for it.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 165
  • Offline Offline
  • Posts: 2678
Re: autogen.sh in Ubuntu 11.10
« Reply #5 on: October 16, 2011, 04:28:52 PM »

I'll bash anyone whose system doesn't have bash
Solaris, for example (iirc).

Also we probably require bash in other places TBH.
I don't think so. There was a thread some time ago (I won't look it up for you now) reporting sh incompatibilities. Then we fixed the build system at least to work with plain sh.
Logged
concordia cum veritate