aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Problem with configure since SVN-10626  (Read 2032 times)

gnazio

  • Approved Newbie
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 18
  • Live long and prosper
Problem with configure since SVN-10626
« on: December 11, 2011, 01:02:26 AM »


I noticed a problem in configure since SVN-10626.
At the beginning I was thinking that it was caused by a problem with png on my system or with the png test which has been introduced in configure since that revision.
In fact the test was failing and I had to force png using -lpng in LDFLAGS.

Having some time to have a look at configure, it turned out it is caused by some bashisms.

In fact starting at line 7366 (SVN-10626), there are the following three lines:
Code: [Select]
CFLAGS+=" $LIBPNG_CFLAGS"
LDFLAGS+=" $LIBPNG_LDFLAGS"
LIBS+=" $LIBPNG_LIBS"

which don't work where /bin/sh as in the shebang is actually sh, and not bash.

This problem is still present in the last SVN revision I've downloaded, which is 10688.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
Re: Problem with configure since SVN-10626
« Reply #1 on: December 11, 2011, 11:37:58 AM »

Can you post a patch for libpng.m4 that works for you? I'm not good at sh.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

gnazio

  • Approved Newbie
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 18
  • Live long and prosper
Re: Problem with configure since SVN-10626
« Reply #2 on: December 11, 2011, 11:53:14 AM »


Sure!
The attached patch is against SVN-10688
Thanks!
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3764
  • Engines screaming
Re: Problem with configure since SVN-10626
« Reply #3 on: December 11, 2011, 04:34:46 PM »

Committed, thank you!  :)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon