aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: [Debian Linux] Crash when clicking on the Statistic button  (Read 5767 times)

Underpass

  • Approved Newbie
  • *
  • Karma: 3
  • Offline Offline
  • Posts: 14
[Debian Linux] Crash when clicking on the Statistic button
« on: May 13, 2012, 01:50:38 PM »
Hello,

Yesterday I've compiled SVN version 10785 and noticed that problem. So I compiled the last version, 10787 and found the same problem.
So I switched back to SVN 10771 and it runs smoothly - moreover version 10771 seems to have a smaller  CPU load.

If you need further information, please tell me how I can be of more help.

Thanks for your work. :)
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [Debian Linux] Crash when clicking on the Statistic button
« Reply #1 on: May 13, 2012, 06:34:46 PM »
Uh-oh.
There were some massive "code-cleanups" in versions 10782 - 10784. Apparently something went wrong there.
I can reproduce the crash.

I'm sure GonoszTopi will look into it as soon as he can.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 570
Re: [Debian Linux] Crash when clicking on the Statistic button
« Reply #2 on: May 14, 2012, 07:21:50 AM »
Oh...

Yesterday when I was reading this I tried it, but nothing happened.

Right now it crashed here as well :/
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: [Debian Linux] Crash when clicking on the Statistic button
« Reply #3 on: May 16, 2012, 12:15:26 AM »
Those "code-cleanups" revealed a real bug. Fixed in rev. 10788.
Logged
concordia cum veritate

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 318
Re: [Debian Linux] Crash when clicking on the Statistic button
« Reply #4 on: May 18, 2012, 10:45:57 PM »

Hey, thanks for those code cleanups - and this bugfix :)


Some folk say that static code analyzers generate too many false positives - one response is that if they can't understand the code, then it probably needs rewriting to be understandable by humans.

I'll just  say that finding that  memory leak was worth the cleanup.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [Debian Linux] Crash when clicking on the Statistic button
« Reply #5 on: May 19, 2012, 11:37:24 AM »
Well, we have found an easy-to-detect crash bug now.
I have no idea how many rarely-trodden code paths were touched as well and might now break. No problem about the ++it changes, but I'm a bit suspicious about the pointer casts. (Not to mention that the extra code required for the dynamic casts by far exceeds the benefit from the ++it optimization.)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 318
Re: [Debian Linux] Crash when clicking on the Statistic button
« Reply #6 on: May 28, 2012, 09:40:58 PM »
and a memory leak.

Amule here has a 22 day uptime and is still only using a few hundred Mb.

Previously it had to be restarted every 5-6 days because it'd bloat out to a few Gb.





Logged