aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Fixed significant memory leaks  (Read 4812 times)

ken

  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 825
Fixed significant memory leaks
« on: December 07, 2004, 08:44:29 AM »
I found a couple of serious memory leaks in wxMac that were affecting aMule.  I submitted patches to wxMac and they have been accepted.  If you're interested, the patches I submitted are https://sourceforge.net/tracker/index.php?func=detail&aid=1080457&group_id=9863&atid=309863 and https://sourceforge.net/tracker/index.php?func=detail&aid=1080444&group_id=9863&atid=309863.  The latter is the much more serious leak.

So, build a new version of wxMac from CVS and relink aMule and you should get much better long-term performance.

Whee!  I've contributed!   :D 8)
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: Fixed significant memory leaks
« Reply #1 on: December 07, 2004, 04:43:56 PM »
damn, go look for leaks in aMule! ;D

Great job you did. Let's see if aMule crashes a bit less now in wxMac xD

Greetings!
Logged

ASTIOBOY

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 24
Re: Fixed significant memory leaks
« Reply #2 on: December 08, 2004, 11:36:28 AM »
ken, could you please post a zip of the compiled application like the one on the homepage?

I started compiling wxMac CVS and got errors, I don't have too much time to spend on these things in these days...

Thanks
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Fixed significant memory leaks
« Reply #3 on: December 08, 2004, 04:28:56 PM »
I'll do it tonight
Logged

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Fixed significant memory leaks
« Reply #4 on: December 09, 2004, 04:44:10 AM »
thanks a lot for your efforts ken -- i compiled amule with most recent wx cvs earlier today and so far things look promising... :)

probably not very relevant right now if kry posts a new mac binary later today, but in the future if you want a binary using most recent amule cvs and most recent wx cvs, come to #macmule on irc.freenode.net and get in touch with me...
Logged
Current aMule CVS builds for OS X can be found here.

ken

  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 825
Re: Fixed significant memory leaks
« Reply #5 on: December 09, 2004, 07:55:17 PM »
Quote
Originally posted by Jacobo221
damn, go look for leaks in aMule! ;D
I was looking for leaks in aMule and that's how I found these two.  They were by far the largest of the leaks I found.  I'll keep testing and trying to diagnose leaks as I get the chance.

By the way, I found these two with /Developer/Applications/Performance Tools/MallocDebug.app.  It took a little fidgeting to get it working because of a multiply-defined symbol between one of the wxMac shared libraries and some system libraries that MallocDebug forces the app to load.  I used the 'strip' command to remove the conflicting symbol from the offending wxMac library's symbol table.

I'm pretty sure that static linking aMule against wxMac would avoid that problem.
Logged

robda

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 12
Re: Fixed significant memory leaks
« Reply #6 on: December 13, 2004, 12:05:06 AM »
hi this is my first post, so first of all i want to say how great it is to have an emule without a pc. Yust me and my mac ;)

thanks alot !!!

can someone please post a mac binary like on the homepage, without the memory leaks.

this would be very nice for all the mac users, who cannot compile by themselves. :]

sorry for my bad english
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Fixed significant memory leaks
« Reply #7 on: December 13, 2004, 12:19:59 AM »
I'll be able as soon as the guy providing me a mac access for compiling is back ;)
Logged

robda

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 12
Re: Fixed significant memory leaks
« Reply #8 on: December 13, 2004, 12:27:24 AM »
wow that is a quick response. Thank you for your wonderfull work. I waited nearly years for an emule that works on my mac. So a day a more ... ;)

robda
Logged