aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Don't ip filter a given file  (Read 6984 times)

i23098

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Don't ip filter a given file
« on: August 30, 2005, 03:05:51 AM »
There should be a option in the file contex to select "Don't ipfilter".

My ISP charges differently for national traffic and international traffic, so I have an ipfilter.dat that allows only national trafic, but sometimes there are files that are only available internationally or have very few sources. In that files I would like to disable the ip filter...

There are windows emule clients that does this and more (updates ipfilter...) for the portuguese users (http://pwp.netcabo.pt/DeepSea/ and http://koizo.sourceforge.net/) that I use, but are windows only  :(

Disabling the ipfilter for a given file would also mean that the file could be shared ignoring the ipfilter file...
Logged

i23098

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Re: Don't ip filter a given file
« Reply #1 on: August 30, 2005, 02:00:11 PM »
I made a quick peak to the latest cvs source code, and this seems a simple enhancement (with huge advantages, at least for most portuguese users  :)) ).

From what I understood the IPFilter.cpp mantains the filtered IP's, but it's the responsability of the other components the call to check (IsFiltered). This way, the change required would be in PartFile.cpp, adding a new boolean attribute (allowFilter), and instead  of calling IsFiltered, call allowFilter && IsFiltered (if allowFilter is false, it wouldn't check filter).

If I'm correct, then the hardest part would be making the GUI (which I understant nothing  ;():
    - Add to Context menu "Don't ipfilter this file"
    - Show that the file isn't filtered (e.g. put the background color yellow in the line of the file)
Logged

i23098

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Re: Don't ip filter a given file
« Reply #2 on: September 02, 2005, 02:21:58 PM »
Can someone agree/disagree with me  ?(

Are just the portuguese users that have different traffic limitations (national/international)  ?(  ;(
Logged

thedude0001

  • evil bugfinder ;)
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 827
Re: Don't ip filter a given file
« Reply #3 on: September 02, 2005, 03:31:14 PM »
I've heard this several time now, but only from Portugal and Estonia (?)...
Logged
Das Schlimme auf dieser Welt ist
daß die Dummen so selbstsicher sind
und die Gescheiten so voller Zweifel.

Mr Faber

  • Full Member
  • ***
  • Karma: 0
  • Offline Offline
  • Posts: 229
Re: Don't ip filter a given file
« Reply #4 on: September 02, 2005, 06:11:50 PM »
I think that this would be a little bit unfair. Ok, international clients can download from you after some time if you opened the ip but only some/opened one.
Another point is that you can't find an international ip if your ipfilter works correctly so you can't get them as a source and can't open them.

I can hardly believe that a neighbor from spain, the aMue country ;), can be so cruel to his p2p community. If countries like New Zealand do it which are at the end of the world I can unterstand it a little bit but portugal? I would do pressure on the isps so that they open the nationalnet to the internet without costs.

cu
Mr Faber
Logged

thedude0001

  • evil bugfinder ;)
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 827
Re: Don't ip filter a given file
« Reply #5 on: September 02, 2005, 10:19:58 PM »
I don't get the point where you think it would be unfair, Mr Faber. You have to separate two things here:
- There ARE already ipfilter.dat which block all IP adresses that are not inside portugal. The way IP filtering works ALL connections are blocked, upload and download. That is fair IMO.

- i23098 asks for a possibilty to disable IP filtering for some files. So he would be uploading to / download from international clients. Certainly nothing unfair in here.

The whole situation (portuguese(?) ISPs charging differently for national / international traffic) IS unfair / not good / not what the internet is all about. But that is a little off the topic of this thread...
Logged
Das Schlimme auf dieser Welt ist
daß die Dummen so selbstsicher sind
und die Gescheiten so voller Zweifel.

N0rg

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 7
Re: Don't ip filter a given file
« Reply #6 on: September 11, 2005, 11:49:46 PM »
I i´m also a portuguese user of aMule, and I use Mac OS X. I agree with this post.

Já agora como carregas o ipfilter.dat no aMule?

Jimmy N0rg
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Don't ip filter a given file
« Reply #7 on: September 12, 2005, 03:45:26 AM »
I might agree with this.
Logged

SmurfDaddy

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 1
Re: Don't ip filter a given file
« Reply #8 on: September 23, 2005, 12:39:04 PM »
The national/international trafic distinction in Portugal sucks, but thats the way we stand at the moment. And of course there are lots of protests about this matter.

If it's possible to have a simple fix implementing the per-file filtering than whould be a great thing to aMule because it represents the possibility increase the number of file shares.

imho
« Last Edit: September 23, 2005, 12:39:33 PM by SmurfDaddy »
Logged

pureza

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
RE: Don't ip filter a given file
« Reply #9 on: July 10, 2006, 05:04:29 PM »
Maybe this is of some interest to you:

Enable/disable IPFilter by file

Luís Pureza
Logged

To

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 80
Re: Don't ip filter a given file
« Reply #10 on: August 16, 2006, 05:38:14 PM »
I usually use amule-cvs (just helping how I can), and this file failt to patch any of the newer versions of amule.
Logged

xupetas

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 29
Re: Don't ip filter a given file
« Reply #11 on: September 12, 2006, 01:25:33 PM »
yep..

I've tried to compile against 2.1.3 and the compilation went south
Logged

thedude0001

  • evil bugfinder ;)
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 827
Re: Don't ip filter a given file
« Reply #12 on: September 13, 2006, 09:45:18 AM »
No idea if he was actually using the patch in the linked thread, but GonoszTopi has committed this feature to SVN a couple of days ago...
Logged
Das Schlimme auf dieser Welt ist
daß die Dummen so selbstsicher sind
und die Gescheiten so voller Zweifel.

wardevil

  • Sr. Member
  • ****
  • Karma: -1
  • Offline Offline
  • Posts: 402
Re: Don't ip filter a given file
« Reply #13 on: September 13, 2006, 11:19:20 PM »
So....where the hell is that feature?
Not on svn today or i really missed it and cant find it.....  ?(

Cheers....
Logged
Linux user nº289016 at Linux counter

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Don't ip filter a given file
« Reply #14 on: September 15, 2006, 07:40:18 PM »
Quote
Originally posted by thedude0001
No idea if he was actually using the patch in the linked thread, but GonoszTopi has committed this feature to SVN a couple of days ago...

thedude0001, you have seriously misunderstood something. The patch I committed to SVN is not to turn on/off IP filtering for files one-by-one, but to select whether to filter clients, servers or both. The bug report (feature request) can be found here
Logged
concordia cum veritate