aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Handle national characters during search  (Read 3857 times)

albyz

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
Handle national characters during search
« on: April 18, 2006, 11:04:05 PM »
Hi all,
I am missing an importand part of the old Winsuxx emule client: during search the entered keyword was Unicode- and national character safe, which is not the case with amule.
Right now search for files lists only those hits which have exactly the same substring in the filename. Instead the library alphabet should be used with unicode support, so there would be no difference between o,ö, and Q, for example. When I am searching for "Géza", "Geza" and "GÁ$za" should also be a hit.

Take a look at here:

I've decided to remove the image due to possible conflicts with the rules.

I hope you understand the point. I suppose this would require little effort from the development side and it would improve significantly the search results for non-english users.

Cheers, Albert
« Last Edit: April 18, 2006, 11:32:27 PM by albyz »
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Handle national characters during search
« Reply #1 on: April 19, 2006, 02:20:04 AM »
Did you compile with unicode enabled? Because we already support unicode on searches.

The hits returned are server-side, so we send the proper string, there should be no difference with eMule.
Logged

thedude0001

  • evil bugfinder ;)
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 827
Re: Handle national characters during search
« Reply #2 on: April 19, 2006, 02:23:30 PM »
Just did a quick check with your example, searching for géza also returns hits on geza for me.
Logged
Das Schlimme auf dieser Welt ist
daß die Dummen so selbstsicher sind
und die Gescheiten so voller Zweifel.

albyz

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
Re: Handle national characters during search
« Reply #3 on: April 20, 2006, 12:23:46 PM »
Search does make a difference between national characters.

Searching locally for geza: 106 result, including filenames with geza and gÁ$za  (Unicode é). Searching locally for géza: 3 result, including filenames with géza. These last 3 were not found at the previous search.

It seems something is not working properly. I will try to recompile as Kry suggested.
Logged