aMule Forum

English => en_Bugs => Topic started by: stoatwblr on April 18, 2010, 06:15:56 AM

Title: padded filter lists
Post by: stoatwblr on April 18, 2010, 06:15:56 AM

Hopefully this isn't a bug, or has been addressed previously.

I've noticed that some IP filter lists are zero-padded and some aren't.

While the RFCs are very clear that IP addresses are decimal a lot of parsers and standard libraries are broken and treat leading 0's as OCTAL

End result: the IP written down isn't the IP the machine uses.

I can't see how to get a dump of filtered IPs out of a running amule to double check this. Has anyone verified that what goes in is what comes out?

Title: Re: padded filter lists
Post by: Stu Redman on April 18, 2010, 02:15:53 PM

IPs from the IP filter list are parsed with StringIPtoUint32 from NetworkFunctions.cpp which doesn't use any octal folly.

Title: Re: padded filter lists
Post by: stoatwblr on April 18, 2010, 04:37:55 PM

Quote from: Stu Redman on April 18, 2010, 02:15:53 PM

IPs from the IP filter list are parsed with StringIPtoUint32 from NetworkFunctions.cpp which doesn't use any octal folly.

Great to hear. The octal issue has been the cause of a lot of pain over the years (and it's still there in Bind).