aMule Forum

English => en_Bugs => Topic started by: lugdunummaster on July 13, 2004, 02:52:46 PM

Title: amule is not using zlib properly
Post by: lugdunummaster on July 13, 2004, 02:52:46 PM

Hello

It seems edonkey and amule dont use zlib properly.

zlib was added to eserver mainly to decrease bandwidth requirements.

A client that announce zlib capability MUST use zlib when file publication takes place, since this is the most consuming part between a client and its server.

Starting of eserver-16.47, client that falsely announce zlib capability but continue to use uncompressed big packets are disconnected.

Please add the few lines in amule to correct this as soon as possible.

Thank you

Title: Re: amule is not using zlib properly
Post by: Kry on July 13, 2004, 03:16:40 PM

Hi lug and welcome. Can you confirm which aMule is causing that? 1.2.7 or the rc series?

I think it might bejust from 1.2.7 I'll review tonight.


Sorry for the problems :)

Title: Re: amule is not using zlib properly
Post by: lugdunummaster on July 13, 2004, 03:29:30 PM

Well... I just checked 2.0.0rc4 and I confirm the problem is there. For sure all versions have this problem.

check file SharedFileList.cpp

function :

void CSharedFileList::SendListToServer()

Title: Re: amule is not using zlib properly
Post by: deltaHF on July 13, 2004, 04:52:01 PM

hiya lug,

i've noticed using zlib 1.2.1 there's no problem connecting to 16.47 servers and staying connected.
seems ppl with zlib < 1.2.1 have such problems.. i'll test more

greets

Title: Re: amule is not using zlib properly
Post by: galiza_ceive on July 13, 2004, 05:36:49 PM

Same trouble here with zlib 1.2.1(MUST BE USED NOT ONLY ADVERTIZED, server error), amule-cvs (today's snapshot --and yesterday's--)... but yesterday things worked

Edit 1 # i gets connected with servers with 16.46 lugdunum version...

Title: Re: amule is not using zlib properly
Post by: Kry on July 13, 2004, 08:05:30 PM

Ok lug, sorry for the bug. Will fix it ASAP. Amazing it didn't get noticed since then....


/me hides

Title: Re: amule is not using zlib properly
Post by: deltaHF on July 15, 2004, 02:48:59 AM

fixed -> http://www.amule.org/amule/thread.php?threadid=2897&boardid=8&sid=

update asap :)

greets

Title: Re: amule is not using zlib properly
Post by: bridge on July 15, 2004, 09:58:32 AM

Thanks for fixing that so quickly!

Also thanks to thermoman for updating his Debian packages  contemporary.

-bridge

Title: Re: amule is not using zlib properly
Post by: fuzzix on July 16, 2004, 01:36:35 AM

Sorry to jump in on the thread, but does this issue affect any parts downloaded with 1.2.7?
I managed to connect to a few smaller servers and got some parts down.

Thanks.

Title: Re: amule is not using zlib properly
Post by: deltaHF on July 16, 2004, 01:38:22 AM

nope.. u have only to backup your client.met if u switch from/to 1.2x / 2.0.0rcx ..
and 1.2.8 is out too btw ;)

Title: Re: amule is not using zlib properly
Post by: fuzzix on July 16, 2004, 09:26:05 AM

Grabbed it last night - good work guys!