aMule Forum

English => en_Bugs => Topic started by: eMulePlus on July 23, 2004, 09:48:24 PM

Title: Incorrect source exchange packet
Post by: eMulePlus on July 23, 2004, 09:48:24 PM

aMule 1.2.6 reported incorrect source exchange version and there was a hope that 2 bug-fix versions 1.2.7/1.2.8 would fix it, but the problem is still there.
Reported source exchange version doesn't fit format of your source exchange packets.
CUpDownClient::SendMuleInfoPacket contains:

Code: [Select]

CTag tag4(ET_SOURCEEXCHANGE,2);
But the sending packet format is NOT version 2:

Code: [Select]

void CUpDownClient::UDPReaskForDownload()
{
if(!reqfile || m_bUDPPending) {
return;
}

   if(m_nUDPPort != 0 && theApp.glob_prefs->GetUDPPort() != 0 &&
        !theApp.serverconnect->IsLowID() && !HasLowID() && !(socket && socket->IsConnected())) {
   
if(IsSourceRequestAllowed()) {
return;
}
m_bUDPPending = true;
Packet* response = new Packet(OP_REASKFILEPING,16,OP_EMULEPROT);
        memcpy(response->pBuffer,reqfile->GetFileHash(),16);
theApp.uploadqueue->AddUpDataOverheadFileRequest(response->size);
theApp.clientudp->SendPacket(response,GetIP(),GetUDPPort());
}

}I think you know that the official eMule just discards such packets.

--
eMule Plus Team

Title: Re: Incorrect source exchange packet
Post by: deltaHF on July 23, 2004, 09:59:31 PM

has been forgotten, thx

well, then let us fix it and release at weekend 1.2.9 as the last 1.2.x release

greets

Title: Re: Incorrect source exchange packet
Post by: Xaignar on July 23, 2004, 10:01:14 PM

[Nevermind]