aMule Forum

English => en_Bugs => Topic started by: spiralvoice on December 05, 2003, 08:32:16 PM

Title: Wrong opcode for ET_COMPATIBLECLIENT
Post by: spiralvoice on December 05, 2003, 08:32:16 PM
Hi,

@pure_ascii: You wrote today on the MLDonkey world forum about
the recognition of aMule as eMule compatible client in MLDonkey.

Please read my postings there (http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&p=10090#10090) because maybe I found a bug in aMule
regarding the opcode it sends for ET_COMPATIBLECLIENT.

In eMule 0.30d there is in opcodes.h
[code:1]#define ET_COMPATIBLECLIENT      0x26[/code:1]
In aMule (and xMule) is opcodes.h
[code:1]#define ET_COMPATABLECLIENT         0x30[/code:1]
Because of this a patched MLDonkey canŽt recognize aMule because
it looks for 0x26, this works for example with Shareaza.

Greetings, spiralvoice
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: deltaHF on December 05, 2003, 08:54:30 PM
hey spiralvoice,

thx, w'll change it

greets
delta
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: Kry on December 05, 2003, 08:55:01 PM
Thanks for your feedback spiralvoice. I'm not pureascii obviously but I'm a dev too. I'll research on that and fix it, then pure will notify you on MLDonkey forums.


*LATER*

Already changed and posted on MLDonkey forum. Thanks again.
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: spiralvoice on December 05, 2003, 10:09:11 PM
Hi,

thanks for your quick reaction :D

I would like to propose something regarding ET_COMPATIBLECLIENT?

AFAIK

cDonkey uses 1
lMule uses 2 (opcode 0x26 - working)
xMule uses 2 (opcode 0x30 - not working)
aMule uses 3 (opcode 0x30, now 0x26 - working, but not yet seen here :wink:)
Shareaza uses 4 (Hint: missing in BaseClient.cpp :wink: )
MLDonkey uses 10 (new in CVS, donkeyMain.ml, line 144)

Every day clients with flag 2 and opcode 0x26 connect to my MLDonkey,
from what I have written above I suggest they are all lMules.

From what I have read the xMule dev takes some improvements from
aMule and imports them into his source code. I will post this also on the
xMule forum but maybe you have also contact to him.

To better distinguish between lMule and xMule - which was yet impossible
because of opcode 0x30 - xMule should use flag 5.

What do you think about that?

Greetings, spiralvoice
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: spiralvoice on December 05, 2003, 10:23:51 PM
Quote
Original von spiralvoice

I will post this also on the
xMule forum but maybe you have also contact to him.

 :lol:  :lol:  :lol:
When I write "aMule" on their forum it gets "translated" in
Quote
\-- another program --/


Lets see what they do: http://xmule.org/forums/index.php?act=ST&f=3&t=1159#

Greetings, spiralvoice
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: Kry on December 05, 2003, 10:31:18 PM
Well, some posts that can clarify things to you:



http://amule.sourceforge.net/phpBB2/viewtopic.php?t=207

http://xmule.org/forums/index.php?showtopic=1115

http://xmule.org/forums/index.php?showtopic=1113

http://amule.sourceforge.net/phpBB2/viewtopic.php?t=224


Also, the release news from 1.7.1:

http://unthesis.web.aplus.net/article.php?story=20031122093741489


But read it in your spare time... to much bullshit ;)
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: deltaHF on December 05, 2003, 11:17:25 PM
well, even your link to our board doesn't work there spiralvoice .. ->

http://\-- another program --/.sourceforge.net/phpBB2/viewtopic.php?p=1512#1512
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: spiralvoice on December 06, 2003, 12:29:42 AM
Hi,

I have this file:

ed2k://|file|aMule-1.2.0.tar.gz|1606153|AC83A90C460D06787B8BEE397ADE4B93|/

Test my donkey;-)

Greetings, spiralvoice
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: pure_ascii on December 06, 2003, 02:39:35 AM
hi spialvoice,

thx for your fast reply. seems this opcode was changed by fault when trying to be recognised as emule 0.30 instead of 0.26 by servers.

We found the one to blame: Creteil aka Bigbob. ;)

@Creteil: Dont worry, shit happens ;)

bye, PA.
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: BigBob on December 06, 2003, 03:04:18 AM
No one is perfect ...

A++
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: spiralvoice on December 06, 2003, 09:21:13 AM
Hi,

just wanted to drop a note that aMule has been counted :D

Greetings, spiralvoice
Title: Re: Wrong opcode for ET_COMPATIBLECLIENT
Post by: Kry on December 06, 2003, 10:16:34 AM
Great!