aMule Forum

English => en_Bugs => Topic started by: alehack on January 27, 2005, 03:32:18 PM

Title: CClientReqSocket::OnError keeps retrying
Post by: alehack on January 27, 2005, 03:32:18 PM

Hi!
I have been wondering why amule uses more sockets than emule. In addition, the more time you use amule, the more connections it uses.

I have found one possible explanation for this. After taking a look at amule log I discovered the following messages:

01/27/2005 10:59:00 AM: An unnamed client (IP:AAA.BBB.CCC.DDD) caused a socket
blocking error. Retries: 0. Trying to reconnect... (retries left: 2)
...
01/27/2005 10:59:01 AM: An unnamed client (IP:AAA.BBB.CCC.DDD) caused a socket
blocking error. Retries: 0. Trying to reconnect... (retries left: 2)
...
01/27/2005 10:59:02 AM: An unnamed client (IP:AAA.BBB.CCC.DDD) caused a socket
blocking error. Retries: 0. Trying to reconnect... (retries left: 2)
...
01/27/2005 10:59:03 AM: An unnamed client (IP:AAA.BBB.CCC.DDD) caused a socket
blocking error. Retries: 0. Trying to reconnect... (retries left: 2)
...
01/27/2005 10:59:04 AM: An unnamed client (IP:AAA.BBB.CCC.DDD) caused a socket
blocking error. Retries: 0. Trying to reconnect... (retries left: 2)

It is worth noting that AAA.BBB.CCC.DDD are the SAME IP ADDRESS! This means that amule keeps retrying because "retries left" is always 2. This causes lots of problems for users with ISPs that limit the number of openned conenctions.

My quick solution is to comment :
  connection_retries = 0;
in:
  void CClientReqSocket::OnConnect(int nErrorCode)
in ListenSocket.cpp

I´m not sure if this is the correct solution, so I´m posting this here to get some feedback on this.

thanks
alehack

Title: RE: CClientReqSocket::OnError keeps retrying
Post by: alehack on February 02, 2005, 04:16:08 PM

just FYI, amule has been using less connections with the fix.

Title: Re: CClientReqSocket::OnError keeps retrying
Post by: Kry on February 02, 2005, 06:24:59 PM

Yeah, yeah ;)