aMule Forum

English => en_Bugs => Topic started by: GhePeU on February 11, 2005, 05:33:23 PM

Title: [2005-02-11] white bars on A4AF
Post by: GhePeU on February 11, 2005, 05:33:23 PM
as in subject, with rc8 often they weren't showed, now "Asked for another file" have got a full white bar

wxGTK 2.5.3
gtk+ 2.6.2
Title: Re: [2005-02-11] white bars on A4AF
Post by: GhePeU on April 03, 2005, 01:07:01 AM
same problem with 20050402 cvs
Title: Re: [2005-02-11] white bars on A4AF
Post by: Kry on April 03, 2005, 04:46:43 AM
And is it a bug? I think it's intentional ;)
Title: Re: [2005-02-11] white bars on A4AF
Post by: GhePeU on April 03, 2005, 12:13:55 PM
Quote
Originally posted by Kry
And is it a bug? I think it's intentional ;)

I think it's orrible... what's wrong with the empty gray bar?
at least a border! :D
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 03, 2005, 01:23:25 PM
Well, I partly agree. However a full grey bar would give the impression that the source doesn't have any parts, whereas the empty block more aptly conveys that we currently don't know.
Title: Re: [2005-02-11] white bars on A4AF
Post by: Kry on April 03, 2005, 03:25:26 PM
Yup. That's why.
Title: Re: [2005-02-11] white bars on A4AF
Post by: GhePeU on April 03, 2005, 03:30:24 PM
well, I think that white without the border seems a bug more than "no info", it's like part of interface is not plotted on screen :D
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 03, 2005, 04:40:55 PM
Well, what would you use to convey that we don't know?
Title: Re: [2005-02-11] white bars on A4AF
Post by: GhePeU on April 03, 2005, 05:03:47 PM
Quote
Originally posted by Xaignar
Well, what would you use to convey that we don't know?

something like this, with white or maybe with a tone of grey lighter than the one used in "no needed parts"
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 03, 2005, 06:19:44 PM
Trivial to add.
Any objections?
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 03, 2005, 06:44:30 PM
Adding black borders to all the progress bars looks more consistant and neater (IMO):
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 04, 2005, 12:23:27 AM
Improvement suggested by Kry:
Title: Re: [2005-02-11] white bars on A4AF
Post by: skolnick on April 04, 2005, 01:08:29 AM
Great! This is a real cosmetical improvement. Which CVS will be in?

Thanks.
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 04, 2005, 02:59:03 AM
Just got committed. Should be on the next tarball.
Title: Re: [2005-02-11] white bars on A4AF
Post by: indian on April 04, 2005, 09:34:55 AM
Actually, from the same token, y not make the same modification to other status info too, like "too many connections" ..etc
Title: Re: [2005-02-11] white bars on A4AF
Post by: Kry on April 04, 2005, 09:42:57 AM
Because there's a column for that :p
Title: Re: [2005-02-11] white bars on A4AF
Post by: GhePeU on April 04, 2005, 11:28:33 AM
Quote
Originally posted by indian
Actually, from the same token, y not make the same modification to other status info too, like "too many connections" ..etc

I think that bars for "too many connections" should stay grey. they represent a temporary state, in a few seconds or at most a minute they're supposed to switch to another state, and the effect we see is "all bar is grey" -> "parts (or all) of the bar change color"

A4AF is a state that is not supposed to change soon so it deserves something different
Title: Re: [2005-02-11] white bars on A4AF
Post by: m2kio on April 04, 2005, 03:28:23 PM
i just compiled and restarted cvs-20050404 with this modification.
actually this is a visual worsening for me, as i use flat progress bars.

What's bad ist, that all bars are now framed with a black outline. this a nearly invisible change for those which prefer 3D bars, but a worsening for the flatties.

could it be handled that way, that only the A4AF (white) bars are outlined, while the others, which have a fill color different to white, are not?

additional suggestion, as i'm currently frequently stumbling over this:
is it possible to include the asked-for file in the message, like: A4AF: just_this_file.zip

and, just because i'm requesting improvements  :D could there be a context menu item added for A4AF sources to pull this source to this file? This would be great.

... m2kio !

and i herewith do another pledge to swap green and black in the peers' progress bars. black is what i have. green is 'available to transfer'. As in the overall file progress bar: black is what i have, bluish what is 'available to transfer'.
Title: Re: [2005-02-11] white bars on A4AF
Post by: Kry on April 04, 2005, 03:49:19 PM
Quote
Originally posted by m2kio
i just compiled and restarted cvs-20050404 with this modification.
actually this is a visual worsening for me, as i use flat progress bars.

What's bad ist, that all bars are now framed with a black outline. this a nearly invisible change for those which prefer 3D bars, but a worsening for the flatties.

Maybe do it just for 3d-bar users?



Quote
Originally posted by m2kio
additional suggestion, as i'm currently frequently stumbling over this:
is it possible to include the asked-for file in the message, like: A4AF: just_this_file.zip

That's already done, m2kio :P

Quote
Originally posted by m2kio
and, just because i'm requesting improvements  :D could there be a context menu item added for A4AF sources to pull this source to this file? This would be great.

You have the Swap Every A4AF to this file option.


BTW m2kio, did you take a look at your PM? Can you join IRC?
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 04, 2005, 03:56:07 PM
Quote
Originally posted by Kry
Quote
Originally posted by m2kio
i just compiled and restarted cvs-20050404 with this modification.
actually this is a visual worsening for me, as i use flat progress bars.

What's bad ist, that all bars are now framed with a black outline. this a nearly invisible change for those which prefer 3D bars, but a worsening for the flatties.

Maybe do it just for 3d-bar users?

Yeah, that sounds like the best solution. I'll add it when I get home, since I also want to test a few other possible tweaks to the drawing.
Title: Re: [2005-02-11] white bars on A4AF
Post by: Kry on April 04, 2005, 04:44:36 PM
I'm full of good ideas, huh?
Title: Re: [2005-02-11] white bars on A4AF
Post by: Xaignar on April 04, 2005, 07:24:50 PM
Done:

EDIT: I slightly messed up here, the sources are not drawn flat (due to a false that should have been a true), but close enough anyway. *shrugs*
Title: Re: [2005-02-11] white bars on A4AF
Post by: GhePeU on April 07, 2005, 08:23:09 PM
Quote
Originally posted by Xaignar
Done:

EDIT: I slightly messed up here, the sources are not drawn flat (due to a false that should have been a true), but close enough anyway. *shrugs*

well, it's just personal taste but I'd remove the black lines from 3d bars too, except the white one where it divides white bar from white background... imho it doesn't match very well with light colors (green, light blue, red, yellow, light grey)

I've got another proposal: could the label "A4AF" appear only when percentages are enabled?
Title: Re: [2005-02-11] white bars on A4AF
Post by: GhePeU on April 07, 2005, 09:10:48 PM
maybe my first idea was wrong. I was thinking about this, and the problem with full white bar is that it breaks UI consistency: a white bar doesn't distinguish itself from background, and, most important, while all bars are flat or 3D depending on user setting in preferences, a white bar is always flat. maybe the best solution is choose a new color for A4AF, possibly a light color (dark color is related to reliable and significant informations)
Title: Re: [2005-02-11] white bars on A4AF
Post by: m2kio on April 07, 2005, 09:31:56 PM
i'm using flat bars and for this i feel it is good as it is now. maybe the border for A4AF is an odd man out, but A4AF is an odd man out anyway. ;)