aMule Forum

English => en_Bugs => Topic started by: KyroMaster on October 11, 2005, 07:03:13 PM

Title: Category list in Settings dialog too small
Post by: KyroMaster on October 11, 2005, 07:03:13 PM
The attached screenshot shows how the preferences dialog looks like on my system. The categories selectors height is way too small.
Title: Re: Category list in Settings dialog too small
Post by: Kry on October 12, 2005, 05:31:06 AM
That's why there is a scrollbar I guess
Title: Re: Category list in Settings dialog too small
Post by: stefanero on October 12, 2005, 09:44:03 AM
KyroMaster it does not make sence to increase the size here, since you can change the font and the size

the size of hte prefs is fixed and not depended on the font, so some people have the scrollbar some not, depended on font/size
Title: Re: Category list in Settings dialog too small
Post by: KyroMaster on October 12, 2005, 04:34:26 PM
Sorry, I don´t quite understand your explanation :(
The box could be increased in height so there would be no scrollbar and the contents would fir in the window. IMHO this is better than using only half of the window height but showing a scrollbar.
Title: Re: Category list in Settings dialog too small
Post by: stefanero on October 13, 2005, 01:22:38 PM
well but if you change your font size for example it would fit right away....
Title: Re: Category list in Settings dialog too small
Post by: lfroen on October 14, 2005, 06:51:56 AM
What stefanero mean, that your (KyroMaster) fonts are too big. It doesn't matter thou how big this list will be - you always can define even bigger font which will result in scrollbars.
Title: Re: Category list in Settings dialog too small
Post by: Vollstrecker on October 14, 2005, 07:11:06 AM
Why not ignoring font settings for the ctegories, too?
Title: Re: Category list in Settings dialog too small
Post by: KyroMaster on October 14, 2005, 11:34:24 AM
Sorry for these dumb questions, but what has the font size to do with the size of the control? I program with wxWidgets myself, and AFAIK the font size is defined in my GTK2 environment. So when the control would be highter, the font size would be the same, so the scrollbars would disappear.
Title: Re: Category list in Settings dialog too small
Post by: Vollstrecker on October 14, 2005, 01:11:15 PM
When you use a bigger fontsize than the one that coded the control, you get the scrollbars. If he uses a bigger one, you have many free space in there.
In short, if the font is bigger, it needs more space for the same text.
Title: Re: Category list in Settings dialog too small
Post by: lfroen on October 14, 2005, 04:09:20 PM
KyroMaster: sorry, but if you program with wxWidgets (or whatever gui toolkit) that your question is really dumb.
Yes, font is defined in your environment, but size of control is hardcoded. So, unless special measures taken in code to resize control according to your font size - bigger font will not fit and you will get scrollbars.
Title: Re: Category list in Settings dialog too small
Post by: KyroMaster on October 15, 2005, 12:18:44 AM
Quote
Originally posted by lfroen
KyroMaster: sorry, but if you program with wxWidgets (or whatever gui toolkit) that your question is really dumb.
Yes, font is defined in your environment, but size of control is hardcoded. So, unless special measures taken in code to resize control according to your font size - bigger font will not fit and you will get scrollbars.

What I´d do in wxWidgets is to put the control into a sizer so that its height is always the height of the window minus the size of the buttons (I don´t know how the sizers are used actually in your preferences window). So if I have a too big font or a too little window I´ll get the scrollbars.
IMHO that´s not dumb  :P
Title: Re: Category list in Settings dialog too small
Post by: Kry on October 15, 2005, 08:40:27 AM
But it looks awful with all that space wasted on the list ctrl.
Title: Re: Category list in Settings dialog too small
Post by: phoenix on October 15, 2005, 05:45:08 PM
Well, in fact I think KyroMaster does have a point. And so does Kry.

This is from the time before I entered aMule team, so Kry, why is this dialog coded with a list control? Couldn't we use a tabbed control there, like a notebook? There would be no wated space on the left and the interface would be cleaner, IMHO.

Cheers!
Title: Re: Category list in Settings dialog too small
Post by: KyroMaster on October 15, 2005, 05:52:57 PM
Quote
Originally posted by Kry
But it looks awful with all that space wasted on the list ctrl.
What about making it as tall so that the contents fit in. And if the contents are too tall then just use the maximum size so the control will get scrollbars.
Title: Re: Category list in Settings dialog too small
Post by: Kry on October 15, 2005, 06:33:53 PM
Kyro has of course a point and a ptch will be wellcomed :P

phoenix: don't get me started on vertical tabs and wxMac.
Title: Re: Category list in Settings dialog too small
Post by: phoenix on October 15, 2005, 07:02:00 PM
Quote
Originally posted by Kry
Kyro has of course a point and a ptch will be wellcomed :P

phoenix: don't get me started on vertical tabs and wxMac.
I did not say vertical :) The dialog window is detached from the main app window, horizontal tabs should be ok.
Title: Re: Category list in Settings dialog too small
Post by: Kry on October 15, 2005, 08:37:47 PM
Horizontal tabs have scroll arrows and sucks hard. And have no nice icons.
Title: Re: Category list in Settings dialog too small
Post by: phoenix on October 15, 2005, 08:50:01 PM
Yeah, they have no icons, but I can live without them, remember, I don't have a Mac, I use console and vi :P

Seriously, it would me much more functional. That wasted space on the left side has always bogged me.

KyroMaster, if you can provide a patch to the gui that makes the listctrl resize with the window, i think it will be acceptable.

Cheers!
Title: Re: Category list in Settings dialog too small
Post by: lionel77 on October 15, 2005, 09:02:20 PM
Personally, I think there are too many categories for horizontal tabs -- either you only show half of them at a time and people have to scroll constantly, or you put them in two or three rows and then we have almost reached MS Word standards in terms of clutter and confusion.

Plus, as a Mac user, I insist on the icons... ;)
Title: Re: Category list in Settings dialog too small
Post by: phoenix on October 15, 2005, 09:12:12 PM
lionel77, I would not expect otherwise from a Mac user :D

But seriously, what is worst? An horizontal tab with many rows or the way it is now, wasting precious space on the screen? I am really not sure, The icons today are not that good in giving you a clue of what you will configure. Does anyone know of a notebook control with icons? :)

Cheers!
Title: Re: Category list in Settings dialog too small
Post by: KyroMaster on October 15, 2005, 11:02:37 PM
Ok, I think I´ll have a look at the code and perhaps then I post some "nice UI" patches.  :D
Title: Re: Category list in Settings dialog too small
Post by: GonoszTopi on October 15, 2005, 11:37:36 PM
Quote
Does anyone know of a notebook control with icons?
wxNotebook 8)

Anyway, I'm against turning the list into tabs.
Title: Re: Category list in Settings dialog too small
Post by: lionel77 on October 16, 2005, 01:23:09 AM
Quote
Originally posted by phoenix
But seriously, what is worst? An horizontal tab with many rows or the way it is now, wasting precious space on the screen? I am really not sure, The icons today are not that good in giving you a clue of what you will configure.
I really think multiple tab rows are an abomination -- even the Mac business unit at Microsoft has realized this and stopped using them a number of years ago. ;)

Also, I don't think "waste of space" is such a huge issue, because most dialog windows in the prefs are still half empty or at least not very crowded.

Concerning the icons, even if some of them don't help you much initially, you will soon associate them with the proper category, enabling you to find it faster in the future.
Icons are simply much faster to process than text. :)