aMule Forum

English => en_Bugs => Topic started by: Mig21 on January 12, 2006, 04:31:09 AM

Title: 'Max size ignored.'
Post by: Mig21 on January 12, 2006, 04:31:09 AM

hello

when entering a min size in the extended search options i get this popup:

Quote

Min size must be smaller than max size. Max size ignored.

this didn't happen before and i don't think it was put there intentionally

cheers

Title: Re: 'Max size ignored.'
Post by: Kry on January 12, 2006, 04:44:53 AM

Isn't it a too acurate message to be unintentional?

Title: Re: 'Max size ignored.'
Post by: Mig21 on January 12, 2006, 01:04:19 PM

i don't think any user (certainly not me) wants that. wy not have a second popup because the availability was not specified? in fact, a popup with all the information in that form would be in order :)

i mean, if it goes in the log/status bar i don't really care but this popup is getting in my way for absolutely no good reason.

Title: Re: 'Max size ignored.'
Post by: Xaignar on January 12, 2006, 01:07:37 PM

This has been fixed on CVS. The problem is that it only compares min < max, which triggers if a max value hasn't been specified (max == 0). A workaround would be to set max to the highest posible value.

Title: Re: 'Max size ignored.'
Post by: Kry on January 12, 2006, 07:02:26 PM

Nah, not the highest value - would interfere with the search params. The workaround is of course ok.

Title: Re: 'Max size ignored.'
Post by: lfroen on January 13, 2006, 03:55:11 PM

This is very confusing message. Xaignar: when max size == 0 this mean "any size" so error message is out of place.
Workaround is ok, but this is bug and should be fixed.

Title: Re: 'Max size ignored.'
Post by: Xaignar on January 13, 2006, 04:51:34 PM

This has been fixed in both the trunk and the 2.1.x branch.
See r6325:

Code: [Select]

- if ( max < min ) {
+ if ((max < min) and max) {