aMule Forum

English => Skins & GUI => Topic started by: iwkse on May 21, 2010, 10:53:05 AM

Title: Theming wxListCtrl
Post by: iwkse on May 21, 2010, 10:53:05 AM
Hi, i'm using amule under linux and with the current GTK+ theme there's a visibility issue with the wxListCtrl in the Tranfers page.
Since the foreground text color is white and the background item color is light grey, it becomes hard to read the text while selecting the list item.
There's a way to theme it and change the color within gtkrc?
Title: Re: Theming wxListCtrl
Post by: Stu Redman on May 21, 2010, 04:04:09 PM
You are using 2.2.6?
This should be fixed in the SVN version.
Title: Re: Theming wxListCtrl
Post by: Kry on May 21, 2010, 06:02:42 PM
That was my fix, wasn't it? We should probably backport it as a patch and post it somewhere.
Title: Re: Theming wxListCtrl
Post by: Stu Redman on May 21, 2010, 06:27:13 PM
Better get 2.3 released. There are more pressing issues than light text in strange themes.
Title: Re: Theming wxListCtrl
Post by: iwkse on May 21, 2010, 07:28:34 PM
I'm using 2.2.1 it's what i have in debian stable.
I'll try the backport to see if fixes it.
thanks

ps. the strange theme is murrine  neographite :p
Title: Re: Theming wxListCtrl
Post by: GonoszTopi on May 25, 2010, 12:04:52 AM
That was my fix, wasn't it? We should probably backport it as a patch and post it somewhere.
Quite an easy one: http://repo.or.cz/w/amule.git/commitdiff/f5414771ba0da3e2f3811e3664ac1383d904f430

"Backported":
Code: [Select]
Index: src/extern/wxWidgets/listctrl.cpp
===================================================================
--- src/extern/wxWidgets/listctrl.cpp   (revision 10182)
+++ src/extern/wxWidgets/listctrl.cpp   (working copy)
@@ -5784,7 +5784,7 @@
 #else
     wxUnusedVar(variant);
     wxVisualAttributes attr;
-    attr.colFg = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
+    attr.colFg = wxSystemSettings::GetColour(wxSYS_COLOUR_LISTBOXTEXT);
     attr.colBg = wxSystemSettings::GetColour(wxSYS_COLOUR_LISTBOX);
     attr.font  = wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT);
     return attr;
Title: Re: Theming wxListCtrl
Post by: iwkse on May 25, 2010, 08:34:35 AM
This patch requires a newer wxWidgets which isn't available in debian stable.

http://trac.wxwidgets.org/ticket/10089

I fixed it changing the background colour to wxSYS_COLOUR_BTNSHADOW
Title: Re: Theming wxListCtrl
Post by: Vollstrecker on May 25, 2010, 11:00:29 AM
In my repo is a new enough wx-version that is tested to not make any problems on upgrading to the next stable.
Title: Re: Theming wxListCtrl
Post by: iwkse on May 25, 2010, 11:10:17 AM
Yeah, unluckily i couldn't use your cool repository because i'm on AMD64.
Do you plan to release amd64 packages too? :-)

cheers
Title: Re: Theming wxListCtrl
Post by: Vollstrecker on May 25, 2010, 12:21:20 PM
Only when someone donates the pkg's. I host everything usefull I get, but I don't fiddle around with crosscompiling. If you want to help, I can give you the needed instructions.
Title: Re: Theming wxListCtrl
Post by: iwkse on May 25, 2010, 01:32:40 PM
Okey, tell me how to do and i'll try these days to build amd64 packages.
Title: Re: Theming wxListCtrl
Post by: Vollstrecker on May 26, 2010, 10:18:00 AM
It's not that hard. Just take the diff.gz and orig.tar.gz from my repo, and save them in a folder. Then you call dpkg-source -x <diff-file>, remove the .diff-file, go into the newly created dir, open debian/changelog and put an entry on top of it, with a new version number (-2 or something). You can copy the last entry for keeping the right format. Then just run "dpkg-buildpackage -us -uc -rfakeroot" (if you want to sign them yourself, omit -uc -uk, and set -k<key_id>". When all went fine, sent me the new.diff, .changes and the debs.
Title: Re: Theming wxListCtrl
Post by: iwkse on May 26, 2010, 12:14:28 PM
Ok, i'm building the packages, i'll post the links in here when they are ready.

thanks
ps. Beside amule i need to package also wxwidgets because of dependencies
Title: Re: Theming wxListCtrl
Post by: Vollstrecker on May 26, 2010, 05:31:41 PM
I thought you're talking about wx, but they work both the same way.
Title: Re: Theming wxListCtrl
Post by: iwkse on May 26, 2010, 05:33:56 PM
Most of the work is done ;)

Here you get wxwidgets as first, i'll add amule on next post as it finishes.

http://iwkse.homeunix.org/pkg/wxwidgets/wxwidgets2.8_2.8.10.1-1.2.diff.gz (http://iwkse.homeunix.org/pkg/wxwidgets/wxwidgets2.8_2.8.10.1-1.2.diff.gz)
http://iwkse.homeunix.org/pkg/wxwidgets/wxwidgets2.8_2.8.10.1-1.2_amd64.changes (http://iwkse.homeunix.org/pkg/wxwidgets/wxwidgets2.8_2.8.10.1-1.2_amd64.changes)

http://iwkse.homeunix.org/pkg/wxwidgets/libwxbase2.8-0_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/libwxbase2.8-0_2.8.10.1-1.2_amd64.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/libwxbase2.8-dbg_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/libwxbase2.8-dbg_2.8.10.1-1.2_amd64.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/libwxbase2.8-0-dev_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/libwxbase2.8-dev_2.8.10.1-1.2_amd64.deb)

http://iwkse.homeunix.org/pkg/wxwidgets/libwxgtk2.8-0_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/libwxgtk2.8-0_2.8.10.1-1.2_amd64.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/libwxgtk2.8-dbg_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/libwxgtk2.8-dbg_2.8.10.1-1.2_amd64.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/libwxgtk2.8-dev_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/libwxgtk2.8-dev_2.8.10.1-1.2_amd64.deb)

http://iwkse.homeunix.org/pkg/wxwidgets/python-wxgtk2.8_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/python-wxgtk2.8_2.8.10.1-1.2_amd64.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/python-wxgtk2.8-dbg_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/python-wxgtk2.8-dbg_2.8.10.1-1.2_amd64.deb)

http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-doc_2.8.10.1-1.2_all.deb (http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-doc_2.8.10.1-1.2_all.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-examples_2.8.10.1-1.2_all.deb (http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-examples_2.8.10.1-1.2_all.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-headers_2.8.10.1-1.2_amd64.deb (http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-headers_2.8.10.1-1.2_amd64.deb)
http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-i18n_2.8.10.1-1.2_all.deb (http://iwkse.homeunix.org/pkg/wxwidgets/wx2.8-i18n_2.8.10.1-1.2_all.deb)

I didn't test for dead links, but should be ok :)

Title: Re: Theming wxListCtrl
Post by: iwkse on May 26, 2010, 06:12:23 PM
here the amule tarball which includes all debs

http://iwkse.homeunix.org/pkg/amule/amule_2.2.6+svn-r10177_amd64.tar.gz (http://iwkse.homeunix.org/pkg/amule/amule_2.2.6+svn-r10177_amd64.tar.gz)

All debs  are also listed in here http://iwkse.homeunix.org/pkg/amule (http://iwkse.homeunix.org/pkg/amule)

I can regularly build amule packages for amd64, if you feel good with give me upload rights on the server it's ok, otherwise
we can  communicate with email and i'll upload on my server and so on.
Let me know :)

Sal
Title: Re: Theming wxListCtrl
Post by: Vollstrecker on May 26, 2010, 11:16:11 PM
Why don't you just create a repo? If you own a server, it no big problem.
Title: Re: Theming wxListCtrl
Post by: iwkse on May 26, 2010, 11:33:33 PM
I could but since you already package amule, while make another repository for amd stuff?
It would be better to have everything at one place i think and also my server is low bandwith one.
Title: Re: Theming wxListCtrl
Post by: Vollstrecker on May 27, 2010, 12:23:17 PM
I can't give you direct access to my ftp, because it can only handle one connection, and as my script runs completely unattended you could block my script, but I could create an email-address for you, that integrates the stuff you send into the repo. But I don't have time before 15.06. for this.
Title: Re: Theming wxListCtrl
Post by: iwkse on May 27, 2010, 01:35:47 PM
It's ok no problem.
If you think  it's easier for you (for a matter of time) you can give me the specifications and i'll write and send the script myself to allow auto include in the repository.
Otherwise we can just wait.