Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Seagull]

1) Open 2 files to show the sources of both.

2) order by Priority

3) the clients get mixed up.

 Doesnt seem to happen when ordering by name, at least.

 Best to try with files with few sources  

 Still present in cvs-20040923

[Xaignar]

Heh, the sorting of clients and files on the downloadlistctrl is quite a hack, so it doesn't supprise me that it's flaky. I'll try to see if I can fix it though.

[Xaignar]

Right, I've committed a fix for this. Part of the problem was that if was possible for files to be compared to being "equal", which would screw up the placement of sources afterwards.

[skolnick]

The same happens if you order downloads by progress. The downloads themselves get ordered, but the clients do not get ordered, just get in a "random" way. I would like them to be ordered in the same way as the progress (if descending, from most-obtained parts to less-obtained-parts, and vice-versa). Notice that the ordering does happen when you double-click a download, and then order, so it _is_ possible and already implemented how to do this ordering.

Thanks.

[Seagull]

Originally posted by skolnick
The same happens if you order downloads by progress. The downloads themselves get ordered, but the clients do not get ordered, just get in a "random" way. I would like them to be ordered in the same way as the progress (if descending, from most-obtained parts to less-obtained-parts, and vice-versa). Notice that the ordering does happen when you double-click a download, and then order, so it _is_ possible and already implemented how to do this ordering.

Diferent problem.

What happens there is that sources arent sorted when the file is "opened", so appear unsorted.

There is a simple patch to this particular problem (sort when file "opens", in rc6 is even easier with the restructure of that section of code) but thats just the tip of the problem: the sorting isnt updated with most of the actions.

That makes everything unsorted after some time if you dont manually trigger the actions that do sort (change tab/click column and a few others).

[Xaignar]

Yes, that's one of the main problems with the current download list. The reason is that we do all drawing of the items ourselves, and therefore use the _current_ values in the drawing, with the result that it gets very hard to ensure that the list is always sorted. We'll probably have to do some caching of the values and trigger events upon updating them. Fixing this is definetly something that I want to do.