aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: Syncronize with eMule's GUI  (Read 23732 times)

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Syncronize with eMule's GUI
« on: July 08, 2008, 10:52:12 AM »

I have tried eMule on a Mac with Crossover and I am shocked. Even though it takes a while to start, it feels really snappy and pleasant to use. For example the Preferences window opens with no delay compared to aMule on a mac. The preferences have similar organization as in aMule but in several cases there are improvements, and also the associated text is more enlightening! The main application window is even better organized and although it has pretty much the same elements, it looks less cluttered and substantially more elegant.

* There are two separate tabs, one for Kad and one for eD2k, instead of a single big Kad/eD2k window!
* In the servers window the "add server" and server list in a in the side along with eD2K info
* same for the Kad window, which also features a small relatively elegant graph.
* The shared files window has an embedded directory browser.
* In the statistics window the statistics tree convers the full height of the window instead of the low right corner and the graphs are smaller.
* The search window has all the filtering text input filles together (in the form of a list) so they don't look messy.
*etc

So I am wondering, those things can be easily incorporated to aMule and they can vastly improve its looks and also bring it in sync with eMule.
Why not do them? In fact I think that I can do them, but then it would be very difficult for someone to check the differences due to the binary format of the wdr files...
How can I (we) contribute to the reorganization of the gui to make it look better by (at least) syncing it with eMule?
Logged

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Re: Syncronize with eMule's GUI
« Reply #1 on: July 08, 2008, 12:18:09 PM »

For example:
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Syncronize with eMule's GUI
« Reply #2 on: July 08, 2008, 12:33:14 PM »

I agree that's a good solution, because most people have more horizontal space screen than vertical. Also, moving ed2k/kad info from the tab interface to the respective network view would be another thing one should consider.
Logged

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Re: Syncronize with eMule's GUI
« Reply #3 on: July 08, 2008, 12:51:08 PM »

Here is what I have so far. I only edited the muuli.wdr file. Should I attach this too or it does not matter because its binary?

Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Syncronize with eMule's GUI
« Reply #4 on: July 08, 2008, 02:06:24 PM »

OK, please send me the file (or attach it in the forums) and give me a log of the changes.

Please create one file with the kad/ed2k changes and one with all the changes.

I'll review it and commit it if there are no problems. Thanks a lot for your contributions! (I'll answer your PM asap, too, sorry it's taking me so long.)
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Syncronize with eMule's GUI
« Reply #5 on: July 08, 2008, 02:58:18 PM »

Kad info and ED2K info are now duplicated in those screenshots. Unless anyone has a good idea about what to do with the sole two log tabs left after removing those for duplication, it's a no-no change.

Kad window: all the bootstrap/node options should be together, not have the info between them.

Server window: What the hell is Disconnect doing there? Also, the server list is a list, with plenty of columns people might want to see, and restricting the horizontal space for it is not a good idea (all IMHO) specially if it leaves a giant blank space because we can't even fit enough information in the right side.

Both Kad and server window: The URL fields are now too small to see the whole URL. This is a regression, especially with no scrollbars, because now to see the content of the url I ahve to move along it with the keyboard or slowly select it with the mouse.

Statistics window: I am torn in this one. I like the parts of the information that are more visual (graphs) to be predominant, and now the statistics graphs are too small in my opinion. OTOH, the statistics tree is bigger, and this not only adds readability to it but also will reduce CPU load from redrawing the graphics (as they are smaller now). The tree is a vertical item, so it taking a whole vertical space makes sense.

A different approach to the statistics window is adding a new "custom" graph that contains statistics of items selected from the tree, and that way having not only a whole vertical space for the tree, albeit smaller than yours, but also a new graph that cna show very useful information for the user (or just curiosities). This of course could be a implementation nightmare.


And remember: We're not an eMule clone.

« Last Edit: July 08, 2008, 03:00:30 PM by Kry »
Logged

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Re: Syncronize with eMule's GUI
« Reply #6 on: July 08, 2008, 09:43:24 PM »

Hello,
 
I agree with Kry that the eD2k and Kad windows are not ready. In fact I did not intend those as final, but merely as an idea. What needs to be done is to create a separate toolbar item for the eD2k and the Kad network. The Kad window will contain everything, that is in the screen shot (probably with minor rearrangements) apart from the bottom panel (aMule Log, Server Info ... etc). The eD2k window will contain everything in the screenshot apart from eD2k Info which is incorporated in the right and Kad Info (obviously). And of course both windows will miss the top tab switcher. This will simplify the interface by a few dialogs.

I don't think that restricting the vertical space is an issue, and I don't think the current implementation is better. Don't forget that the download window has 13 columns that people may want to see, but they never ever fit. I don't understand why there should be a different policy for this window.

For the statistics window, I do think that the statistics tree is too long to fit in its current position. I will go ahead (later) and submit only the changes to the statistics window. I am not sure what kind of change log file is necessary. I really don't want to go and write down details like, copy wxBoxSizer, select top wxBoxSizer, paste wxBoxSizer... And Kry, I don't really think that aMule is some kind of statistics platform!
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Syncronize with eMule's GUI
« Reply #7 on: July 08, 2008, 11:28:55 PM »

Sorry, but I don't like it very much:

Stats: DL Graph is too small. Why not move UL to the DL graph and keep just two graphs ? DL is just a straight line anyway, and with the red color it sticks out fine.

Kad: I move the sizer up to have a little KAD graph and a BIG log window. That's not possible with the new layout.

The bootstrap new node should be a button and open a dialog (it's rarely used).

The disconnect is weird (at least in KAD only mode). There's a button in the dialog, and one in the tool bar. Disconnecting with the dialog button changes neither button (now - what should I disconnect ?) Then hitting the dialog disconnect again has no effect. Hitting the toolbar "disconnect" however reconnects Kad.

Also, the toolbar disconnect sets the status line to "Kad: Off" (Users/Files stay however...). The dialog disconnect leaves a "Kad: connected".  :P

Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Re: Syncronize with eMule's GUI
« Reply #8 on: July 09, 2008, 12:42:57 PM »

Let me throw the following ideas:
1) What if the Kad, eD2k and aMule log are separate windows? I mean one has to click to a tab selector regardless of whether it is in the tool bar or inside some window.
2) Also how about making the "add server" and "add node" a button which opens a pop up (ala sturedman).
3) Why not move the nodes graph under the statistics window?
4) Can we merge the Server Info into aMule log?
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Syncronize with eMule's GUI
« Reply #9 on: July 09, 2008, 02:51:42 PM »

1) Don't clutter the toolbar, it already doesn't fit some screens as it is.

2) Works for me.

3) Because the Statistics window is overcrowded as it is, ebcause some people don't run kad, and because it's not the place it should be.

4) No.
Logged

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Re: Syncronize with eMule's GUI
« Reply #10 on: July 09, 2008, 10:44:05 PM »

Hmmm ok, then

Kry:
1) What if we introduce a traditional File, Edit, View, Help menu? For example the Import part file naturally fits under the File menu, many little gui tweaks go under the view menu, about goes under the Help menu etc. That would de-clutter both the Preferences and the toolbar.
I will just take your answer for 2,3,4.
TODO: replace add server/node with button.

sturedman:
* Which elements of the graphs are not visible in the suggested layout? Why do you think they are small? Also, do you suggest to merge the UL and DL graphs into one? How about the scale (right now I download at 3kb/s and upload at 50kb/s, which means that the DL curve would look tiny). Do you think that it would be better if the line widths of the plots became bigger?
Logged

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Re: Syncronize with eMule's GUI
« Reply #11 on: July 09, 2008, 11:20:41 PM »

Let me try to brainwash some more about the statistics window.
I think it is better if it is broken down in the following tabs:

* Transfer: It contains the UL/DL information in the form of a table (to avoid repeated strings) and also the UL/DL graphs.
* Connection: It will contain the connection information organized in some reasonable way and also the connection graph.
* Clients: client information. I suggest using the corresponding application icons and under them a percentage
* Servers: some server information
* Shared files: move the statistics part of the "shared files" window here.

I think the above can be implemented relatively easily. I think there is this wxNotebook (or something) widget which can be on top of the statistics window. Then 5 dialogs need to be created which will contain the information. A lot can be done with drag and drop, but some programming is required to populate the textual part of the dialogs, but this should be manageable.
I could suggest some fancier stuff like create a pie chart to represent the clients, but I think this is too much work.

That will decluter the shared files window.
Logged

greek

  • Full Member
  • ***
  • Karma: 2
  • Offline Offline
  • Posts: 128
Re: Syncronize with eMule's GUI
« Reply #12 on: July 09, 2008, 11:37:10 PM »

And some ideas (for future reference, as always :)) for the shared files window.

It is a very good idea to show not only the shared files but also a list of the directories that are being shared.
As a first temporary step the same directory browser that appears under Preferences->Directories can be moved there. However this browser is ugly, hard to use. and it does not look particularly native to any operating system.
Therefore as a second step a list of directory names can be used. Below the list there will be a small "+" and "-" for "add" and "remove" respectively. The "+" will open a native filebrowser. Each item in the list will have two little check boxes: one for recursive sharing and another for hidden files. For every change in this list the shared files list will be updated.
Finally it would be nice if the shared file list could auto-update. Somehow it needs to be notified when directory contents change. I don't know if there is any multiplatform way to do this...

Comments?
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Syncronize with eMule's GUI
« Reply #13 on: July 10, 2008, 12:10:46 AM »

I could suggest some fancier stuff like create a pie chart to represent the clients, but I think this is too much work.

"Too much" always depends on how much the programmer wants it....
By the way, it could look nice, but I think it's kinda pointless, since always almost percentage for eMule is over 90%.

Finally it would be nice if the shared file list could auto-update. Somehow it needs to be notified when directory contents change. I don't know if there is any multiplatform way to do this...

No, at least not that I know of. Even in Linux there isn't a way that works in all distros/kernels/libcs, not to speak of MSW and MacOSX.
Logged
concordia cum veritate

lfroen

  • Guest
Re: Syncronize with eMule's GUI
« Reply #14 on: July 10, 2008, 09:45:20 AM »

Finally it would be nice if the shared file list could auto-update. Somehow it needs to be notified when directory contents change. I don't know if there is any multiplatform way to do this...

No, at least not that I know of. Even in Linux there isn't a way that works in all distros/kernels/libcs, not to speak of MSW and MacOSX.

Yes there is. In Linux and OSX for sure, and Win32 has "directory change notification" for ages.
Logged
Pages: [1] 2