Hi all,
At the end, I've take the time to perform a test on a strange thing about known files. These are the steps I've done:
1. update amule* to CVS-20060504
2. run amuled and look for a file already shared (and thus known); call it FILE1
3. shutdown amuled, move FILE1 to an un-shared dir
4. run amuled
5. shutdown amuled, move FILE1 back in its old dir (from where it was moved away)
6. run amuled
RESULT => everything as before moving (all infos are the same, as transfered bytes, etc.)
7. shutdown amuled, move FILE1 again away, run amuled, shutdown amuled
8. move FILE1 in another _shared_ dir
9. run amuled
RESULT => everything as before moving (all infos are the same, as transfered bytes, etc.)
10. execute 7. again
11. move FILE1 back in its old dir (from where it was moved away) and _rename_ FILE1 to FILE2
12. run amuled
RESULT => rehash of FILE2 and it's seen as a completly new file, never known (*THAT'S NOT RIGHT*)
13. execute 7. again (but for FILE2)
14. take another file, FILE3, and _rename_ FILE3 to FILE4 but in another dir
15. run amuled
RESULT => rehash of FILE4 and it's seen as a completly new file, never known (*THAT'S NOT RIGHT*)
16. execute 7. again (but for FILE4)
17. take another file, FILE5, and _rename_ FILE5 to FILE6 but in the same dir
18. run amuled
RESULT => rehash of FILE6 and it's seen as a completly new file, never known (*THAT'S NOT RIGHT*)
19. execute 7. again (but for FILE6)
20. _Rename_ back FILE6 to FILE5
21. run amuled
RESULT => recognized as FILE5 of before (all its old infos are there, like transfered bytes)
Conclusions: known files are identified by filename, and not by filehash: after rehashing a file, even with different names, new file should be associated to the old one, keeping the old infos. I think this is not right, isn't it?
Another thing: when a file comes under a shared dir, it should be inserted in some registry (I think known2.met or known2_64.met) and keep it there until the end of time... it happens, at the contrary, that a file in a shared dir is listed in green in SEarch window; when the file is removed from that dir, it is not marked in any fashion. I think it's better to implement a sort of "already-downloaded/seen" visualization and notification, what about?
Thanks for yor attention
