aMule Forum

English => Feature requests => Topic started by: FreeToGo on May 01, 2007, 07:37:18 PM

Title: Add extension icon next to filename like azureus does
Post by: FreeToGo on May 01, 2007, 07:37:18 PM
Shall extension icon be added next to filename like azureus does?

Extension icons can be downloaded at
http://www.famfamfam.com/lab/icons/mini/famfamfam_mini_icons.zip
or
http://www.famfamfam.com/lab/icons/silk/famfamfam_silk_icons_v013.zip

Some useful icons were extracted from above and attached below (extIcons.tar.bz2)
Title: Re: Add extension icon next to filename like azureus does
Post by: lfroen on May 02, 2007, 09:50:40 AM
I have only 1 question about this feature: "WHY"? You don't know what are you downloading? Moreover, aMule already have icon there - for file rating. Sticking 2 icons one after another is particularly bad idea.
Title: Re: Add extension icon next to filename like azureus does
Post by: FreeToGo on May 02, 2007, 11:02:35 AM
Why? I don't know. Somewhat like asking me why Nautilus has thumbnail next to filename or asking why people install Beryl.  Maybe it makes the application look better or maybe simply because we are used to it.

Put it the other way round. Will there be anyone posting a new topic requiring azureus to reduce the amount of fancy artworks and icons so as to make the already very sluggish java application run faster.  If such fanciness doesn't kill a java application, a c++ application should feel very comfortable to accomodate it.


I have only 1 question about this feature: "WHY"? You don't know what are you downloading? Moreover, aMule already have icon there - for file rating. Sticking 2 icons one after another is particularly bad idea.
Title: Re: Add extension icon next to filename like azureus does
Post by: Kry on May 02, 2007, 11:34:14 AM
Put it the other way round. Will there be anyone posting a new topic requiring azureus to reduce the amount of fancy artworks and icons so as to make the already very sluggish java application run faster.  If such fanciness don't kill a java application, a c++ application should feel very comfortable to accomodate it.

I would. That's the reason I don't use Azureus or other bloated apps.
Title: Re: Add extension icon next to filename like azureus does
Post by: lfroen on May 02, 2007, 01:37:07 PM
It's nice that you attached such image, so now we both can see why it's such bad idea. Can you tell which of icons means type and which "status" (or whatever it means in azureus)? You can't before you look to column headers, which named H and S (WTF that means?!).

People use icons in Gnome and beryl for a reason, and the reason is "usability". This particular icon in this particular place lacks this reason.
Title: Re: Add extension icon next to filename like azureus does
Post by: phoenix on May 02, 2007, 02:27:16 PM
It could be easily found by streching the column. And columns can be enabled/disabled at the users will. I see no problem in providing this as an option.
Title: Re: Add extension icon next to filename like azureus does
Post by: lfroen on May 02, 2007, 05:05:13 PM
Quote
I see no problem in providing this as an option
That's where you wrong. "Option" means that you (as a designer) have no idea and passing responsibility to user side.
IMHO: this option add no usability and just clobber interface.
Title: Re: Add extension icon next to filename like azureus does
Post by: Kry on May 02, 2007, 05:51:29 PM
People likes nifty stuff. I say the same as ip2country: disabled by default I have no problem with it.
Title: Re: Add extension icon next to filename like azureus does
Post by: phoenix on May 03, 2007, 05:44:31 AM
Quote
I see no problem in providing this as an option
That's where you wrong. "Option" means that you (as a designer) have no idea and passing responsibility to user side.
IMHO: this option add no usability and just clobber interface.
Well, I personally can recognize the file type much faster by the image than by scrolling a big file name that usually does not fit the column width. Yes, it is more useble in my opinion. And as an option, I mean, the user enables this if he wishes to do so. I still do not see where I am wrong, I even fail to understand how this word even logically applies to my statement.

If this "feature" is disabled, the overhead is minimal, we have much worst cpu intensive options in the preferences box. If the image is in a separate column, the application just looks the same, so, no clobber if you don't want.

I also think that disabled is a good default, it is just another nice feature to have if you want to.

Remember, this section is called "feature requests". And its not like he is asking for webcache.

I'm just waiting for Kry to add one column :)
Title: Re: Add extension icon next to filename like azureus does
Post by: Vollstrecker on May 03, 2007, 08:18:59 AM
With a column I like this better. In that case the User can enable and disable it like he wants (a not shown column is like disabled at compiletime). This way the distros don't have to decide for the users.
Title: Re: Add extension icon next to filename like azureus does
Post by: skolnick on May 03, 2007, 09:46:29 PM
The only issue I see with this option is that icons should be included by aMule itself, like the flags of IP2C, since you cannot count on GNOME or KDE or "X" window manager being installed (contrary to windows). Which icons would then be used?

Regards.
Title: Re: Add extension icon next to filename like azureus does
Post by: phoenix on May 04, 2007, 04:53:30 PM
With a column I like this better. In that case the User can enable and disable it like he wants (a not shown column is like disabled at compiletime). This way the distros don't have to decide for the users.
I am waiting for Kry to show me how he wants the column conversion code to keep compatibility with older versions. As soon as he does it, I will put several things on other columns, where they belong, e.g.: flag, country code, country name, part file number, etc.

skolnick,

As for the icons, we would do exactly the same thing as we did with the country flags: convert them to XPM and add them to the code.

Cheers!
Title: Re: Add extension icon next to filename like azureus does
Post by: skolnick on May 04, 2007, 10:35:52 PM
Yep, I really like the idea of adding more columns for everything. That way, things can be hidden or shown according to user's preferences. And I also like the icons being in XPM just like the flags, but which icons would be used? the ones suggested by FreeToGo? (I like them, just curious ;) )

Regards.
Title: Re: Add extension icon next to filename like azureus does
Post by: phoenix on May 05, 2007, 05:11:01 AM
Well, the icons he suggested could be a start for sure. Any free stuff is candidate, suggestions are welcome.

Cheers!
Title: Re: Add extension icon next to filename like azureus does
Post by: lfroen on May 06, 2007, 11:49:16 AM
IMHO match more useful is to have such icons on shared files list, and not on downloads.
Also, icons must not be hardcoded, but extracted from shell in run-time.
Title: Re: Add extension icon next to filename like azureus does
Post by: Kry on May 06, 2007, 03:13:38 PM
... w00t?
Title: Re: Add extension icon next to filename like azureus does
Post by: skolnick on May 06, 2007, 05:19:07 PM
lfroen, you cannot always extract icons from the shell. For example, my solaris box runs CDE, it has no other window manager...how do you extract CDE's icons? and what about fluxbox? enlightenment? windowmaker, etc? dont' think only about GNOME and KDE please. Using embbeded icons would be fine for me :)

Regards.
Title: Re: Add extension icon next to filename like azureus does
Post by: phoenix on May 07, 2007, 04:33:39 AM
IMHO match more useful is to have such icons on shared files list, and not on downloads.
Well, it is probably a matter of personal taste, I rarely use the shared folder tab. Why not have it in both places?

Also, icons must not be hardcoded, but extracted from shell in run-time.
I agree, but how can we do that? Remember we are supposed to be platform independent, so assuming things here like gtk+ is not an option. Anyway, just my curiosity, do you have a code example that does it?

Cheers!
Title: Re: Add extension icon next to filename like azureus does
Post by: skolnick on May 07, 2007, 04:53:07 AM
Maybe use a code similar to the aMule skins for these icons? a skin could even be extended to include these icons, perhaps...I would like that option. That way, lfroen would be kindda happy (no hardcoded icons), but the app would not relay on some software being present to extract the icons.

Regards.
Title: Re: Add extension icon next to filename like azureus does
Post by: phoenix on May 07, 2007, 06:09:21 AM
skolnick,

Treviño is working on a patch that could fit your suggestion: http://forum.amule.org/index.php?topic=12588

He is centralizing the replicated code, so it would be easier to implement what you said.

Cheers!
Title: Re: Add extension icon next to filename like azureus does
Post by: lfroen on May 07, 2007, 04:40:31 PM
Also, icons must not be hardcoded, but extracted from shell in run-time.
I agree, but how can we do that? Remember we are supposed to be platform independent, so assuming things here like gtk+ is not an option. Anyway, just my curiosity, do you have a code example that does it?
Cheers!

I have no idea how to do it, I just pointed out what functionality should it have. You see, if .avi have some particular icon in Nautilus/Konqueror/Explorer, aMule should show the same icon exactly, or it will be counter-productive (instead of suggesting file type by known icon it will confuse by unknown one).
Title: Re: Add extension icon next to filename like azureus does
Post by: phoenix on May 08, 2007, 04:48:51 AM
I have no idea how to do it, I just pointed out what functionality should it have. You see, if .avi have some particular icon in Nautilus/Konqueror/Explorer, aMule should show the same icon exactly, or it will be counter-productive (instead of suggesting file type by known icon it will confuse by unknown one).
I get your point and I agree. The system graphic shell should have a suggestion for the icon of a file. Have a look at this:

http://www.wxwidgets.org/manuals/stable/wx_wxmimetypesmanager.html

http://www.wxwidgets.org/manuals/stable/wx_wxfiletype.html#wxfiletypegeticon

Cheers!
Title: Re: Add extension icon next to filename like azureus does
Post by: Treviño on May 08, 2007, 05:20:39 AM
http://www.wxwidgets.org/manuals/stable/wx_wxfiletype.html#wxfiletypegeticon
Latest seems cool, maybe it would allow to satisfy every taste, since it will allow to support both native icons for KDE/GNOME/Mac/Windows users and other amule-defined pixmaps shared with the mule itself...
Title: Re: Add extension icon next to filename like azureus does
Post by: lfroen on May 08, 2007, 09:10:12 AM
lfroen, you cannot always extract icons from the shell.

Oh, really? Let me share little secret with you. User don't give a flying fsck how you do it. It's one of UI design guidelines - CONSISTENCY. K3B, for example, shows icons just fine. And so should aMule. As others pointed out, WX provide such support, so no reason it will not be used if such feature desired.

And regarding your appeal to different window managers - that's completely irrelevant. Major distribution targeting regular users use either KDE or Gnome or both. If you happens to run windowmaker, may be your don't need icons at all.
Title: Re: Add extension icon next to filename like azureus does
Post by: skolnick on May 09, 2007, 06:02:46 AM
lfroen, you cannot always extract icons from the shell.
Oh, really? Let me share little secret with you. User don't give a flying fsck how you do it. It's one of UI design guidelines - CONSISTENCY.
No need to be sarcastic. I am well aware of consistency as a good example of UI design. I was just pointing that there is no standard way of showing always the shell icons. I am pretty sure no library can do that, it's why I suggested using the icons embedded in the skin, or something like that. But since you seem to love consistency, then I want my CDE icons shown on aMule. I like them ;)
K3B, for example, shows icons just fine.
Terrible example, lfroen. K3b relies on KDE, and it will always show KDE's icons, no matter what. Consistency? tell that to a k3b user on GNOME. It will not show his favorite icons, but KDE ones.

And regarding your appeal to different window managers - that's completely irrelevant. Major distribution targeting regular users use either KDE or Gnome or both. If you happens to run windowmaker, may be your don't need icons at all.
OK, so now you tell me I have no freedom of choice. If I choose another window manager, then I should have no icons simply because you are not allowed to receive suggestions from anyone. Yours is the last word. It seems no fair, UNIX and linux is about freedom to choose. I should be able to get icons no matter what WM I use. However, you seem to care very little about people who thinks different from you (i.e: uses a non-bloated WM).

Regards.
Title: Re: Add extension icon next to filename like azureus does
Post by: lfroen on May 09, 2007, 08:37:08 AM
Quote
I was just pointing that there is no standard way of showing always the shell icons. I am pretty sure no library can do that,
As phoenix already told, Wx library can do it. Didn't check this personally thou.

Quote
I want my CDE icons shown on aMule.
And I want pony on my birthday. Both things have similar probability to happen. Does it mean that I have to throw away my dog too? No. I can't have a pony, but the dog stays. Same here: even if CDE isn't supported - it doesn't mean that Gnome should not be supported too.

Sarcasm aside: If CDE works with freedesktop's standards - you will have your icons.

Quote
OK, so now you tell me I have no freedom of choice.
No, what I actually tell you is that choice have price. Your choice of non-standard window manager may have a price of amule-without-pretty-icons (or hard-coded in skin icons, depends on implementation).

Quote
It seems no fair, UNIX and linux is about freedom to choose.
Yes. And no choice comes without price.

Quote
However, you seem to care very little about people who thinks different from you
Let's keep this discussion focused on actual issue (icons in amule). Now, it's not about "care" - it's about what should I fix/implement in very little time I have for amule. And I prefer to fix things that more people need.
Title: Re: Add extension icon next to filename like azureus does
Post by: skolnick on May 09, 2007, 03:34:17 PM
good lfroen, now your reply makes much more sense, so you are just using freedesktop's standards, it seems fair. I think that's what wx uses too. Unfortunately, as you say, CDE is older than freedesktop :P. I like the into-skin icons more tough...:D

Quote
it's about what should I fix/implement in very little time I have for amule. And I prefer to fix things that more people need.
I agree with you, lfroen. Then let's keep this icon stuff low-priority, at least while we have issues with big files (bigger than 4GB) on aMule. It seems in some places info is misreported (I've made some bug reports, and can help you testing if yu want to).

Regards.
Title: Re: Add extension icon next to filename like azureus does
Post by: Treviño on September 03, 2007, 06:58:13 PM
Has this thread stopped?

I've tested some latest version of FileZilla (it is writte in wxwidgets too) and supports many system Icons I've...  Is it using the wx feature suggested by phoenix (I've not had time to check)?

Btw, why has this "trashed"?
Title: Re: Add extension icon next to filename like azureus does
Post by: wuischke on September 03, 2007, 08:41:52 PM
Please create a bug report (http://bugs.amule.org), I'll have a look at it after the release of 2.2.0.