aMule Forum

English => Feature requests => Topic started by: xxlray on July 18, 2007, 08:16:14 PM

Title: remember all files ever canceled
Post by: xxlray on July 18, 2007, 08:16:14 PM

I monitor my downloads by previewing the downloaded parts. When I recognize the downloading file is not the one I wanted I cancel the download. Now I have to search again to find another file that could match my needs. It would be helpful if the canceled file would be marked so that I don't download it again.

Title: Re: remember all files ever canceled
Post by: skolnick on July 19, 2007, 03:39:20 AM

They are marked in red when appear in the search results.

Regards.

Title: Re: remember all files ever canceled
Post by: xxlray on July 19, 2007, 07:58:02 AM

As far as I know just files that are currently downlading are marked in red. But if you say so you will be right. I'll test it.

Title: Re: remember all files ever canceled
Post by: skolnick on July 19, 2007, 06:23:56 PM

And the downloaded files are highlighted in green, IIRC.

Regards.

Title: Re: remember all files ever canceled
Post by: xxlray on July 19, 2007, 07:19:26 PM

Quote from: skolnick on July 19, 2007, 06:23:56 PM

And the downloaded files are highlighted in green, IIRC.

Yes you are right
completed files are marked green
currently downloading files are marked red
But it seems that canceled files aren't marked although you said so.

I started the download of some very common files. After little time I canceled the downloads and searched again and no file was marked.

Title: Re: remember all files ever canceled
Post by: wuischke on July 19, 2007, 07:28:22 PM

I think there's currently no such feature, but it has been requested before. Please check the bug tracker and report a bug if you can't find something about it.

Title: Re: remember all files ever canceled
Post by: xxlray on July 19, 2007, 09:18:55 PM

Quote from: wuischke on July 19, 2007, 07:28:22 PM

I think there's currently no such feature, but it has been requested before. Please check the bug tracker and report a bug if you can't find something about it.

Sorry, but I don't understand what you mean. What am I supposed to check? I just wanted to ask for a feature. Where's the bug in it???

Title: Re: remember all files ever canceled
Post by: wuischke on July 19, 2007, 09:22:00 PM

It's just a matter of organisation. I lose track of feature request if they are in the forums, but I can assign things to myself and will eventually fix/write them if I see them in the bug tracker.

Title: Re: remember all files ever canceled
Post by: xxlray on July 19, 2007, 10:11:49 PM

done

Title: Re: remember all files ever canceled
Post by: wuischke on July 19, 2007, 10:15:08 PM

Um, actually I was talking about http://bugs.amule.org ;)

Title: Re: remember all files ever canceled
Post by: xxlray on July 19, 2007, 10:40:53 PM

I think now I really got it.

Title: Re: remember all files ever canceled
Post by: wuischke on July 21, 2007, 11:22:06 AM

Cancelled/Removed files are now marked grey in search results.

This will only work if the file has already been added to known.met, this might not be the case if you add a file and immediately remove it.

Title: Re: remember all files ever canceled
Post by: xxlray on July 21, 2007, 12:52:13 PM

ok - I will check this out

Title: Re: remember all files ever canceled
Post by: wuischke on July 21, 2007, 01:22:03 PM

Oh, then you will need the patch, as it will appear first in tomorrow's tarball.

Title: Re: remember all files ever canceled
Post by: xxlray on July 21, 2007, 01:57:49 PM

Do I also get ist by using apt? Or do I have to install this patch manually?

Title: Re: remember all files ever canceled
Post by: wuischke on July 22, 2007, 06:07:26 AM

I just realized that my patch does *not* solve the problem (and had an error in the implementation, but that's only secondary).

aMule already displayed all known files in green, even those which were cancelled. My code just changed the green color to grey and was meant to differ between files still being shared and removed files.

I'll try to have a look at it when I come back from work.

Title: Re: remember all files ever canceled
Post by: skolnick on July 22, 2007, 07:05:34 AM

But that will also show in gray the files I downloaded successfully but for some reason I took out of the incoming folder, doesn't it?

Regards.

Title: Re: remember all files ever canceled
Post by: wuischke on July 22, 2007, 03:06:52 PM

Yes, that's what I meant when I said cancelled/removed files in an earlier post.

To really resolve this problem are further changes needed, which I won't make before the release of 2.2.0.

Title: Re: remember all files ever canceled
Post by: ernestoI on December 30, 2009, 01:05:26 AM

I recently filed http://www.amule.org/abugs/view.php?id=1571 and was asked to make a forum post, I see there is already a thread concerning this so I'll just bump it. I'm wondering can be done about this. I'm unfamiliar with aMule's architecture, but I have a thorough understanding of C++, and the libraries that aMule appears to use, so perhaps if someone was willing to steer me in the right direction I could work on this myself.

Quote

Please start a thread in the forum to discuss the issue. It has been discussed before, but I can't remember the result right now.
To do this you have to store the hashes of the canceled files in a map, save it on shutdown and load it on startup (like the known files in known.met).

Could known.met be used? Where in the source should this be implemented?

Title: Re: remember all files ever canceled
Post by: Stu Redman on December 30, 2009, 01:24:47 PM

First we have to see if everybody agrees on the feature. Then implementation should not be a problem.
known.met should not be touched for reasons of compatibility, but the places where it's read/written are the same where canceled.met (to name it) has to be accessed.

Title: Re: remember all files ever canceled
Post by: Stu Redman on January 04, 2010, 12:06:15 AM

Got it running (at least without EC).
When should the "canceled" status be reset? When the file is downloaded again, or only when it completes download?

Title: Re: remember all files ever canceled
Post by: Vollstrecker on January 04, 2010, 11:48:24 AM

When it get's downloaded again. So it has either downloading/finished or cancelled instead of downloading and cancelled.

Title: Re: remember all files ever canceled
Post by: Stu Redman on January 04, 2010, 01:15:24 PM

I'd prefer when it's completed. So if you start a download from a link you have a chance to see it was canceled before.

Title: Re: remember all files ever canceled
Post by: Vollstrecker on January 04, 2010, 01:25:41 PM

That was the intention. If it's in cancelled list, mark it on the search somehow. If someone decides to start it again, move into downloading till it's finished or cancelled again. otherwise you'll get told it was cancelled while you are downloading already again.

Title: Re: remember all files ever canceled
Post by: GonoszTopi on January 04, 2010, 01:57:13 PM

Quote from: Vollstrecker on January 04, 2010, 01:25:41 PM

If it's in cancelled list, mark it on the search somehow.

That's good, but doesn't help if you add the file from an ed2k link (e.g. by clicking a link in your browser).

Title: Re: remember all files ever canceled
Post by: Vollstrecker on January 04, 2010, 02:06:29 PM

Sure, but does anything happen when you click a link that is already downloading, or if you click an already finished link? I don't think so, it just keeps downloading or downloads it again, so no disadvantage on that side, but an advantage for users using the search.

Title: Re: remember all files ever canceled
Post by: Stu Redman on January 04, 2010, 03:06:47 PM

Vollstrecker, the idea is to show an ongoing download as "canceled at some time" (maybe in the properties). This is only possible if the canceled state is kept while downloading. If such a download shows as "canceled" or "downloading" in the search view is a different question.

Title: Re: remember all files ever canceled
Post by: Vollstrecker on January 04, 2010, 03:55:19 PM

ok, In the properties this is something different. Are we already displaying something like "succesfully downloaded a while ago" there?

Title: Re: remember all files ever canceled
Post by: Stu Redman on January 04, 2010, 04:55:33 PM

I don't think so, but there is a feature request (http://bugs.amule.org/view.php?id=1435). It's blocked with the GUI atm.

Title: Re: remember all files ever canceled
Post by: Vollstrecker on January 04, 2010, 04:57:48 PM

Then it should be implemented all in one. just for consitency.

Title: Re: remember all files ever canceled
Post by: Stu Redman on January 04, 2010, 05:50:17 PM

The display in the download property dialog, yes. The marking of canceled in the search dialog can be done before.

Title: Re: remember all files ever canceled
Post by: ernestoI on January 06, 2010, 05:18:34 AM

Wow. I just downloaded and compiled the latest SVN and it works perfectly. I didn't think this would get done so quickly. Thanks!

Title: Re: remember all files ever canceled
Post by: Arichy on March 20, 2010, 10:09:08 AM

Quote from: ernestoI on January 06, 2010, 05:18:34 AM

I didn't think this would get done so quickly. Thanks!

Yes, it took only five years ;) http://forum.amule.org/index.php?topic=5121.0

Thanks to the developers for implementing this great feature.