aMule Forum

English => Compilation problems => Topic started by: OldFrog on February 29, 2008, 10:42:22 AM

Title: Corrupt tarball for SVN from this morning
Post by: OldFrog on February 29, 2008, 10:42:22 AM
The tarball http://www.hirnriss.net/files/cvs/aMule-CVS-20080229.tar.bz2 is corrupt

Title: Re: Corrupt tarball for SVN from this morning
Post by: wuischke on February 29, 2008, 11:38:41 AM
Works for me:
MD5: 772424ef6f5cc0d80bbbba9ee84f666a  aMule-CVS-20080229.tar.bz2
Title: Re: Corrupt tarball for SVN from this morning
Post by: OldFrog on February 29, 2008, 12:22:49 PM
Now, it works for me too. Seems the upload was later than usual, as my download was very slow at first try.
Thanks for concern.
Title: Re: Corrupt tarball for SVN from this morning
Post by: OldFrog on February 29, 2008, 01:20:38 PM
Seems I miss some dev package or there is a wrong include

Quote
gcc -I/usr/include -D__GD__ -W -Wall -Wshadow -Wundef -O2 -pg -DUSE_WX_EXTENSIONS  -L/usr/lib -pg -lpthread -o cas cas-cas.o cas-configfile.o cas-functions.o cas-graphics.o cas-html.o cas-lines.o  -L/usr/lib -L/usr/lib -lXpm -lX11 -ljpeg -lfontconfig -lfreetype -lpng12 -lz -lm  -lz  -lGeoIP
cas-graphics.o: In function `createimage':
graphics.c:(.text+0x52): undefined reference to `gdImageCreateFromPng'
graphics.c:(.text+0x75): undefined reference to `gdImageColorResolve'
graphics.c:(.text+0xfc): undefined reference to `gdImagePng'
graphics.c:(.text+0x11b): undefined reference to `gdImageDestroy'
graphics.c:(.text+0x183): undefined reference to `gdImageStringFT'
graphics.c:(.text+0x1ed): undefined reference to `gdImageJpeg'
collect2: ld a retourné 1 code d'état d'exécution
make[5]: *** [cas] Erreur 1
make[5]: quittant le répertoire « /mnt/stockage/BUILD/amule-cvs/src/utils/cas »
make[4]: *** [all-recursive] Erreur 1
make[4]: quittant le répertoire « /mnt/stockage/BUILD/amule-cvs/src/utils/cas »
Title: Re: Corrupt tarball for SVN from this morning
Post by: wuischke on February 29, 2008, 01:48:58 PM
No, that's the linker, there's a missing "-lgd" for the command. I know what happens, but I failed trying to fix it. I'll try to have a look at it later again.

OK, I know now what commit caused this, but look like I have to take a quick look at automake/m4 files before I can do anything about this.
Title: Re: Corrupt tarball for SVN from this morning
Post by: OldFrog on February 29, 2008, 07:07:15 PM
No, problem, yesterday's release works fine, thanks a lot  ;-)
Title: Re: Corrupt tarball for SVN from this morning
Post by: OldFrog on March 01, 2008, 11:45:19 AM
Same error on today's 20080301's tarball

Quote
gcc -I/usr/include -D__GD__ -W -Wall -Wshadow -Wundef -O2 -pg -DUSE_WX_EXTENSIONS  -L/usr/lib -pg -lpthread -o cas cas-cas.o cas-configfile.o cas-functions.o cas-graphics.o cas-html.o cas-lines.o  -L/usr/lib -L/usr/lib -lXpm -lX11 -ljpeg -lfontconfig -lfreetype -lpng12 -lz -lm  -lz  -lGeoIP
cas-graphics.o: In function `createimage':
graphics.c:(.text+0x52): undefined reference to `gdImageCreateFromPng'
graphics.c:(.text+0x75): undefined reference to `gdImageColorResolve'
graphics.c:(.text+0xfc): undefined reference to `gdImagePng'
graphics.c:(.text+0x11b): undefined reference to `gdImageDestroy'
graphics.c:(.text+0x183): undefined reference to `gdImageStringFT'
graphics.c:(.text+0x1ed): undefined reference to `gdImageJpeg'
collect2: ld a retourné 1 code d'état d'exécution
make[5]: *** [cas] Erreur 1
make[5]: quittant le répertoire « /mnt/stockage/BUILD/amule-cvs/src/utils/cas »
make[4]: *** [all-recursive] Erreur 1
make[4]: quittant le répertoire « /mnt/stockage/BUILD/amule-cvs/src/utils/cas »
make[3]: *** [all-recursive] Erreur 1                                       
Title: Re: Corrupt tarball for SVN from this morning
Post by: wuischke on March 01, 2008, 12:33:12 PM
Yes, this has not been solved yet, I'm sorry. I failed to solve it, but I've asked the responsible developer to have a look at it.
Title: Re: Corrupt tarball for SVN from this morning
Post by: EastWind on March 02, 2008, 03:06:20 AM
Hi,

It seems GDLIB_LIBS is overwritten in line 107 of  m4/gdlib.m4. This line erases GDLIB_LIBS contains -lgd by AC_CHECK_HEADER([gd.h],[$2],[$3]) in at line 103.
I made a personal patch and confirmed tarballe 0228 and later ones are compiled without error and  binaries run.
Modification for GDLIB_CFLAGS and GDLIB_LDFLAGS in the patch might not required but I added it just in case.
I hope this may help.  ;)

diff -uNr a/configure b/configure
--- a/configure   2008-02-29 15:01:04.000000000 +0900
+++ b/configure   2008-03-01 08:25:40.000000000 +0900
@@ -6363,9 +6363,9 @@
 
 
       if test $ac_cv_header_gd_h = yes; then
-        GDLIB_CFLAGS=`$GDLIB_CONFIG_WITH_ARGS --cflags`
-        GDLIB_LDFLAGS=`$GDLIB_CONFIG_WITH_ARGS --ldflags`
-        GDLIB_LIBS=`$GDLIB_CONFIG_WITH_ARGS --libs`
+        GDLIB_CFLAGS="`$GDLIB_CONFIG_WITH_ARGS --cflags` $GDLIB_CFLAGS"
+        GDLIB_LDFLAGS="`$GDLIB_CONFIG_WITH_ARGS  --ldflags` $GDLIB_LDFLAGS"
+        GDLIB_LIBS="`$GDLIB_CONFIG_WITH_ARGS  --libs`  $GDLIB_LIBS"
       else
         GDLIB_VERSION=
       fi
diff -uNr a/m4/gdlib.m4 b/m4/gdlib.m4
--- a/m4/gdlib.m4   2008-02-28 01:53:54.000000000 +0900
+++ b/m4/gdlib.m4   2008-03-01 08:25:15.000000000 +0900
@@ -102,9 +102,9 @@
       AC_MSG_RESULT([yes (version $GDLIB_VERSION)])
       AC_CHECK_HEADER([gd.h],[$2],[$3])
       if test $ac_cv_header_gd_h = yes; then
-        GDLIB_CFLAGS=`$GDLIB_CONFIG_WITH_ARGS --cflags`
-        GDLIB_LDFLAGS=`$GDLIB_CONFIG_WITH_ARGS --ldflags`
-        GDLIB_LIBS=`$GDLIB_CONFIG_WITH_ARGS --libs`
+        GDLIB_CFLAGS="`$GDLIB_CONFIG_WITH_ARGS --cflags` $GDLIB_CFLAGS"
+        GDLIB_LDFLAGS="`$GDLIB_CONFIG_WITH_ARGS  --ldflags` $GDLIB_LDFLAGS"
+        GDLIB_LIBS="`$GDLIB_CONFIG_WITH_ARGS  --libs`  $GDLIB_LIBS"
       else
         GDLIB_VERSION=
       fi


Title: Re: Corrupt tarball for SVN from this morning
Post by: OldFrog on March 02, 2008, 10:32:28 AM
I didn't try Eastwind's modification (Sounds good anyway), as I have an automatized download and RPM generation in cron.
Still the same error today anyway.
I hope I find some time today to try the fix.
Thanks a lot.
Title: Re: Corrupt tarball for SVN from this morning
Post by: wuischke on March 02, 2008, 11:20:28 AM
EastWind: Thanks a lot for your patch! It is included in tomorrow's tarball.
Title: Re: Corrupt tarball for SVN from this morning
Post by: EastWind on March 03, 2008, 01:47:34 PM
That's my pleasure. The new tarball has been successfully compiled here also without patch.
Thank you,
Title: Re: Corrupt tarball for SVN from this morning
Post by: wuischke on March 03, 2008, 04:27:16 PM
Thank GonoszTopi. My understanding of the automake things is very small, that's why I failed to find the actual source of the problem.

He changed the patch a little bit as well and it looks like it is working very well now. Oh, but then he was the one who broke in the first place, too. ;-)
Title: Re: Corrupt tarball for SVN from this morning
Post by: OldFrog on March 03, 2008, 10:34:48 PM
Confirmation, it works !  Thanks a lot !
Title: Re: Corrupt tarball for SVN from this morning
Post by: Festor on March 03, 2008, 10:37:01 PM
Confirmation, it works !  Thanks a lot !

Also works for me :D Thanks !