aMule Forum

English => Feature requests => Topic started by: pochu on April 01, 2008, 08:10:08 PM

Title: Support Default Browser and Default video player whenever possible
Post by: pochu on April 01, 2008, 08:10:08 PM

Hello all,

I've got this bugs in Ubuntu:
https://launchpad.net/bugs/209810
https://launchpad.net/bugs/89672

I think there should be a 'Default Browser' and 'Default video player' whenever possible. I don't know whether/how that could be done for Windows/MacOS, but for Linux there's xdg-open (http://portland.freedesktop.org/xdg-utils-1.0/xdg-open.html), which is a Freedesktop tool, which will open any file in the preferred application. So this would work for Web pages (Default Browser), and video files (Default video player).

So on the first aMule launch, if xdg-open (or similar for other platforms if they have something like this) is available in $PATH, it would use that as default.

What do you think about this? Comments appreciated.

Title: Re: Support Default Browser and Default video player whenever possible
Post by: eisa01 on April 01, 2008, 10:45:39 PM

For mac, /usr/bin/open works fine.

Title: Re: Support Default Browser and Default video player whenever possible
Post by: Festor on May 24, 2008, 11:54:16 PM

I tried to make a patch but I have not succeeded, apparently it is necessary to make more changes than simply replace mplayer by xdg-open.

Regarding the default browser I think I have had more luck. I think it is best to use the firefox default because his popularity respect to konqueror is important. The only problem is that we should change all translations.

Title: Re: Support Default Browser and Default video player whenever possible
Post by: Kry on May 25, 2008, 12:00:41 AM

wx already opens the default browser.

Title: Re: Support Default Browser and Default video player whenever possible
Post by: Festor on May 25, 2008, 12:53:30 AM

O.o.... and why there is a web browser dialog in aMule preferences?

I found this:

http://bugs.amule.org/view.php?id=1308

I believe this patch xdg-open is better than mine. I changed a little this new patch  ;D

Title: Re: Support Default Browser and Default video player whenever possible
Post by: ozsd on February 13, 2009, 01:42:31 PM

Has this been applied? Apparently not in 2.2.3 and I can't check SVN version (the SVN download site is too slow).

Title: Re: Support Default Browser and Default video player whenever possible
Post by: phoenix on February 28, 2009, 12:13:49 PM

As far as I can see, none of these patches have been applied, and the web browser patch no longer makes sense with the present code.

I think that we should take this idea a little bit further and use a general preview system. Currently we only preview movies. What do you think about using xdg-open to start an application on any downloaded file? Of course, some applications will fail due to the incompleteness of the file, but I think that this is worthty, it will improove useability.

That should be much easier to code, but would switch the configuration to the system. So, in some place we should explain the user how to make xdg-open to call the program he wants.

What do you think?

Title: Re: Support Default Browser and Default video player whenever possible
Post by: Festor on March 02, 2009, 12:36:39 AM

https://launchpad.net/ubuntu/jaunty/+source/amule/2.2.3-1ubuntu1

  * Now aMule will use user's preferred app to see previews. Fixed (LP: #89672)
   + Added use_xdg-open.diff patch