aMule Forum

English => Feature requests => Topic started by: gav616 on June 23, 2009, 01:35:52 PM

Title: transfer session chunk size
Post by: gav616 on June 23, 2009, 01:35:52 PM

10.00 MB  > 9.28 MB

reasons are;
correct and faster rotation of queue i.e. you can upload more full chunks in the same time as 10MB sessions.
mule devs say so.

Title: Re: transfer session chunk size
Post by: Kry on June 23, 2009, 03:09:52 PM

What?

Title: Re: transfer session chunk size
Post by: gav616 on June 23, 2009, 03:17:25 PM

a request to change the amount to upload to each client in one session to 9.28MB (one full chunk) instead of  what amule currently does; 10MB.

Title: Re: transfer session chunk size
Post by: Kry on June 23, 2009, 03:27:50 PM

... aMule uploads 10MB?

Title: Re: transfer session chunk size
Post by: myth on June 23, 2009, 03:30:08 PM

In some cases, yes...it's something wrong with checkfortimerover() i think....

Title: Re: transfer session chunk size
Post by: gav616 on June 23, 2009, 03:37:11 PM

Quote from: myth on June 23, 2009, 03:30:08 PM

In some cases, yes...it's something wrong with checkfortimerover() i think....

for me, it's always 10mb.

Title: Re: transfer session chunk size
Post by: ^marcell^ on June 23, 2009, 06:31:41 PM

How do you check this?

I have a 699 MB file in my download queue and aMule says it's split in 76 parts. Which is approximately 9.28 MB each.

Title: Re: transfer session chunk size
Post by: myth on June 23, 2009, 07:06:00 PM

Not this...

Shure the file is split every 9.28 MB!

The strange thing is that aMule uploads 10 MB to each client before kicking him from upload...

...try to see in uploadlist....if they're kicked after 10 MB or 9.28 MB...

Title: Re: transfer session chunk size
Post by: GonoszTopi on June 23, 2009, 09:31:54 PM

"Try to transfer full chunks..." in aMule always resulted in the upload being terminated after 10.00 MB uploaded. In eMule currently it's PARTSIZE+20*1024 = ~9.30 MB.

Title: Re: transfer session chunk size
Post by: Stu Redman on June 23, 2009, 09:36:44 PM

There's nothing strange about that.

Code: [Select]

if (thePrefs::TransferFullChunks()) {
// "Transfer full chunks": drop client after 10 MB upload, or after an hour.
// (so average UL speed should at least be 2.84 kB/s)
// We don't track what he is downloading, but if it's all from one chunk he gets it.
if (client->GetUpStartTimeDelay() > 3600000 // time: 1h
|| client->GetSessionUp() > 10485760) { // data: 10MB
kickHim = true;
}
} else {
The limit has been 10MB since before SVN.

eMule sends a bit less:

Code: (srchybrid\opcodes.h(96):) [Select]

#define SESSIONMAXTRANS   (PARTSIZE+20*1024) // "Try to send complete chunks" always sends this amount of data
- GonoszTopi beat me I see.  :)

Title: Re: transfer session chunk size
Post by: myth on June 24, 2009, 02:31:45 AM

Quote from: Stu Redman on June 23, 2009, 09:36:44 PM

- GonoszTopi beat me I see.  :)

Yep! :D

Title: Re: transfer session chunk size
Post by: gav616 on June 24, 2009, 11:08:08 PM

But, why does aMule send more?

I thought we (you) try  to stick to eMule protocol, so why 10 and not 9.28?

Title: Re: transfer session chunk size
Post by: gav616 on June 27, 2009, 08:41:33 PM

anyone?

Title: Re: transfer session chunk size
Post by: Stu Redman on June 27, 2009, 09:44:28 PM

If nobody remembers a reason for the 10MB I'd reduce it to eMule's PARTSIZE + 20k. (Even though that's not exactly "protocol", gav616.)

Title: Re: transfer session chunk size
Post by: Kry on June 27, 2009, 10:54:26 PM

It has nothing to do with protocol at all. This is just to try and ensure they're completing parts. eMule uploads less to make sure, we upload more. Nothing to see here.

Title: Re: transfer session chunk size
Post by: myth on June 28, 2009, 02:30:56 AM

...like someone says: Never change a running system... :P

...and it works good so! I notice it when i release stuff alone ;)

Title: Re: transfer session chunk size
Post by: GonoszTopi on June 28, 2009, 08:24:20 AM

Works good, makes no harm, gets you more credit... nothing to do here.