aMule Forum

English => Offtopic Section (Nonsense inside) => GFX => Topic started by: myth on July 31, 2009, 12:12:33 PM

Title: aMule statistics! :)
Post by: myth on July 31, 2009, 12:12:33 PM
Well...for now i post a screenie of the stats window, until we can have a copy feature of the text! :D

(http://img5.imagebanana.com/img/uw8onyh/thumb/stasts.png) (http://img5.imagebanana.com/view/uw8onyh/stasts.png)

There seems also to be a small bug where it says "Found sources"....without a download they are too much! :D

Post your stats, too! :)
Title: Re: aMule statistics! :)
Post by: Kry on July 31, 2009, 12:54:48 PM
That found sources looks like a -1 to me.
Title: Re: aMule statistics! :)
Post by: Stu Redman on July 31, 2009, 08:58:36 PM
I think this should fix it:
Code: [Select]
Index: DownloadQueue.cpp
===================================================================
--- DownloadQueue.cpp (revision 9731)
+++ DownloadQueue.cpp (working copy)
@@ -572,13 +572,7 @@
  } else {
  // Source was known, but reqfile NULL.
  source->SetRequestFile( sender );
- if (source->GetSourceFrom() != nSourceFrom) {
- if (source->GetSourceFrom() != SF_NONE) {
- theStats::RemoveSourceOrigin(source->GetSourceFrom());
- theStats::RemoveFoundSource();
- }
- source->SetSourceFrom(nSourceFrom);
- }
+ source->SetSourceFrom(nSourceFrom);
  sender->AddSource( source );
  if ( source->GetFileRating() || !source->GetFileComment().IsEmpty() ) {
  sender->UpdateFileRatingCommentAvail();

Sources are supposed to be counted through CPartFile::AddSource, CPartFile::DelSource . I don't see why the sourceFrom of a client without a RequestFile should influence the stats. Anybody disagree?  :-\
Title: Re: aMule statistics! :)
Post by: GonoszTopi on July 31, 2009, 09:17:25 PM
Quote from: Stu Redman on July 31, 2009, 08:58:36 PM
Anybody disagree?
No. At least me not.
Title: Re: aMule statistics! :)
Post by: ^marcell^ on August 01, 2009, 06:48:50 PM
I noticed that the total UL:DL ratio is not displayed. It should be there at the top in parentheses.
Title: Re: aMule statistics! :)
Post by: myth on August 02, 2009, 01:51:40 AM
Yeah, would be nice! ;)
Title: Re: aMule statistics! :)
Post by: Stu Redman on August 02, 2009, 09:51:34 PM
Total UL:DL ratio is now displayed (9741). And I committed the fix for the negative sources (9743). Myth, please verify if it fixes the problem.
Title: Re: aMule statistics! :)
Post by: ^marcell^ on August 03, 2009, 07:43:06 PM
Quote from: Stu Redman on August 02, 2009, 09:51:34 PM
Total UL:DL ratio is now displayed (9741). And I committed the fix for the negative sources (9743). Myth, please verify if it fixes the problem.
Good job, I'll try to verify later.
Title: Re: aMule statistics! :)
Post by: myth on August 04, 2009, 12:48:33 AM
Until now, both work very fine! THX!
Title: Re: aMule statistics! :)
Post by: myth on May 16, 2010, 12:04:37 PM
Here some longtime stats, before using the new gui ;)

(http://www.imagebanana.com/img/6ac8z9gj/thumb/Screenshot1.png) (http://www.imagebanana.com/view/6ac8z9gj/Screenshot1.png)