aMule Forum

English => Translations (i18n) => Topic started by: ^marcell^ on January 06, 2010, 07:57:37 PM

Title: [consistency] Canceled OR Cancelled
Post by: ^marcell^ on January 06, 2010, 07:57:37 PM

Dear developers,

I have noticed that both of the words "canceled" (American English) and "cancelled" (British English) are used in the original message strings.

Code: [Select]

#: src/HTTPDownload.cpp:108
msgid "HTTP download cancelled"
msgstr ""

#: src/utils/aLinkCreator/src/alcframe.cpp:574
#: src/utils/aLinkCreator/src/alcframe.cpp:575
#: src/utils/aLinkCreator/src/md4.cpp:359
msgid "Cancelled !"
msgstr ""
versus

Code: [Select]

#: src/CanceledFileList.cpp:61
msgid "WARNING: Canceled file list corrupted, contains invalid header."
msgstr ""

#: src/SearchListCtrl.cpp:945
msgid "Canceled"
msgstr ""
My opinion is that it should be consistent and therefore should be changed to only use one of the two. My suggestion is to use "cancelled".

Title: Re: [consistency] Canceled OR Cancelled
Post by: Stu Redman on January 06, 2010, 10:51:06 PM

Let's not turn this into a mud-bath of English vs American, bloke. (If you kinda feel "huh?" at that phrase and like me find "guy" more natural you should also favor "canceled".)
Anyway, I've just committed a largish change that is crawling with "canceled" (file names, classes, methods, variables...) and I would therefore very much prefer this version. We can always make a second English translation for American English, now that we found an example of difference in our actual texts.

Title: Re: [consistency] Canceled OR Cancelled
Post by: wuischke on January 06, 2010, 11:15:23 PM

I believe we used to have an en_GB translation, which indicates that aMule was originally written in American English. If there was a vote, I'm in favour of British English.

Title: Re: [consistency] Canceled OR Cancelled
Post by: GonoszTopi on January 07, 2010, 01:15:31 PM

Quote from: wuischke on January 06, 2010, 11:15:23 PM

I believe we used to have an en_GB translation, which indicates that aMule was originally written in American English.

You might be right, but lately we only used that file to last-minute fix Engrish texts. Consisteny would indeed be a Good Thing(TM), and we can always have the other variant as a .po translation.

Quote from: wuischke on January 06, 2010, 11:15:23 PM

If there was a vote, I'm in favour of British English.

Now you can vote ;)