aMule Forum

English => en_Bugs => Topic started by: stoatwblr on May 09, 2010, 03:28:35 PM

Title: EC timeout on "reload shared"
Post by: stoatwblr on May 09, 2010, 03:28:35 PM

This is consistent no matter how I compile things.

Currently running 10131  but it's been like it for a while

aMulecmd$ status
 > eD2k: Connected to P2P Cloud [193.107.208.38:4184] with HighID
 > Kad: Connected (ok)
 > Download:   58.39 kB/s
 > Upload:   49.99 kB/s
 > Clients in queue:   1625
 > Total sources:   1728
aMulecmd$ reload shared
ECSocket.cpp(204): ReadFromSocketAll: socket is blocking
No error happened
ECSocket.cpp(307): SendRecvPacket: error
aMulecmd$ status
 > Operation was successful.

The reload shared command is picked up by amuled, so are subsequent ones.

There are currently ~3000 shared files.

Title: Re: EC timeout on "reload shared"
Post by: Stu Redman on May 09, 2010, 05:40:48 PM

Well, sharing 3000 files is approaching limits. The reload task is done in the foreground and takes a while. Amulecmd uses synchronous communication which times out in this case. Some other things might break too (like connections can timeout). You did compile amuled with optimizations?

Moving the reload to a background thread might result in a lot of new and interesting problems, but would be the best solution.
But maybe a little tweak to the reload code might do the trick. I don't know what exactly takes so long, but I sure don't like that linear search in the known file list.

Title: Re: EC timeout on "reload shared"
Post by: Stu Redman on May 09, 2010, 08:54:17 PM

Please try this patch and tell me if it improves your reload time.

Title: Re: EC timeout on "reload shared"
Post by: stoatwblr on May 13, 2010, 08:45:47 PM

Wow...... about 5-10 times faster (at least)

Title: Re: EC timeout on "reload shared"
Post by: Stu Redman on May 13, 2010, 10:40:52 PM

Ah - first good news of the day.  :)

Title: Re: EC timeout on "reload shared"
Post by: Stu Redman on May 13, 2010, 11:32:28 PM

Committed in 10155.

Title: Re: EC timeout on "reload shared"
Post by: stoatwblr on May 17, 2010, 02:17:08 AM

This sped up the gui as well - right click tab context menus also work reliably too.

Title: Re: EC timeout on "reload shared"
Post by: Schuttwegraeumer on May 17, 2010, 08:58:05 AM

and how can i reload the share, the button is gone since a view SVN?

Title: Re: EC timeout on "reload shared"
Post by: Stu Redman on May 17, 2010, 07:27:05 PM

Huh? It's on the right on top.